Feature/32 test compatibility biosimulators remotely #42
Conversation
Run tests on features/* branches
…' into feature/32-test-compatibility-biosimulators-remotely
|
Will have to tweak some things to make it compatible with pyNeuroML Biosimulations before it's ready for review. |
…toring of test_compatibility_biosimulators.py
|
Remote results has been added to the previous (local) results table as discussed in our meeting last week. |
There was a problem hiding this comment.
The "#!/usr/bin/env python" line has to be the first line in order to work. So it should either be removed or moved to the first line. I think the two python comments above and below it can be combined into one?
| import utils | ||
| import os | ||
| import pandas as pd | ||
| from IPython.display import display_markdown |
There was a problem hiding this comment.
display_markdown seems not to be needed in this script? Therefore we could probably remove the requirement for IPython?
There was a problem hiding this comment.
Good catch. Done! :)
| import shutil | ||
| import argparse | ||
|
|
||
| parser = argparse.ArgumentParser(description='Test compatibility of different biosimulation engines') |
There was a problem hiding this comment.
The --output-dir option is still being passed to the script in the non-oml.yml GH action, but is ignored due to this code block being removed. It might be useful to retain this option to allow easy testing without being forced to overwrite an existing output folder that you want to keep?
…ity_biosimulators
stellaprins
deleted the
feature/32-test-compatibility-biosimulators-remotely
branch
3 participants
A first draft of the remote table.
May need some refactoring.
merge PR #37 first to avoid possible merging conflicts