-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/31 create lems nml2 ex9 fn docker results table #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/31 create lems nml2 ex9 fn docker results table #37
Conversation
…simulators docker test table
…minary results table and update jupyter notebook
…imulators_compatibility output folder
…oherent with py and ipynb
|
Development
…cker-results-table
|
As discused, ARC can use the development branch as your staging post for stable updates. @stellaprins do set @robertvi as the suggested reviewer on this if it's ready for him to check and then open a PR to master with one of us assigned if it's ready for us to check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe hook this into GH actions testing in the same way as test_biosimulators_docker.py?
Regenerating some files
… permission issues
…ub Actions permission issues
…lve GitHub Actions permission issues" This reverts commit 64c2f64.
…creates the output folder
…ip on non-windows hosts
|
added some code in the biosimulators_core functions that tries to change the file ownership of the docker output folder from root back to the user; I tried telling docker to run as the user instead of root but that caused the simulations to fail |
|
moved the code to change owner of the outputs into the calling function, to avoid it being inside the try/except block, but it still seems to not work |
|
Seems to work now, part of the problem seems to be output from a previous push's tests or a previous test in the same push still be present under the "output" folder, and being owned by root still. |
|
I was running out of space on my local machine testing the script, because the docker container runs seemed to be leaving a new image on disk after each run. I cleared them using 'docker system prune --all --volumes' |

No description provided.