Skip to content

Conversation

@stellaprins
Copy link
Collaborator

No description provided.

@stellaprins
Copy link
Collaborator Author

  • correct engines_dict for OpenCOR
  • merge dev into feature/31 branch

@stellaprins stellaprins marked this pull request as ready for review July 5, 2024 15:22
@pgleeson
Copy link
Member

pgleeson commented Jul 5, 2024

As discused, ARC can use the development branch as your staging post for stable updates. @stellaprins do set @robertvi as the suggested reviewer on this if it's ready for him to check and then open a PR to master with one of us assigned if it's ready for us to check.

@robertvi robertvi self-requested a review July 31, 2024 10:16
Copy link
Collaborator

@robertvi robertvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe hook this into GH actions testing in the same way as test_biosimulators_docker.py?

@robertvi
Copy link
Collaborator

robertvi commented Aug 1, 2024

Screenshot (440)

I am now getting the same error as the github action: the reason is that the files outputted from the model running in docker are set to be owned by root therefore the script does not have permission to move or delete them after the model finishes running

@robertvi
Copy link
Collaborator

robertvi commented Aug 1, 2024

added some code in the biosimulators_core functions that tries to change the file ownership of the docker output folder from root back to the user; I tried telling docker to run as the user instead of root but that caused the simulations to fail

@robertvi
Copy link
Collaborator

robertvi commented Aug 1, 2024

moved the code to change owner of the outputs into the calling function, to avoid it being inside the try/except block, but it still seems to not work

@robertvi
Copy link
Collaborator

robertvi commented Aug 2, 2024

Seems to work now, part of the problem seems to be output from a previous push's tests or a previous test in the same push still be present under the "output" folder, and being owned by root still.

@robertvi
Copy link
Collaborator

robertvi commented Aug 5, 2024

I was running out of space on my local machine testing the script, because the docker container runs seemed to be leaving a new image on disk after each run. I cleared them using 'docker system prune --all --volumes'

@stellaprins stellaprins merged commit 015699e into development Aug 5, 2024
@stellaprins stellaprins deleted the feature/31-create-lems_nml2_ex9_fn-docker-results-table branch October 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants