Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement #831

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

viclovsky
Copy link
Contributor

@viclovsky viclovsky commented Aug 17, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Hi,
I found problem with javadoc for params and fixed it.
Also I added "@Api" swagger annotation, "nickname" for "@ApiOperation".

@viclovsky
Copy link
Contributor Author

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@jmini jmini changed the title [Java][Rest-assured] Fix javadock for rest-assured and "swagger-annotations" improvement [Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement Aug 17, 2018
@jmini jmini added this to the 3.2.2 milestone Aug 17, 2018
@jmini jmini merged commit 0191210 into OpenAPITools:master Aug 17, 2018
@jmini
Copy link
Member

jmini commented Aug 17, 2018

Tested locally with:

mvn verify -f samples/client/petstore/java/rest-assured/

jimschubert added a commit that referenced this pull request Aug 21, 2018
* master:
  Fix problems in typescript jquery generator (#801)
  [PHP] Add gitignore to AbstractPhpCodegen (#765)
  Improve documentation for usage of a generator in an other jar (#817)
  Improve Symfony 4.1 compatibility (#830)
  📝 Updating 'help generate' switches in README
  [cli] Don't log to STDOUT if debug flags are set (#474)
  [gradle-plugin] README notes on multiple specs (#847)
  Added server variable support (#816)
  fix erlang optiona/required parameters (#829)
  [Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement (#831)
@wing328
Copy link
Member

wing328 commented Aug 22, 2018

@viclovsky thanks for the fix, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
… improvement (OpenAPITools#831)

Added "@Api" swagger annotation, "nickname" for ApiOperation. 
Fixed javadock for rest-assured client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants