Improve Symfony 4.1 compatibility #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarlovi
suggested changes
Aug 17, 2018
| @@ -25,7 +25,7 @@ | |||
| "ext-mbstring": "*", | |||
| "symfony/validator": "*", | |||
| "jms/serializer-bundle": "*", | |||
| "symfony/framework-bundle": "^2.3|^3.0" | |||
There was a problem hiding this comment.
Because 4.0 is pretty much EOL at this point (security fixes only). So adding support at this point does not make sense.
There was a problem hiding this comment.
I think we can go with ^4.1 to start with. If a user needs 4.0, he/she can do so by customizing the templates.
|
@Addvilz thanks for the PR. If no one has further feedback, I'll merge it tomorrow. |
ybelenko
approved these changes
Aug 19, 2018
jimschubert
added a commit
that referenced
this pull request
Aug 21, 2018
* master: Fix problems in typescript jquery generator (#801) [PHP] Add gitignore to AbstractPhpCodegen (#765) Improve documentation for usage of a generator in an other jar (#817) Improve Symfony 4.1 compatibility (#830) 📝 Updating 'help generate' switches in README [cli] Don't log to STDOUT if debug flags are set (#474) [gradle-plugin] README notes on multiple specs (#847) Added server variable support (#816) fix erlang optiona/required parameters (#829) [Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement (#831)
|
@Addvilz thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832 |
|
@wing328 awesome, thanks! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
|
#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Allow for Symfony 4.1 dependency and quote container params.
Both changes should be safe, bc compatible changes.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko