-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Symfony 4.1 compatibility #830
Improve Symfony 4.1 compatibility #830
Conversation
@@ -25,7 +25,7 @@ | |||
"ext-mbstring": "*", | |||
"symfony/validator": "*", | |||
"jms/serializer-bundle": "*", | |||
"symfony/framework-bundle": "^2.3|^3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not ^4.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because 4.0 is pretty much EOL at this point (security fixes only). So adding support at this point does not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go with ^4.1
to start with. If a user needs 4.0, he/she can do so by customizing the templates.
@Addvilz thanks for the PR. If no one has further feedback, I'll merge it tomorrow. |
* master: Fix problems in typescript jquery generator (#801) [PHP] Add gitignore to AbstractPhpCodegen (#765) Improve documentation for usage of a generator in an other jar (#817) Improve Symfony 4.1 compatibility (#830) 📝 Updating 'help generate' switches in README [cli] Don't log to STDOUT if debug flags are set (#474) [gradle-plugin] README notes on multiple specs (#847) Added server variable support (#816) fix erlang optiona/required parameters (#829) [Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement (#831)
@Addvilz thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832 |
@wing328 awesome, thanks! |
#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
Allow for Symfony 4.1 dependency and quote container params.
Both changes should be safe, bc compatible changes.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko