[PHP] Add gitignore to AbstractPhpCodegen #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After conversation with @ackintosh we've agreed that every PHP codegen should create it's own `.gitignore`. Client libraries(SDKs) should ignore `composer.lock` file while server stubs better do opposite.
Seems like issue OpenAPITools#663 and pull request OpenAPITools#681 missed this security script, I've changed output path in bin/security/silex-petstore-server.sh.
I've copied few old rules from root gitignore to local one. These rules should be reviewed by original SymfonyCodegen authors.
|
Shippable CI reports the following issue: Please run |
|
@wing328 Done. But I think we need to wait response from another PHP collaborators. |
|
As discussed, I suggested adding a "Ref" to give credit the "source", e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/R/.gitignore#L1 |
|
If no one has further feedback, I'll merge this PR into master tomorrow (Friday) |
wing328
approved these changes
Aug 20, 2018
jimschubert
added a commit
that referenced
this pull request
Aug 21, 2018
* master: Fix problems in typescript jquery generator (#801) [PHP] Add gitignore to AbstractPhpCodegen (#765) Improve documentation for usage of a generator in an other jar (#817) Improve Symfony 4.1 compatibility (#830) 📝 Updating 'help generate' switches in README [cli] Don't log to STDOUT if debug flags are set (#474) [gradle-plugin] README notes on multiple specs (#847) Added server variable support (#816) fix erlang optiona/required parameters (#829) [Java][Rest-assured] Fix generated javadoc and "swagger-annotations" improvement (#831)
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [PHP] Remove PHP related rules from root gitignore After conversation with @ackintosh we've agreed that every PHP codegen should create it's own `.gitignore`. Client libraries(SDKs) should ignore `composer.lock` file while server stubs better do opposite. * [PHP] Set .gitignore as default supporting file * [PHP] Add default gitignore to Client SDK * [PHP] Add default gitignore to Laravel * [PHP] Add default gitignore to Lumen * [PHP] Add default gitignore to Silex Seems like issue OpenAPITools#663 and pull request OpenAPITools#681 missed this security script, I've changed output path in bin/security/silex-petstore-server.sh. * [PHP] Update Slim * [PHP] Add default gitignore to Symfony I've copied few old rules from root gitignore to local one. These rules should be reviewed by original SymfonyCodegen authors. * [PHP] Add default gitignore to Zend * [PHP] Refresh Openapi3 client samples * [PHP] Add refs to .gitignore templates collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.Description of the PR
After conversation with @ackintosh we've agreed that we need to remove PHP related rules from root
.gitignore. All PHP codegens should produce own.gitignoreby default.What I did:
.gitignoreto supportingFiles inAbstractPhpCodegen.gitignorefor each PHP codegen from this repo.gitignoreto local Symfony.gitignore. Check a20e201About
composer.lock. I think, it does make sense to commitcomposer.lockin server implementations and do opposite in client SDK.This PR is big and serious, so I can wait while all PHP codegens will be properly checked.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh