-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Add workflow to test TypeScript clients #22126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| name: Samples TS clients | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - samples/client/others/typescript-angular/** | ||
| # comment out angular released before Nov 2023 | ||
| #- samples/client/petstore/typescript-angular-v12-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v13-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v14-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v15-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v16-provided-in-root/** | ||
| # comment out below as there's no pom.xml | ||
| #- samples/client/petstore/typescript-angular-v17-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v18-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v19-provided-in-root/** | ||
| - samples/openapi3/client/petstore/typescript/builds/default/** | ||
| # comment out due to build failure | ||
| #- samples/openapi3/client/petstore/typescript/tests/default/** | ||
| - samples/openapi3/client/petstore/typescript/builds/jquery/** | ||
| # comment out due to build failure | ||
| #- samples/openapi3/client/petstore/typescript/tests/jquery/** | ||
| - samples/openapi3/client/petstore/typescript/builds/object_params/** | ||
| # comment out due to build failure | ||
| #- samples/openapi3/client/petstore/typescript/tests/object_params/** | ||
| #- samples/openapi3/client/petstore/typescript/builds/inversify/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/inversify/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/deno/** | ||
| - samples/openapi3/client/petstore/typescript/builds/browser/** | ||
| # comment out due to build failure | ||
| #- samples/openapi3/client/petstore/typescript/tests/browser/** | ||
| #- samples/openapi3/client/petstore/typescript/builds/nullable-enum/** | ||
| - samples/client/petstore/typescript-fetch/builds/default/** | ||
| - samples/client/petstore/typescript-fetch/builds/es6-target/** | ||
| - samples/client/petstore/typescript-fetch/builds/with-npm-version/** | ||
| - samples/client/petstore/typescript-fetch/tests/default/** | ||
| # comment out due to build failure | ||
| #- samples/client/petstore/typescript-node/npm/** | ||
| - samples/client/petstore/typescript-rxjs/builds/with-npm-version/** | ||
| - samples/client/petstore/typescript-axios/builds/with-npm-version/** | ||
| # comment out due to build failure | ||
| #- samples/client/petstore/typescript-axios/tests/default/** | ||
| pull_request: | ||
| paths: | ||
| - samples/client/others/typescript-angular/** | ||
| #- samples/client/petstore/typescript-angular-v12-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v13-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v14-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v15-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v16-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v17-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v18-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v19-provided-in-root/** | ||
| - samples/openapi3/client/petstore/typescript/builds/default/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/default/** | ||
| - samples/openapi3/client/petstore/typescript/builds/jquery/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/jquery/** | ||
| - samples/openapi3/client/petstore/typescript/builds/object_params/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/object_params/** | ||
| #- samples/openapi3/client/petstore/typescript/builds/inversify/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/inversify/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/deno/** | ||
| - samples/openapi3/client/petstore/typescript/builds/browser/** | ||
| #- samples/openapi3/client/petstore/typescript/tests/browser/** | ||
| #- samples/openapi3/client/petstore/typescript/builds/nullable-enum/** | ||
| - samples/client/petstore/typescript-fetch/builds/default/** | ||
| - samples/client/petstore/typescript-fetch/builds/es6-target/** | ||
| - samples/client/petstore/typescript-fetch/builds/with-npm-version/** | ||
| - samples/client/petstore/typescript-fetch/tests/default/** | ||
| #- samples/client/petstore/typescript-node/npm/** | ||
| - samples/client/petstore/typescript-rxjs/builds/with-npm-version/** | ||
| - samples/client/petstore/typescript-axios/builds/with-npm-version/** | ||
| #- samples/client/petstore/typescript-axios/tests/default/** | ||
| jobs: | ||
| build: | ||
| name: Build projects | ||
| runs-on: ubuntu-latest | ||
| services: | ||
| petstore-api: | ||
| image: swaggerapi/petstore | ||
| ports: | ||
| - 80:8080 | ||
| env: | ||
| SWAGGER_HOST: http://petstore.swagger.io | ||
| SWAGGER_BASE_PATH: /v2 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node: | ||
| #- "18.x" | ||
| - "20.x" | ||
| sample: | ||
| - samples/client/others/typescript-angular/ | ||
| #- samples/client/petstore/typescript-angular-v12-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v13-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v14-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v15-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v16-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v17-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v18-provided-in-root/ | ||
| #- samples/client/petstore/typescript-angular-v19-provided-in-root/ | ||
| - samples/openapi3/client/petstore/typescript/builds/default/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/default/ | ||
| - samples/openapi3/client/petstore/typescript/builds/jquery/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/jquery/ | ||
| - samples/openapi3/client/petstore/typescript/builds/object_params/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/object_params/ | ||
| #- samples/openapi3/client/petstore/typescript/builds/inversify/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/inversify/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/deno/ | ||
| - samples/openapi3/client/petstore/typescript/builds/browser/ | ||
| #- samples/openapi3/client/petstore/typescript/tests/browser/ | ||
| #- samples/openapi3/client/petstore/typescript/builds/nullable-enum/ | ||
| - samples/client/petstore/typescript-fetch/builds/default/ | ||
| - samples/client/petstore/typescript-fetch/builds/es6-target/ | ||
| - samples/client/petstore/typescript-fetch/builds/with-npm-version/ | ||
| - samples/client/petstore/typescript-fetch/tests/default/ | ||
| #- samples/client/petstore/typescript-node/npm/ | ||
| - samples/client/petstore/typescript-rxjs/builds/with-npm-version/ | ||
| - samples/client/petstore/typescript-axios/builds/with-npm-version/ | ||
| #- samples/client/petstore/typescript-axios/tests/default/ | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - name: Add hosts to /etc/hosts | ||
| run: | | ||
| sudo echo "127.0.0.1 petstore.swagger.io" | sudo tee -a /etc/hosts | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' # Specify your desired Java version | ||
| distribution: 'temurin' # Or 'adopt', 'oracle', etc. | ||
| cache: maven # Cache Maven dependencies for faster builds | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| cache: 'npm' # Or 'yarn' | ||
| - name: mvn integration-test | ||
| working-directory: ${{ matrix.sample }} | ||
| run: mvn integration-test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,3 +60,4 @@ | |
| </plugins> | ||
| </build> | ||
| </project> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,3 +57,4 @@ | |
| </plugins> | ||
| </build> | ||
| </project> | ||
|
|
||
60 changes: 60 additions & 0 deletions
60
samples/openapi3/client/petstore/typescript/builds/nullable-enum/pom.xml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests for angular 16 should be re-enabled or ported to angular 19: https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/typescript-angular-v16-provided-in-root/tests/default/src
currently, no angular unit test runs as part of the PR checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review
let me re-enable it tomorrow with a PR
if it passes in circleci, it should also pass in the github workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: done via #22138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx