Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Oct 14, 2025

Add workflow to test TypeScript clients (migrate from CircleCI workflow)

Currently, only test with Node 20.x but we can easily test other node versions in the workflow.

Comment out some tests which failed or the folders do not contain pom.xml yet.

For a list of errors with the failed tests, please refer to https://github.com/OpenAPITools/openapi-generator/actions/runs/18489477998/job/52679530366?pr=22126

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member Author

wing328 commented Oct 14, 2025

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) for review

@wing328 wing328 marked this pull request as ready for review October 14, 2025 08:33
@wing328 wing328 merged commit 89b0bc4 into master Oct 14, 2025
37 checks passed
@wing328 wing328 deleted the ts-clients branch October 14, 2025 08:33
@wing328
Copy link
Member Author

wing328 commented Oct 14, 2025

Sorry accidentally pressed the merge button. Happy to revert the change or file another one on top if anyone spots any issues with the change 🙏

#- samples/client/petstore/typescript-angular-v13-provided-in-root/**
#- samples/client/petstore/typescript-angular-v14-provided-in-root/**
#- samples/client/petstore/typescript-angular-v15-provided-in-root/**
#- samples/client/petstore/typescript-angular-v16-provided-in-root/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests for angular 16 should be re-enabled or ported to angular 19: https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/typescript-angular-v16-provided-in-root/tests/default/src

currently, no angular unit test runs as part of the PR checks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review

let me re-enable it tomorrow with a PR

if it passes in circleci, it should also pass in the github workflow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: done via #22138

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
* add workflow to test ts clients

* update

* update

* run petstore

* update

* trigger build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants