-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Add workflow to test TypeScript clients #22126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) for review |
|
Sorry accidentally pressed the merge button. Happy to revert the change or file another one on top if anyone spots any issues with the change 🙏 |
| #- samples/client/petstore/typescript-angular-v13-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v14-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v15-provided-in-root/** | ||
| #- samples/client/petstore/typescript-angular-v16-provided-in-root/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests for angular 16 should be re-enabled or ported to angular 19: https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/typescript-angular-v16-provided-in-root/tests/default/src
currently, no angular unit test runs as part of the PR checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review
let me re-enable it tomorrow with a PR
if it passes in circleci, it should also pass in the github workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: done via #22138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
* add workflow to test ts clients * update * update * run petstore * update * trigger build
Add workflow to test TypeScript clients (migrate from CircleCI workflow)
Currently, only test with Node 20.x but we can easily test other node versions in the workflow.
Comment out some tests which failed or the folders do not contain pom.xml yet.
For a list of errors with the failed tests, please refer to https://github.com/OpenAPITools/openapi-generator/actions/runs/18489477998/job/52679530366?pr=22126
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)