Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Oct 15, 2025

Test TypeScript Angular v16 in Github workflow (migrated from CircleCI)

Triggered build failure and worked as expected (https://github.com/OpenAPITools/openapi-generator/actions/runs/18520269122/job/52778498517?pr=22138 failed)

Tests passed via https://github.com/OpenAPITools/openapi-generator/actions/runs/18520313035/job/52778628297?pr=22138

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title test ts angular v16 in github workflow Test TypeScript Angular v16 in Github workflow Oct 15, 2025
@wing328 wing328 marked this pull request as ready for review October 15, 2025 06:48
@wing328 wing328 merged commit 486e0c5 into master Oct 15, 2025
33 of 35 checks passed
@wing328 wing328 deleted the angular16-test branch October 15, 2025 06:51
@wing328 wing328 added this to the 7.17.0 milestone Oct 15, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
* test ts angular v16 in github workflow

* trigger build failure

* Revert "trigger build failure"

This reverts commit c798759.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants