feat(OMN-10423): contract + receipts for cascade integration test by jonahgabriel · Pull Request #616 · OmniNode-ai/onex_change_control

jonahgabriel · 2026-05-01T16:22:43Z

Summary

Paired OCC evidence for omnibase_core PR shipping tests/integration/test_receipt_gate_cascade.py (Wave 6 proof-of-life for OMN-10410)
contracts/OMN-10423.yaml: dod-001 (test file present in PR diff), dod-002 (33 tests pass, 3 xfail pending OMN-10421)
Receipts in drift/dod_receipts/OMN-10423/ for both dod items

Test plan

pre-commit run --all-files — all hooks pass including Validate ticket contract YAML against ModelTicketContract
Both receipt files valid against ModelDodReceipt schema
uv run python scripts/ci/run_contract_compliance_check.py --pr 616 --repo OmniNode-ai/onex_change_control --contracts-dir contracts — 2/2 PASS, 0 WARN, 0 BLOCK
PR title contains OMN-10423

OMN-10423

Summary by CodeRabbit

Documentation
- Introduced formal contract specifications for ticket-identity binding validation with comprehensive evidence collection requirements.
Tests
- Documented unit validation test results (68 passed).
- Documented integration test results (33 passed, 3 expected failures).
- Verified CLI support for new ticket and branch name options.

Pairs with omnibase_core PR implementing I3 invariant: OCC evidence must provably belong to the same ticket as the code PR. Receipts verify: - dod-001: 9 identity-binding tests pass (5 required plan cases) - dod-002: 68 existing receipt_gate tests pass (no regressions) - dod-003: EVIDENCE_SOURCE/TICKET_PATTERN exported in __all__ - dod-004: CLI accepts --evidence-ticket and --branch-name flags

Paired OCC evidence for omnibase_core PR that ships tests/integration/test_receipt_gate_cascade.py — the Wave 6 adversarial proof-of-life gate for the receipt-gate collapse fix (OMN-10410). dod-001: test file present in omnibase_core PR diff dod-002: 33 tests pass locally, 3 xfail pending OMN-10421

coderabbitai · 2026-05-01T16:22:50Z

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 3 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2078b0e8-8f65-45e4-a3c6-f6b5b40ec199

📥 Commits

Reviewing files that changed from the base of the PR and between 3a7a6a9 and 8df866a.

📒 Files selected for processing (6)

contracts/OMN-10423.yaml
drift/dod_receipts/OMN-10420/dod-001/command.yaml
drift/dod_receipts/OMN-10420/dod-002/command.yaml
drift/dod_receipts/OMN-10420/dod-003/command.yaml
drift/dod_receipts/OMN-10420/dod-004/command.yaml
drift/dod_receipts/OMN-10423/dod-002/command.yaml

📝 Walkthrough

Walkthrough

These changes add new contract specifications and associated DoD evidence receipts for tickets OMN-10420 and OMN-10423. OMN-10420 formalizes ticket-identity binding requirements for receipt_gate.py with four DoD checks including unit tests, pattern exports, and CLI flags. OMN-10423 introduces an integration test contract with evidence for test file presence and passing test counts.

Changes

Cohort / File(s)	Summary
Contract Specifications `contracts/OMN-10420.yaml`, `contracts/OMN-10423.yaml`	New YAML contract definitions specifying DoD checks and evidence requirements. OMN-10420 validates identity-binding failure cases, test regressions, exported patterns, and CLI flags with emergency bypass disabled. OMN-10423 verifies integration test file presence and test result counts (33 passed, 3 xfailed).
OMN-10420 Evidence Receipts `drift/dod_receipts/OMN-10420/dod-00[1-4]/command.yaml`	Four command-based evidence receipt files recording test run results. dod-001: Unit test validation (9 passing cases). dod-002: Multiple unit test files (68 passed). dod-003: Verification of exported patterns in module `__all__`. dod-004: CLI help output validation for required flags.
OMN-10423 Evidence Receipts `drift/dod_receipts/OMN-10423/dod-00[1-2]/command.yaml`	Two command-based evidence receipt files. dod-001: Integration test file presence check in PR diff. dod-002: Test result verification (33 passed, 3 xfailed) from pytest execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop, hop! New contracts spring to life,
Evidence receipts, no bugs or strife,
Tests are bound, patterns dance with glee,
Fifteen DoD checks, verified with spree!
Receipt gate triumphs, identity's key! 🎪

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'feat(OMN-10423): contract + receipts for cascade integration test' directly and accurately summarizes the main changes: adding contract and receipt files for OMN-10423 related to cascade integration testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch jonah/omn-10423-cascade-test-occ

_{Review rate limit: 0/5 reviews remaining, refill in 2 minutes and 3 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@drift/dod_receipts/OMN-10420/dod-001/command.yaml`:
- Around line 16-17: The committed receipts leak an absolute local path in the
working_dir YAML key; for each receipt (the command.yaml under dod-001, dod-002,
dod-003, dod-004 in the OMN-10420 set) remove or replace the working_dir value
with either omit the key entirely or set a sanitized repo-relative path (e.g.
project-root-relative) instead of the absolute /Users/... path; update each
command.yaml by deleting the working_dir entry or substituting a sanitized value
and commit the sanitized files.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95dd164f-4d11-46d9-b720-e0fc2bdb3aa5

📥 Commits

Reviewing files that changed from the base of the PR and between ea76b79 and 3a7a6a9.

📒 Files selected for processing (8)

contracts/OMN-10420.yaml
contracts/OMN-10423.yaml
drift/dod_receipts/OMN-10420/dod-001/command.yaml
drift/dod_receipts/OMN-10420/dod-002/command.yaml
drift/dod_receipts/OMN-10420/dod-003/command.yaml
drift/dod_receipts/OMN-10420/dod-004/command.yaml
drift/dod_receipts/OMN-10423/dod-001/command.yaml
drift/dod_receipts/OMN-10423/dod-002/command.yaml

…r 10940/10941/10949 - Add contracts for OMN-10936 (reviewdog-caller omniclaude), OMN-10942 (contract routing policy), OMN-10944 (dashboard projection API contract) - Update OMN-10949 contract to cover infra PR #1588 and market PR #622 in addition to market #616 - Fix contract_sha256 in OMN-10940 receipts (pr-1580, pr-1586) — contract was updated with pr-1586 evidence item, changing the hash - Add contract_sha256 to OMN-10941 pr-1587 receipt (was missing) - Update OMN-10949 pr-616 receipt contract_sha256 to reflect expanded contract - Add receipts: OMN-10936/pr-1582, OMN-10942/pr-621, OMN-10944/pr-620, OMN-10949/pr-1588, OMN-10949/pr-622

…and receipt bundle for 6 tickets (#999) * contract(OMN-10940,OMN-10941): add OCC contracts and receipts for infra PRs 1586 and 1587 - OMN-10940: add dod-omnibase-infra-pr-1586 evidence binding PR #1586 (E2E golden-chain task-delegated event test) to the OMN-10940 contract - OMN-10941: new contract + receipt for PR #1587 (max_tokens propagation regression tests) Both receipts are required for the receipt-gate Evidence-Source check on PRs 1586 and 1587. * contract: add OMN-10936/10942/10944 contracts + fix receipt hashes for 10940/10941/10949 - Add contracts for OMN-10936 (reviewdog-caller omniclaude), OMN-10942 (contract routing policy), OMN-10944 (dashboard projection API contract) - Update OMN-10949 contract to cover infra PR #1588 and market PR #622 in addition to market #616 - Fix contract_sha256 in OMN-10940 receipts (pr-1580, pr-1586) — contract was updated with pr-1586 evidence item, changing the hash - Add contract_sha256 to OMN-10941 pr-1587 receipt (was missing) - Update OMN-10949 pr-616 receipt contract_sha256 to reflect expanded contract - Add receipts: OMN-10936/pr-1582, OMN-10942/pr-621, OMN-10944/pr-620, OMN-10949/pr-1588, OMN-10949/pr-622 * contract(OMN-10949): add deploy evidence item + update receipt hashes - Add deploy-evidence-pricing-version dod_evidence item to satisfy deploy-gate (pricing_manifest_version is additive schema field, no runtime restart needed) - Update contract_sha256 in all OMN-10949 receipts (pr-616, pr-1588, pr-622) to reflect updated contract hash * contract: add OCC self-binding receipts (pr-999) + fix all contract_sha256 hashes - Add dod-occ-pr-999 evidence items to all 6 ticket contracts (OMN-10936/10940/10941/10942/10944/10949) - Create dod-occ-pr-999/command.yaml self-binding receipts for each ticket - Update all downstream receipt contract_sha256 fields to reflect updated contract hashes - Fixes OCC eligibility pr_ticket_mismatch failure (receipts now bind to OCC PR #999) * receipt(OMN-10949): add deploy-evidence-pricing-version receipt for deploy-gate * fix: add headRefName to probe_stdout in OMN-10942/OMN-10944 receipts (CR review) * ci(OMN-10940): suppress delegation_events migration name conflict The Migration Conflict Check on PR #999 flagged delegation_events as a NAME_CONFLICT between omnibase_infra/078_create_delegation_events.sql (Postgres projection, 22 cols, UUID PK) and omniclaude/001_create_delegation_tables.sql (SQLite hook-side capture, 15 cols, INTEGER PK). Different databases, different access patterns. The omnibase_infra side is the canonical projection consumed by HandlerProjectionDelegation from onex.evt.omniclaude.task-delegated.v1 (OMN-10526). The omniclaude side is the local hook-side store pinned to the projection contract (OMN-10604). Neither shares a Postgres instance with the other. Suppress the conflict using the existing schema_evolution reason — the same pattern already used for llm_call_metrics and savings_estimates, which have an identical infra-vs-omniclaude split. No code changes; this is a CI suppressions update only.

jonahgabriel added 3 commits May 1, 2026 11:19

fix(OMN-10420): tighten OCC receipt evidence checks

ea4212f

jonahgabriel enabled auto-merge May 1, 2026 16:22

fix(OMN-10423): pin OCC checks to core PR

3a7a6a9

coderabbitai Bot reviewed May 1, 2026

View reviewed changes

Comment thread contracts/OMN-10423.yaml Outdated

Comment thread drift/dod_receipts/OMN-10420/dod-001/command.yaml Outdated

jonahgabriel added 2 commits May 1, 2026 13:19

fix(OMN-10423): harden OCC receipt evidence

135f029

merge: update OMN-10423 OCC evidence with main

8df866a

jonahgabriel added this pull request to the merge queue May 1, 2026

Merged via the queue into main with commit 0d8e436 May 1, 2026
26 checks passed

jonahgabriel deleted the jonah/omn-10423-cascade-test-occ branch May 1, 2026 19:14

jonahgabriel mentioned this pull request May 2, 2026

test(OMN-10423): adversarial cascade integration test — receipt-gate proof-of-life OmniNode-ai/omnibase_core#1022

Merged

5 tasks done

jonahgabriel mentioned this pull request May 13, 2026

contract(OMN-10936,10940,10941,10942,10944,10949): add OCC contracts and receipt bundle for 6 tickets #999

Merged

jonahgabriel mentioned this pull request Jul 22, 2026

evidence(OMN-10855): bind omninode_infra merge queue PRs #4604

Merged

Navigation Menu

Repository navigation

feat(OMN-10423): contract + receipts for cascade integration test - #616

feat(OMN-10423): contract + receipts for cascade integration test#616
jonahgabriel merged 6 commits into
mainfrom
jonah/omn-10423-cascade-test-occ

jonahgabriel commented May 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 1, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonahgabriel commented May 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jonahgabriel commented May 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 1, 2026 •

edited

Loading