Repository navigation
feat(OMN-10872,OMN-10873): OCC contracts and dod receipts for DI Wave 2 - #1113
Merged
Merged
Conversation
…Wave 2 Contracts for HandlerNavigationHistoryReducer protocol injection seam (OMN-10872) and NodeOverseerBenchmarker harness injection seam (OMN-10873). Both are seam tickets with unit-test and PR-merge evidence. omnimarket PR: OmniNode-ai/omnimarket#693
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds/updates two DI-seam contract YAMLs (OMN-10872, OMN-10873) and corresponding drift DOD receipt command records verifying unit-test, deploy/no-restart, and PR evidence checks all PASS. ChangesDI Seam Contracts and Evidence Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-10872.yaml`:
- Line 26: The contract description in OMN-10872.yaml incorrectly states the PR
is "merged to main with CI green" while the DoD receipt at
drift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yaml records the PR
as "open with CI passing"; update the description string in OMN-10872.yaml to
accurately reflect the current state (e.g., "open with CI passing") OR wait to
merge the OCC PR and then update the receipt at
drift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yaml to mark the PR
as merged and adjust the description back to "merged to main with CI green".
In `@drift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yaml`:
- Around line 1-8: The receipt is missing three required cross-repo PR-binding
fields: add commit_sha containing the head commit SHA of omnimarket PR `#693` (use
the PR's headRefOid), add probe_command that runs gh pr view for the external PR
to fetch metadata (e.g., use gh pr view 693 --repo OmniNode-ai/omnimarket --json
state,headRefOid so you capture state and headRefOid), and add actual_output
with a short human-readable PASS summary that references the PR number and the
head commit SHA (e.g., "PASS: omnimarket PR `#693` at <commit_sha>"). Update
command.yaml to include these fields alongside the existing keys so the receipt
follows the PR-binding pattern.
In `@drift/dod_receipts/OMN-10872/dod-unit-tests-pass/command.yaml`:
- Around line 1-8: The receipt in command.yaml is missing the required
commit_sha for cross-repo evidence; update the YAML by adding a top-level
commit_sha field (a string) containing the head commit SHA of the omnimarket PR
that produced the test run (omnimarket PR `#693`) alongside the existing
status/ticket_id/evidence_id entries so the record can be traced back to that
exact commit for the HandlerNavigationHistoryReducer DI injection tests.
In `@drift/dod_receipts/OMN-10873/dod-omnimarket-pr-693/command.yaml`:
- Line 5: Update the description field in command.yaml so it accurately reflects
that this receipt documents the PR merge (not PR open); change the value of the
"description" key (currently "omnimarket PR `#693` open with CI passing") to a
merge-oriented message that references PR `#693` and merge evidence (e.g.,
"omnimarket PR `#693` merged with CI passing"), ensuring the receipt content
aligns with the PR-merge DoD artifact intent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7091649a-dd24-4546-934b-567ca872a64a
📒 Files selected for processing (6)
contracts/OMN-10872.yamlcontracts/OMN-10873.yamldrift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yamldrift/dod_receipts/OMN-10872/dod-unit-tests-pass/command.yamldrift/dod_receipts/OMN-10873/dod-omnimarket-pr-693/command.yamldrift/dod_receipts/OMN-10873/dod-unit-tests-pass/command.yaml
…t_sha, add repo fields
…pt schema Receipts previously used a custom flat schema with fields like evidence_id, description, repo, command, output, recorded_at which fail ModelDodReceipt Pydantic validation (15 errors per receipt). Rewrites all 6 receipts to use the canonical schema with schema_version, evidence_item_id, check_type, check_value, run_timestamp, runner, verifier, probe_command, probe_stdout. Updates commit_sha from stale 723e68ce to live omnimarket #693 head eed1dc53 (verified live via gh pr view) and propagates to contract grep patterns. Adds dod-occ-pr-1113 self-binding receipts for both tickets so receipt-gate pr_ticket_mismatch resolves.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-10872/dod-unit-tests-pass/command.yaml`:
- Around line 15-19: The receipt shows a provenance mismatch: the actual_output
string names "omnimarket" while working_dir points to "onex_change_control";
update one to match the other so traceability is correct—either change
actual_output to reference "onex_change_control" or set working_dir to the
omnimarket working tree, and ensure pr_number (693) and branch
("jonah/omn-10872-di-refactor-nav-history-benchmarker") still correspond to the
chosen repo context; modify the fields actual_output and/or working_dir in
command.yaml accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fe52105f-e881-41f0-8f0e-2935a5f7f670
📒 Files selected for processing (10)
contracts/OMN-10872.yamlcontracts/OMN-10873.yamldrift/dod_receipts/OMN-10872/dod-deploy/command.yamldrift/dod_receipts/OMN-10872/dod-occ-pr-1113/command.yamldrift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yamldrift/dod_receipts/OMN-10872/dod-unit-tests-pass/command.yamldrift/dod_receipts/OMN-10873/dod-deploy/command.yamldrift/dod_receipts/OMN-10873/dod-occ-pr-1113/command.yamldrift/dod_receipts/OMN-10873/dod-omnimarket-pr-693/command.yamldrift/dod_receipts/OMN-10873/dod-unit-tests-pass/command.yaml
✅ Files skipped from review due to trivial changes (7)
- drift/dod_receipts/OMN-10873/dod-deploy/command.yaml
- drift/dod_receipts/OMN-10872/dod-occ-pr-1113/command.yaml
- drift/dod_receipts/OMN-10873/dod-occ-pr-1113/command.yaml
- drift/dod_receipts/OMN-10873/dod-unit-tests-pass/command.yaml
- drift/dod_receipts/OMN-10872/dod-omnimarket-pr-693/command.yaml
- drift/dod_receipts/OMN-10873/dod-omnimarket-pr-693/command.yaml
- drift/dod_receipts/OMN-10872/dod-deploy/command.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- contracts/OMN-10872.yaml
- contracts/OMN-10873.yaml
jonahgabriel
enabled auto-merge (squash)
May 18, 2026 03:06
…receipt CodeRabbit flagged that actual_output claimed tests ran in omnimarket but working_dir pointed to onex_change_control. Added pr_repo field and clarified that OCC is the canonical evidence registry while execution happened in the omnimarket worktree.
Previous fix added pr_repo (rejected by ModelDodReceipt as extra field) and made working_dir a free-text string (schema requires absolute path). Restore schema compliance: working_dir back to absolute omnimarket worktree path, cross-repo provenance documented in actual_output instead.
jonahgabriel
added a commit
that referenced
this pull request
Jun 8, 2026
…urrent contract hash Appending the omnimarket A3 dod_evidence entries changed the OMN-12775 contract hash; every receipt under the ticket must pin the current hash or the Receipt Gate fails with contract_hash_mismatch. Re-pin all four receipts (omnidash #192, occ-evidence, omnimarket #1113 + tests) to sha256:980da6c1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence-Source: OCC#1113
Evidence-Ticket: OMN-10872
Evidence-Ticket: OMN-10873
Summary by CodeRabbit
Refactor
Chores