Skip to content

docs(OMN-10655): bind onboarding receipt to omnibase_infra PR 1522 - #794

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10655-bind-pr-1522-receipts
May 7, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10655-bind-pr-1522-receipts

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • pre-commit run --files contracts/OMN-10655.yaml drift/dod_receipts/OMN-10655/dod-pr-1522-head/command.yaml
  • uv run validate-yaml contracts/OMN-10655.yaml

Refs: OMN-10655

Summary by CodeRabbit

  • Tests
    • Extended verification coverage for the interactive onboarding policy through additional evidence validation.
    • Updated verification records and contract fingerprints to reflect current system state.

@coderabbitai

coderabbitai Bot commented May 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR extends ticket OMN-10655's verification coverage by adding two new dod_evidence checks to the contract: one binds the current omnibase_infra PR #1522 head OID via a gh pr view command, and another validates an OCC receipt command status and PR number. Two new receipt records capture the execution and results, with three existing receipt SHA-256 digests updated to reflect the contract changes.

Changes

OMN-10655 Evidence Verification Coverage

Layer / File(s) Summary
Contract Evidence Definitions
contracts/OMN-10655.yaml
New dod_evidence entries add checks for PR #1522 head OID binding and OCC receipt command validation (status: PASS, pr_number: 794).
Receipt Verification Records
drift/dod_receipts/OMN-10655/dod-pr-1522-head/command.yaml, drift/dod_receipts/OMN-10655/dod-occ-pr/command.yaml
Complete YAML verification records capture execution of gh pr view for PR #1522 binding and OCC receipt validation, both passing with metadata (timestamps, runner/verifier, commit SHA, contract hash).
Receipt Contract Hash Updates
drift/dod_receipts/OMN-10655/dod-interactive-policy-tests/command.yaml, drift/dod_receipts/OMN-10655/dod-onboarding-suite/command.yaml, drift/dod_receipts/OMN-10655/dod-policy-file-exists/command.yaml
The contract_sha256 fields are updated in three existing receipt files to reflect contract changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#760: Both PRs add/modify drift/dod_receipts command YAMLs that bind evidence to a specific omnibase_infra PR using gh pr view and pr_number checks following the same receipt-binding pattern.
  • OmniNode-ai/onex_change_control#337: Both PRs make analogous code-level changes to dod_evidence contract entries and add PASS command receipts under drift/dod_receipts.

Poem

🐰 A rabbit hops through verification's way,
New evidence checks bind the PR today,
SHA digests dance in receipt files true,
OMN-10655 now has proof through and through!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main objective of the pull request: binding onboarding receipts to omnibase_infra PR #1522, which aligns with the stated purpose of repairing Receipt Gate failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10655-bind-pr-1522-receipts

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 7, 2026 23:40
@jonahgabriel
jonahgabriel merged commit 63ed6d1 into main May 7, 2026
26 of 27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10655-bind-pr-1522-receipts branch May 7, 2026 23:43
jonahgabriel added a commit that referenced this pull request Aug 8, 2026
…lution

The earlier merge-conflict resolution rewrote the shared
"dod-occ-evidence-admissibility-validator" dod_evidence entry and its
receipt file, both of which were already merged to dev by OCC#6234
(PR #830's companion). That trips the OCC Append-Only Gate: a merged
dod_evidence entry/receipt must never be edited, only superseded via a
net-new record.

Per the established pattern for this exact shape (OMN-15637, PR #795
landing after PR #794's companion already merged the same shared
validator-item id): leave the merged "dod-occ-evidence-admissibility-
validator" entry and its receipt untouched, and add PR #831's evidence
as net-new dod_evidence items (dod-OmniNode-ai-omninode_infra-pr-831,
-831-ci, occ-self-bind-pr-6235) instead of duplicating the shared id.

Zero merged content edited or deleted; three net-new entries appended.
jonahgabriel added a commit that referenced this pull request Aug 8, 2026
…inode_infra#831 (#6235)

* evidence(OMN-15769): author OCC companion for OmniNode-ai/omninode_infra#831

OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head 4b103cc358600941a843f9b60da5813c06c8cb28.

* evidence(OMN-15769): self-bind OCC#6235 + rebind contract_sha256

* fix(OMN-15769): repair append-only violation from merge conflict resolution

The earlier merge-conflict resolution rewrote the shared
"dod-occ-evidence-admissibility-validator" dod_evidence entry and its
receipt file, both of which were already merged to dev by OCC#6234
(PR #830's companion). That trips the OCC Append-Only Gate: a merged
dod_evidence entry/receipt must never be edited, only superseded via a
net-new record.

Per the established pattern for this exact shape (OMN-15637, PR #795
landing after PR #794's companion already merged the same shared
validator-item id): leave the merged "dod-occ-evidence-admissibility-
validator" entry and its receipt untouched, and add PR #831's evidence
as net-new dod_evidence items (dod-OmniNode-ai-omninode_infra-pr-831,
-831-ci, occ-self-bind-pr-6235) instead of duplicating the shared id.

Zero merged content edited or deleted; three net-new entries appended.

---------

Co-authored-by: omnimarket-bot <bot@omninode.ai>
Co-authored-by: Jonah Gray <jonah@omninode.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant