Repository navigation
evidence(OMN-15637): append-only OCC companion for omninode_infra#795 head binding - #5894
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Appends two dod_evidence items and their receipts. Zero deletions, no merged receipt edited, no supersession record minted. - dod-omn15637-infra-pr-795-head-binding: asserts omninode_infra #795's headRefOid AND baseRefName together in one equality (e5a1929b7dc11dd7da8575d224286f04b3894dbb / dev). - occ-self-bind-pr-5894: asserts this companion's number AND head branch together. Different repo, different fields -> distinct from the item above by construction (OMN-15459 S1). This STRENGTHENS rather than supersedes the dod-OmniNode-ai-omninode_infra-pr-795 item merged by OCC#5889 (dd80026). That item's probes are `gh pr view 795 --json number,state` and `--json files` - the OMN-14443 vacuous class, which passes whenever the PR merely exists regardless of head, base, or the outcome claimed. Nothing in the merged evidence binds OMN-15637 to the tree #795 actually pins. Authored by session fable-drain-0801's OPUS repair lane, which did not implement #795 (Self-companion guard OMN-15334 / no-self-authored-evidence). OMN-15637
3aa7430 to
b4fee35
Compare
OMN-15637 — discriminating head binding for
omninode_infra#795Net-new, append-only evidence companion binding OMN-15637 to omninode_infra PR #795
(head
e5a1929b7dc11dd7da8575d224286f04b3894dbb, basedev).Three files, all add-only. 112 insertions, 0 deletions. No merged receipt edited, no supersession
record minted, no
.supersede.*.yamlin this diff.Scope changed mid-flight — read this first
This PR was opened as the replacement for the hard-red autobind companion OCC#5889. While it was
being authored, #5889 was hand-repaired to an append-only diff and merged as
dd8002664, and#795 went
CLEANon all four required contexts. So this PR is no longer unblocking anything —it is now a strictly additive upgrade of already-merged evidence, and it is kept for one reason:
dod-OmniNode-ai-omninode_infra-pr-795, as merged by #5889, checks:That is the OMN-14443 vacuous class: both pass whenever the PR merely exists, regardless of head
OID, base branch, or the outcome being claimed.
occ-self-bind-pr-5889and the earlierocc-self-bind-pr-5880carry the same shape. Nothing in the merged evidence ties OMN-15637 to thetree #795 actually pins — and #795 is the PR that moves the onex-dev runtime + migrate images from
omnibase_infrad42cbe70to72d27efa, 29 merged-but-undeployed commits, including theOMN-15621 strict boot-time wiring bijection restore.
This PR strengthens that merged item rather than superseding it — the OMN-15459 repair primitive
is a stronger net-new sibling, never a rewrite.
The two probes are discriminating, and distinct from each other
Head binding for the product PR (compound
headRefOid+baseRefName):Self-bind for this companion (compound
number+headRefName):A re-pushed head, a retargeted base, or a different PR each yield a mismatch. The two
check_valuestarget different repos and different fields, so the OMN-15459 S1 distinctness property holds by
construction, not by convention.
Both were run live before minting; each receipt's
probe_stdoutis the real captured output:These are binding items, not correctness claims. #795's substantive proof is its own verification
matrix, in that PR's body:
tests/k8s288 passed / 2 skipped,pre-commitgreen,kubectl kustomizerendering exactly one distinct digest across 10 image references, and both pinned digests
dual-read from the GHA push receipts (
30718901467,30718906707) and an independentaws ecr describe-imagesagainst the live registry.What #5889 did wrong (recorded here because it is a live producer bug, not a one-off)
Trigger is falsifiable: the regression fires on the 2nd autobind companion per ticket, never the
1st. OMN-15637 already had OCC#5880 merged 27 minutes earlier.
OCC Append-Only Gatedrift/dod_receipts/OMN-15637/dod-occ-evidence-admissibility-validator/command.yaml(M, 7+/7−)91420368934Supersession Binding Ratchet (OMN-15459)command.supersede.795.yamlrecords over three DISTINCT evidence items, all sharing one genericgh pr view 795 …replacement.check_value— S1 + S2 violated on all three91420369014/91420414597Both were cleared by hand-stripping the supersede files and reverting the merged-receipt edit before
#5889 merged; the vacuous-probe defect was not, which is what this PR addresses.
Authorship disclosure
Authored by session
fable-drain-0801's OPUS repair lane, which did not implement PR #795 —the implementer must not author their own companion (
feedback_no_self_authored_evidence), and theSelf-companion guard (OMN-15334)is satisfied.Gates
Full
pre-commithook chain ran clean in-worktree on commit — all Passed/Skipped, includingReceipt Honesty Gate (OMN-12791),Contract Substance Floor (OMN-14409),Receipt Hardening Gate (OMN-13060 / retro A-5 / OMN-15459),Evidence-Commit SHA Existence Gate (OMN-15111),Validate ticket contract YAML (OMN-8808),yamlfmt contamination ratchet (OMN-15479), andnormalization-symmetry.Rule 11a exception, stated: gates ran on this Mac rather than
.200. Reason — this is atwo-receipt YAML-only companion with no Python/test-suite gate path (the entire local gate surface is
the pre-commit hook chain, which completed in seconds and is re-run unconditionally by CI as
Pre-commit), and it was authored against a blocked critical-path PR. No heavy or contended gate runwas skipped or narrowed.
Contract bytes were stabilized before hashing (
yamlfmtreflows contract YAML on first commit, perthis repo's
CLAUDE.md): hooks were run to fixpoint, thencontract_sha256/contract_entry_sha256were computed withomnibase_core.validation.validator_receipt_gateagainstthe post-reflow bytes. Appending these items leaves every prior entry's
contract_entry_sha256untouched (OMN-13888 / OMN-14411 per-entry hash model), so all merged receipts on this ticket stay
valid.
Evidence-Source
Evidence-Source: this PR (in-repo OCC companion; OCC PRs validate contracts + receipts from their own
in-tree checkout, invariant I3)
Evidence-Ticket: OMN-15637
OMN-15637