Repository navigation
docs(OMN-10491): add projection cost receipts - #683
Merged
Merged
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR introduces a contract specification for ticket OMN-10491 (LLM cost projection consumer schema alignment) along with evidence receipts documenting successful completion of two required verification checks: a pytest test run and a post-merge deployment validation command execution. ChangesOMN-10491 Contract and Evidence Records
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 11 minutes and 31 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
contracts/OMN-10491.yaml (1)
45-49: ⚡ Quick winHarden
dod-deployreceipt verification with commit/exit-code pinning.
dod-deploycurrently checks a broad marker (deploy validation) but does not verifycommit_shaorexit_code. Tightening this makes the receipt provenance and execution result as strict asdod-001.Proposed diff
- check_type: "command" check_value: "grep -q '^status: PASS$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" && grep -q '^evidence_item_id: \"dod-deploy\"$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" && grep -q '^ticket_id: \"OMN-10491\"$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" + && grep -q '^commit_sha: \"b11e877af3babbfbf3a69957b390b9b285a992fb\"$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" + && grep -q '^exit_code: 0$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" && grep -q '^pr_number: 517$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" - && grep -q 'deploy validation' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\"" + && grep -q 'omnimarket.nodes.node_projection_llm_cost.consumer --help' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\""Based on learnings, cross-repo DoD evidence should be provenance-bound to the subject PR head commit.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@contracts/OMN-10491.yaml` around lines 45 - 49, The current check_value in contracts/OMN-10491.yaml only asserts broad markers (like "deploy validation") and existing fields; update the check_value to also assert exact commit and execution result by adding grep checks for '^commit_sha: "<PR_HEAD_COMMIT_SHA>"$' and '^exit_code: 0$' against the same \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\" file, ensuring the commit SHA is pinned to the subject PR head and exit_code is pinned to success while preserving the existing checks (status, evidence_item_id, ticket_id, pr_number and the deploy validation string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@contracts/OMN-10491.yaml`:
- Around line 45-49: The current check_value in contracts/OMN-10491.yaml only
asserts broad markers (like "deploy validation") and existing fields; update the
check_value to also assert exact commit and execution result by adding grep
checks for '^commit_sha: "<PR_HEAD_COMMIT_SHA>"$' and '^exit_code: 0$' against
the same
\"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10491/dod-deploy/command.yaml\"
file, ensuring the commit SHA is pinned to the subject PR head and exit_code is
pinned to success while preserving the existing checks (status,
evidence_item_id, ticket_id, pr_number and the deploy validation string).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 97392513-b143-4f3a-bfba-c4b5a054cd17
📒 Files selected for processing (3)
contracts/OMN-10491.yamldrift/dod_receipts/OMN-10491/dod-001/command.yamldrift/dod_receipts/OMN-10491/dod-deploy/command.yaml
jonahgabriel
enabled auto-merge
May 2, 2026 20:27
jonahgabriel
added this pull request to the merge queue
May 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 3, 2026
jonahgabriel
added this pull request to the merge queue
May 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 3, 2026
jonahgabriel
added this pull request to the merge queue
May 3, 2026
jonahgabriel
added a commit
that referenced
this pull request
May 17, 2026
…ceipts Replaces auto-generated dod-001..004 with verifiable evidence items: - dod-ci: omnimarket PR CI passes (36 passing checks at b4207ee8) - dod-tests: 31/31 TDD tests pass (14 escalation chain + 11 regression) - dod-deploy: compute-only deploy readiness smoke (ADVISORY, post-merge) Satisfies deploy-gate requirement for omnimarket PR #683 which adds tiered model escalation chain (local -> cheap_cloud -> mid_frontier).
jonahgabriel
added a commit
that referenced
this pull request
May 18, 2026
Adds dod-occ-pr-1099 so receipt-gate's pr_ticket_mismatch resolves. Existing receipts bind to omnimarket PR #683; validator requires at least one PASS receipt bound to this OCC PR's own number.
jonahgabriel
added a commit
that referenced
this pull request
May 18, 2026
…#1099) * evidence(OMN-10767): add contract and dod receipts for interactive onboarding executor All 8 omnibase_infra PRs (#1546-#1559) merged. 277 tests pass. * fix(OMN-10767): replace local-path pytest check with portable commit-existence check * evidence(OMN-10767): add dod receipts for interactive onboarding executor PRs Receipts for all 4 dod_evidence checks: PRs 1559/1556/1555 MERGED + commit 977c4c7c. * evidence(OMN-10767): add occ PR receipt + dod-occ-pr-1095 entry to bind receipt gate Receipt gate requires a receipt citing PR #1095 (the OCC evidence PR itself). * fix(OMN-10767): use receipt-file check for dod-occ-pr-1095 (avoids OPEN-state circular dep) * chore(OMN-8537): add deploy dod_evidence to escalation chain contract Adds dod-005 with docker exec import smoke check to satisfy the deploy-gate requirement for omnimarket PR #683 (compute-only node change, no runtime restart required). * evidence(OMN-8537): add contract with deploy dod_evidence and PASS receipts Replaces auto-generated dod-001..004 with verifiable evidence items: - dod-ci: omnimarket PR CI passes (36 passing checks at b4207ee8) - dod-tests: 31/31 TDD tests pass (14 escalation chain + 11 regression) - dod-deploy: compute-only deploy readiness smoke (ADVISORY, post-merge) Satisfies deploy-gate requirement for omnimarket PR #683 which adds tiered model escalation chain (local -> cheap_cloud -> mid_frontier). * fix(OMN-8537): use file_exists check_type in dod_evidence to match CI runner capability grep check_type only searches .py files; file_exists glob correctly verifies receipt YAML artifacts exist at canonical drift/dod_receipts paths. * fix(OMN-8537): use command check_type with test -f for receipt-gate compatibility receipt_gate_cli looks up receipts at drift/dod_receipts/<ticket>/<id>/<check_type>.yaml. Receipts are named command.yaml so contract must use check_type: command. Using test -f commands that the CI runner can execute without external deps. * fix(OMN-8537): update receipts with contract_sha256 and PASS status Add contract_sha256 field (required post 2026-04-30 cutoff). Upgrade dod-deploy from ADVISORY to PASS — escalation chain is compute-only, no runtime restart needed, module imports confirmed in dev environment. * evidence(OMN-8537): add self-binding receipt for OCC PR #1099 Adds dod-occ-pr-1099 so receipt-gate's pr_ticket_mismatch resolves. Existing receipts bind to omnimarket PR #683; validator requires at least one PASS receipt bound to this OCC PR's own number. * fix(OMN-8537): update contract_sha256 in receipts to post-addition hash Adding dod-occ-pr-1099 to the contract changed its sha256, breaking the hash binding in existing receipts (contract_hash_mismatch). Update all three receipts to reference the current contract sha256. * fix(OMN-8537): reconcile OMN-10767 contract claims + refresh PR 1095 receipt CodeRabbit flagged two consistency issues on the OMN-10767 bundle in this PR: - evidence_requirements claimed "All 8 child PRs" but summary lists 14 PRs (1546-1559) and dod_evidence verifies 3 critical-path PRs + merge-commit probe. Rewrote requirement to match what is actually verified. - dod-occ-pr-1095 receipt captured probe_stdout when PR 1095 was OPEN (17:35Z); merged 8min later (17:43Z). Refreshed receipt with mergedAt. * chore(OMN-8537): retrigger CI to clear stale check-run rollup Compute Smart Test Selection saw "no merge base" (shallow-clone artifact); CR Thread Check failed on stale aggregation despite all threads resolved. Empty commit forces fresh check-run set on new HEAD. * evidence(OMN-8537): fix deploy receipt probe literal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Evidence-Ticket: OMN-10491
Summary by CodeRabbit