Skip to content

fix(OMN-9613): require command receipts - #517

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-9613-command-receipt-checks
Apr 29, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-9613-command-receipt-checks

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • changes OMN-9613 DoD checks from weak file_exists aliases to command checks over the canonical command receipt artifacts
  • removes the ADVISORY file_exists fallback receipts so downstream Receipt Gate evaluates independent PASS command evidence
  • avoids the circular contract(OMN-10670): bind onex-prod manifest PR #960 CI rerun in OCC Contract Compliance by validating the stored command receipt metadata instead of the currently blocked downstream PR state

Verification

  • env -u PYTHONPATH uv run python scripts/ci/run_contract_compliance_check.py --pr 517 --repo OmniNode-ai/onex_change_control --contracts-dir contracts
  • env -u PYTHONPATH uv run pytest tests/unit/test_pol_omn_9795.py tests/test_validate_yaml_cli.py tests/test_dod_evidence_schema.py tests/unit/scripts/test_check_dod_compliance.py -q
  • env -u PYTHONPATH uv run python -m omnibase_core.validation.receipt_gate_cli --pr-title <core contract(OMN-10670): bind onex-prod manifest PR #960 title> --pr-body <core contract(OMN-10670): bind onex-prod manifest PR #960 body> --contracts-dir /contracts --receipts-dir /drift/dod_receipts

@coderabbitai

coderabbitai Bot commented Apr 29, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Evidence verification for definition-of-done entries dod-001 and dod-002 migrates from file existence checks to direct command execution, with legacy receipt files removed.

Changes

Cohort / File(s) Summary
Evidence Configuration
contracts/OMN-9613.yaml
Converts check_type from file_exists to command for dod-001 (pytest unit test execution) and dod-002 (GitHub PR checks status), replacing file path verification with direct command invocation.
Legacy Receipt Artifacts
drift/dod_receipts/OMN-9613/dod-{001,002}/file_exists.yaml
Deleted legacy file_exists receipt files that captured file existence probe outcomes and metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 From file checks to commands swift,
Legacy receipts drift away with a shift,
DoD evidence runs with purpose true,
Command execution proves what tests do! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(OMN-9613): require command receipts' accurately describes the main change: replacing file_exists checks with command receipt checks as the primary DoD evidence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9613-command-receipt-checks

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge April 29, 2026 00:19
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-9613-command-receipt-checks branch from 76f151c to 7a24552 Compare April 29, 2026 00:22
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit c3ced05 Apr 29, 2026
25 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9613-command-receipt-checks branch April 29, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant