Skip to content

docs(OMN-10478): refresh ab compare receipt evidence - #667

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10478-occ-receipt-refresh
May 2, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10478-occ-receipt-refresh

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes OMN-10478

Summary

Verification

  • uv run validate-yaml contracts/OMN-10478.yaml
  • ModelDodReceipt validation passed for dod-001 through dod-003
  • local OCC merge eligibility passed for omnimarket#514 and this OCC evidence PR

Summary by CodeRabbit

  • Chores
    • Updated internal testing infrastructure and contract documentation to reflect refinements in system behavior specifications and test execution metadata.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 232d1375-6f8a-4ebb-96e9-bb0f23c60320

📥 Commits

Reviewing files that changed from the base of the PR and between 30fb542 and 17432e9.

📒 Files selected for processing (5)
  • contracts/OMN-10478.yaml
  • drift/dod_receipts/OMN-10478/dod-001/command.yaml
  • drift/dod_receipts/OMN-10478/dod-002/command.yaml
  • drift/dod_receipts/OMN-10478/dod-003/command.yaml
  • drift/dod_receipts/OMN-10478/dod-004/command.yaml
📝 Walkthrough

Walkthrough

Updated ticket OMN-10478 description to document the A/B compare orchestrator's model registry resolution, filtering, and effect-node dispatch behavior. Supporting test evidence receipts were refreshed with latest run metadata and validation results.

Changes

Ticket Specification & Evidence Update

Layer / File(s) Summary
Ticket Description
contracts/OMN-10478.yaml
Specification updated to clarify orchestrator resolves model registry entries, skips models missing required keys/endpoints, dispatches inference via effect node, and returns sorted results with costs and token counts.
Test Evidence Receipts
drift/dod_receipts/OMN-10478/dod-*/command.yaml
Run metadata (run_timestamp, commit_sha, pr_number) and validation outputs refreshed across three evidence records to reflect latest test execution (PR 514, updated test counts and node check results).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A ticket updated with clarity bright,
The orchestrator now dances just right,
Registry checked, bad models dismissed,
Effects dispatched—none were missed!
Evidence logged, receipts all aligned,
A tidy update, documentation refined! 📋✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: refreshing receipt evidence files for OMN-10478, which matches the actual file updates in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10478-occ-receipt-refresh

Review rate limit: 0/5 reviews remaining, refill in 37 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge May 2, 2026 13:29
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request May 2, 2026
@jonahgabriel
jonahgabriel enabled auto-merge May 2, 2026 14:41
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10478-occ-receipt-refresh branch from ed3198b to e3c6385 Compare May 2, 2026 15:29
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit ff60a1e May 2, 2026
26 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10478-occ-receipt-refresh branch May 2, 2026 16:39
jonahgabriel added a commit that referenced this pull request May 16, 2026
Central contract and PASS receipts for omnimarket PR #667.
jonahgabriel added a commit that referenced this pull request May 23, 2026
* evidence(OMN-6678): bind OCC receipts for May 22 merge sweep

Consolidated central OCC contracts + PR-bound DoD receipts unblocking the
verify/verify receipt-gate for 11 in-flight PRs across three repos.

omniintelligence: OMN-6678/#667, OMN-6660/#666, OMN-11621/#665,
OMN-11551/#664, OMN-11554/#663, OMN-11561/#662, OMN-11565/#661,
OMN-11568/#660.
omnibase_compat: OMN-11618/#103, OMN-11579/#102.
onex_change_control: OMN-11616/#1380.

Each ticket carries a PR-bound PASS receipt plus an OCC self-binding receipt;
contract_sha256 computed post-yamlfmt so hash binding holds in CI.

Evidence-Source: OCC#9999
Evidence-Ticket: OMN-6678
Evidence-Ticket: OMN-6660
Evidence-Ticket: OMN-11621
Evidence-Ticket: OMN-11551
Evidence-Ticket: OMN-11554
Evidence-Ticket: OMN-11561
Evidence-Ticket: OMN-11565
Evidence-Ticket: OMN-11568
Evidence-Ticket: OMN-11618
Evidence-Ticket: OMN-11579
Evidence-Ticket: OMN-11616

* evidence(OMN-6678): pin OCC self-binding receipts to PR #1384

Two-pass finalization: replace placeholder OCC PR number 9999 with the real
consolidated PR #1384 across all self-binding receipts and contract
dod_evidence entries. Removes the stale dod-occ-pr-9999 entry left in the
OMN-11621 contract and restamps every OMN-11621 receipt contract_sha256 to the
post-edit, post-yamlfmt contract hash. Compat self-binding receipts updated to
pr_number 1384.

Evidence-Source: OCC#1384
Evidence-Ticket: OMN-6678
Evidence-Ticket: OMN-6660
Evidence-Ticket: OMN-11621
Evidence-Ticket: OMN-11551
Evidence-Ticket: OMN-11554
Evidence-Ticket: OMN-11561
Evidence-Ticket: OMN-11565
Evidence-Ticket: OMN-11568
Evidence-Ticket: OMN-11618
Evidence-Ticket: OMN-11579
Evidence-Ticket: OMN-11616

* chore(OMN-6678): re-trigger CI with OCC#1384 body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant