Skip to content

ci(OMN-10445): standardize OCC security scan runner routing - #665

Merged
jonahgabriel merged 6 commits into
mainfrom
jonah/omn-10445-occ-pr515-receipt
May 2, 2026
Merged

jonahgabriel merged 6 commits into
mainfrom
jonah/omn-10445-occ-pr515-receipt

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Ticket: OMN-10445

Summary

  • standardize the OCC self-scan CodeQL job onto the centralized runner selector contract
  • preserve the protected required check context CodeQL / CodeQL Analysis (python) while avoiding one-off hardcoded runner labels
  • keep action versioning aligned with the rest of the OCC workflow estate instead of pinning local SHAs in this PR

Verification

  • actionlint .github/workflows/security-scan.yml .github/workflows/codeql-reusable.yml
  • grep guard confirmed no bare ubuntu or self-hosted runner labels in the touched CodeQL workflows
  • pre-commit hooks passed during commit

Summary by CodeRabbit

  • Chores
    • Updated security scanning workflow to perform CodeQL analysis inline using updated GitHub Actions, with explicit runner selection and improved analysis configuration; workflow job renamed for clearer Python-focused CodeQL reporting.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Replaces the reusable CodeQL workflow call in .github/workflows/security-scan.yml with an inline jobs.codeql definition that uses actions/checkout@v6 and github/codeql-action/{init,autobuild,analyze}@v4, sets languages: python and queries: security-and-quality, and adjusts name and runs-on expression; job permissions unchanged.

Changes

CodeQL Workflow Inline Migration

Layer / File(s) Summary
Job metadata / Runner selection
.github/workflows/security-scan.yml
jobs.codeql.name changed to CodeQL / CodeQL Analysis (python) and runs-on now uses a conditional expression selecting from vars.OMNI_*_RUNS_ON_JSON based on github.event_name.
Core Steps: checkout & init
.github/workflows/security-scan.yml
Replaced reusable workflow with explicit steps: actions/checkout@v6, github/codeql-action/init@v4 with languages: python and queries: security-and-quality.
Core Steps: build & analyze
.github/workflows/security-scan.yml
Added github/codeql-action/autobuild@v4 and github/codeql-action/analyze@v4 with category: /language:python.
Permissions / continuity
.github/workflows/security-scan.yml
Job-level permissions (actions: read, contents: read, security-events: write) retained from previous configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped through YAML, neat and spry,
Swapped a reuse for steps nearby.
Checkout, init, build, then scan,
Python queries run by hand.
A tiny change, a tidy sky.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'ci(OMN-10445): standardize OCC security scan runner routing' directly relates to the main change of converting the CodeQL job from a reusable workflow to inline steps with explicit runner routing based on environment variables.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10445-occ-pr515-receipt

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge May 2, 2026 12:53
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10445-occ-pr515-receipt branch from 0d5bb07 to f0b7423 Compare May 2, 2026 12:58
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request May 2, 2026
@jonahgabriel
jonahgabriel enabled auto-merge May 2, 2026 13:22
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request May 2, 2026
@jonahgabriel
jonahgabriel enabled auto-merge May 2, 2026 14:02
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@github-actions
github-actions Bot enabled auto-merge May 2, 2026 14:22
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request May 2, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request May 2, 2026
@github-actions
github-actions Bot enabled auto-merge May 2, 2026 15:09
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10445-occ-pr515-receipt branch from ea10d51 to a58a45a Compare May 2, 2026 15:30

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/security-scan.yml:
- Around line 37-49: The workflow currently uses mutable tags for actions
(actions/checkout@v6 and github/codeql-action/init@v4,
github/codeql-action/autobuild@v4, github/codeql-action/analyze@v4); replace
each of those uses: entries with the corresponding immutable full commit SHA for
the specific release (e.g., actions/checkout@<full-sha>,
github/codeql-action/init@<full-sha>, github/codeql-action/autobuild@<full-sha>,
github/codeql-action/analyze@<full-sha>) by looking up the commit SHAs from the
actions' canonical GitHub repos/tags and update all four occurrences so the
workflow pins to exact commits rather than major-version tags.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7e683ac-df66-41f5-95c2-e249abc9185c

📥 Commits

Reviewing files that changed from the base of the PR and between a985a45 and 76449c6.

📒 Files selected for processing (1)
  • .github/workflows/security-scan.yml

Comment thread .github/workflows/security-scan.yml
@jonahgabriel jonahgabriel changed the title chore(OMN-10445): bind report poster receipt to PR 515 ci(OMN-10445): standardize OCC security scan runner routing May 2, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit 86df1c5 May 2, 2026
29 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10445-occ-pr515-receipt branch May 2, 2026 17:12
jonahgabriel added a commit that referenced this pull request May 2, 2026
* ci(OMN-10445): self-scan local reusable codeql

* ci(OMN-10445): run OCC codeql on selector runners

* ci(OMN-10445): preserve CodeQL required check name

* ci(OMN-10445): match protected CodeQL context

* ci(OMN-10445): pin security scan actions

* ci(OMN-10445): keep security scan actions standardized
jonahgabriel added a commit that referenced this pull request May 23, 2026
* evidence(OMN-6678): bind OCC receipts for May 22 merge sweep

Consolidated central OCC contracts + PR-bound DoD receipts unblocking the
verify/verify receipt-gate for 11 in-flight PRs across three repos.

omniintelligence: OMN-6678/#667, OMN-6660/#666, OMN-11621/#665,
OMN-11551/#664, OMN-11554/#663, OMN-11561/#662, OMN-11565/#661,
OMN-11568/#660.
omnibase_compat: OMN-11618/#103, OMN-11579/#102.
onex_change_control: OMN-11616/#1380.

Each ticket carries a PR-bound PASS receipt plus an OCC self-binding receipt;
contract_sha256 computed post-yamlfmt so hash binding holds in CI.

Evidence-Source: OCC#9999
Evidence-Ticket: OMN-6678
Evidence-Ticket: OMN-6660
Evidence-Ticket: OMN-11621
Evidence-Ticket: OMN-11551
Evidence-Ticket: OMN-11554
Evidence-Ticket: OMN-11561
Evidence-Ticket: OMN-11565
Evidence-Ticket: OMN-11568
Evidence-Ticket: OMN-11618
Evidence-Ticket: OMN-11579
Evidence-Ticket: OMN-11616

* evidence(OMN-6678): pin OCC self-binding receipts to PR #1384

Two-pass finalization: replace placeholder OCC PR number 9999 with the real
consolidated PR #1384 across all self-binding receipts and contract
dod_evidence entries. Removes the stale dod-occ-pr-9999 entry left in the
OMN-11621 contract and restamps every OMN-11621 receipt contract_sha256 to the
post-edit, post-yamlfmt contract hash. Compat self-binding receipts updated to
pr_number 1384.

Evidence-Source: OCC#1384
Evidence-Ticket: OMN-6678
Evidence-Ticket: OMN-6660
Evidence-Ticket: OMN-11621
Evidence-Ticket: OMN-11551
Evidence-Ticket: OMN-11554
Evidence-Ticket: OMN-11561
Evidence-Ticket: OMN-11565
Evidence-Ticket: OMN-11568
Evidence-Ticket: OMN-11618
Evidence-Ticket: OMN-11579
Evidence-Ticket: OMN-11616

* chore(OMN-6678): re-trigger CI with OCC#1384 body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant