Repository navigation
fix(tests): skip instead of error when OMNI_HOME unavailable in cross-repo fixture - #103
Merged
Merged
Conversation
…-repo fixture The omni_home fixture raised RuntimeError in CI when OMNI_HOME was not set. Changed to pytest.skip() so tests are gracefully skipped on runners that don't have omni_home available (GitHub Actions). Fixes CI test error "Cannot locate omni_home" which caused all cross-repo tests to ERROR.
jonahgabriel
enabled auto-merge
March 24, 2026 18:08
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
jonahgabriel
added this pull request to the merge queue
Mar 24, 2026
This was referenced May 22, 2026
jonahgabriel
added a commit
that referenced
this pull request
May 23, 2026
* evidence(OMN-6678): bind OCC receipts for May 22 merge sweep Consolidated central OCC contracts + PR-bound DoD receipts unblocking the verify/verify receipt-gate for 11 in-flight PRs across three repos. omniintelligence: OMN-6678/#667, OMN-6660/#666, OMN-11621/#665, OMN-11551/#664, OMN-11554/#663, OMN-11561/#662, OMN-11565/#661, OMN-11568/#660. omnibase_compat: OMN-11618/#103, OMN-11579/#102. onex_change_control: OMN-11616/#1380. Each ticket carries a PR-bound PASS receipt plus an OCC self-binding receipt; contract_sha256 computed post-yamlfmt so hash binding holds in CI. Evidence-Source: OCC#9999 Evidence-Ticket: OMN-6678 Evidence-Ticket: OMN-6660 Evidence-Ticket: OMN-11621 Evidence-Ticket: OMN-11551 Evidence-Ticket: OMN-11554 Evidence-Ticket: OMN-11561 Evidence-Ticket: OMN-11565 Evidence-Ticket: OMN-11568 Evidence-Ticket: OMN-11618 Evidence-Ticket: OMN-11579 Evidence-Ticket: OMN-11616 * evidence(OMN-6678): pin OCC self-binding receipts to PR #1384 Two-pass finalization: replace placeholder OCC PR number 9999 with the real consolidated PR #1384 across all self-binding receipts and contract dod_evidence entries. Removes the stale dod-occ-pr-9999 entry left in the OMN-11621 contract and restamps every OMN-11621 receipt contract_sha256 to the post-edit, post-yamlfmt contract hash. Compat self-binding receipts updated to pr_number 1384. Evidence-Source: OCC#1384 Evidence-Ticket: OMN-6678 Evidence-Ticket: OMN-6660 Evidence-Ticket: OMN-11621 Evidence-Ticket: OMN-11551 Evidence-Ticket: OMN-11554 Evidence-Ticket: OMN-11561 Evidence-Ticket: OMN-11565 Evidence-Ticket: OMN-11568 Evidence-Ticket: OMN-11618 Evidence-Ticket: OMN-11579 Evidence-Ticket: OMN-11616 * chore(OMN-6678): re-trigger CI with OCC#1384 body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omni_homefixture intests/integration/cross_repo/conftest.pyraisedRuntimeErrorwhenOMNI_HOMEwas not set, causing all tests using it to ERROR (exit code 1) on CIraise RuntimeError(msg)topytest.skip(msg)so tests are gracefully skipped on GitHub Actions runners whereomni_homeis unavailableTest plan
omni_home-dependent tests)test_boundary_manifest_is_not_emptyandtest_all_boundary_topics_have_valid_patternstill run (they don't useomni_home)Summary by CodeRabbit