Skip to content

fix(OMN-9893): migrate OMN-9632 receipt evidence to command - #443

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9632-receipt-command
Apr 27, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9632-receipt-command

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Migrates OMN-9632 DoD evidence from weak file_exists evidence to a command receipt so hardened Receipt Gate accepts the central OCC evidence for omnibase_infra#1410.

Verification

  • uv run validate-yaml contracts/OMN-9632.yaml
  • uv run python scripts/lint_contract_check_values.py contracts/OMN-9632.yaml
  • pre-commit run --files contracts/OMN-9632.yaml drift/dod_receipts/OMN-9632/dod-001/command.yaml
  • Local receipt gate replay from omnibase_core passed for PR title feat(OMN-9632): scaffold remote agent invoke effect and body Closes OMN-9632 using this worktree contracts and receipts.

Downstream

After merge, rerun Receipt Gate on OmniNode-ai/omnibase_infra#1410.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced contract verification to validate multiple critical files instead of a single file check.

@github-actions
github-actions Bot enabled auto-merge April 27, 2026 11:39
@coderabbitai

coderabbitai Bot commented Apr 27, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request modifies the DOD verification mechanism for contract OMN-9632, replacing a single file existence check with a command-based validation that verifies the presence of the contract YAML file and two specific test files. A new receipt document records the verification results with metadata and execution details.

Changes

Cohort / File(s) Summary
Contract Definition Update
contracts/OMN-9632.yaml
Replaces file_exists evidence check with command-based verification using test -f conditions to assert existence of contract YAML and two targeted test files combined with && logic.
DOD Receipt Documentation
drift/dod_receipts/OMN-9632/dod-001/command.yaml
New receipt document recording command verification results, including schema version, timestamps, commit SHA, shell predicate details, expected file paths, PASS status with exit code 0, and associated PR metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through contract lands so bright,
Where evidence now flows with triple-file delight,
From simple checks to commands refined with care,
Three artifacts dance—the proof floats through the air! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'fix(OMN-9893): migrate OMN-9632 receipt evidence to command' contains a mismatch: it references ticket OMN-9893 but all changes relate to OMN-9632 (the contract file, receipt directory, and PR objectives). Correct the ticket reference in the title from OMN-9893 to OMN-9632 to align with the actual changes, such as 'fix(OMN-9632): migrate receipt evidence to command'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9632-receipt-command

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel jonahgabriel changed the title fix(OMN-9632): migrate receipt evidence to command fix(OMN-9893): migrate OMN-9632 receipt evidence to command Apr 27, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 669a8c4 Apr 27, 2026
24 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9632-receipt-command branch April 27, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant