Repository navigation
feat(OMN-10211): add ticket contract for substrate_gates scaffold - #493
Conversation
Adds contract for Task 1 of OMN-10210 (Substrate Adoption Phase 1). OMN-10211 scaffolds BaseGateCheck, GateViolation, has_allow_annotation, and main_for_gate in omnibase_core — the shared AST-check infrastructure for all 8 substrate enforcement gates.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA new contract YAML file ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contracts/OMN-10211.yaml`:
- Around line 34-38: The check currently only searches for BaseGateCheck but the
description promises both GateViolation and BaseGateCheck; update the contract
checks to verify both symbols by either changing the existing check_value to
look for both (e.g., use an OR regex matching GateViolation and BaseGateCheck)
or add a second check entry that greps for GateViolation so both GateViolation
and BaseGateCheck are validated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
…tes scaffold Adds the 5 ModelDodReceipt files Receipt-Gate requires for OMN-10211's contract (PR #493): - dod-001/command.yaml: substrate_gates files in PR 958 diff (PASS) - dod-002/command.yaml: BaseGateCheck + GateViolation exports (PASS) - dod-003/command.yaml: 18 unit tests in PR 958 diff (PASS) - dod-004/command.yaml: deploy-verified — Code Quality PASS, substrate_gates is a pre-commit CLI tool not a runtime service, no Docker deploy required (PASS) - dod-005/command.yaml: PR 958 OPEN against main with acceptance criteria met (PASS) Each receipt was generated by running its contract's check_value command against omnibase_core PR #958 head (commit 12c1fa74). All commands exited 0 with confirming output captured in probe_stdout / actual_output. Unblocks the verify / Receipt-Gate failure on omnibase_core PR #958. The PR's deploy-gate also re-passed in run 25068494069 once OMN-10211's contract landed (PR #493) — only Receipt-Gate was waiting on these receipt files. Part of epic OMN-10210 — Substrate Adoption Phase 1.
* feat(OMN-10420): contract + receipts for ticket-identity binding Pairs with omnibase_core PR implementing I3 invariant: OCC evidence must provably belong to the same ticket as the code PR. Receipts verify: - dod-001: 9 identity-binding tests pass (5 required plan cases) - dod-002: 68 existing receipt_gate tests pass (no regressions) - dod-003: EVIDENCE_SOURCE/TICKET_PATTERN exported in __all__ - dod-004: CLI accepts --evidence-ticket and --branch-name flags * fix(OMN-10420): tighten OCC receipt evidence checks * docs(OMN-10457): receipt evidence for YC demo epic PRs Adds ModelTicketContract YAML + DoD receipts for three omnimarket PRs failing the receipt gate: OMN-10461 (Projection Query API Server, OmniNode-ai#490), OMN-10460 (Cost Event Publication Daemon, OmniNode-ai#491), and OMN-10465 (Build Loop + Merge Sweep as bus-driven nodes, OmniNode-ai#493). * docs(OMN-10457): add OCC receipt gate evidence
Summary
contracts/OMN-10211.yaml— ticket contract for Task 1 of OMN-10210 (Substrate Adoption Phase 1)substrate_gatespackage in omnibase_core:BaseGateCheck,GateViolation,has_allow_annotation,main_for_gateTicket
OMN-10211 (epic OMN-10210)
Related
omnibase_core PR: OmniNode-ai/omnibase_core#958
Summary by CodeRabbit