Skip to content

chore(receipts): add OMN-9837 migration receipt - #557

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9837-add-receipt
Apr 30, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9837-add-receipt

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Updates the OMN-9837 central contract proof command to cover all omnibase_core root ticket contracts currently centralized.
  • Adds the missing PASS receipt for OMN-9837 dod-001 so downstream Receipt Gate can pass.

Verification

  • uv run validate-yaml contracts/OMN-9837.yaml
  • uv run python - <<'PY' ... ModelDodReceipt.model_validate(...)
  • for f in OMN-9537 OMN-9572 OMN-9574 OMN-9592 OMN-9601 OMN-9623 OMN-9624 OMN-9637 OMN-10211 OMN-10212 OMN-10213 OMN-10215 OMN-10217 OMN-10219 OMN-10244; do test -f contracts/.yaml; done

Part of OMN-9837.

Summary by CodeRabbit

  • Chores
    • Expanded contract verification requirements to include additional ticket identifiers
    • Added verification receipt documentation for contract validation processes

@github-actions
github-actions Bot enabled auto-merge April 30, 2026 12:50
@coderabbitai

coderabbitai Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 50 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 116e8016-a618-4825-9094-a94148044c4f

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe7e97 and 9c088ef.

📒 Files selected for processing (2)
  • contracts/OMN-9837.yaml
  • drift/dod_receipts/OMN-9837/dod-001/command.yaml
📝 Walkthrough

Walkthrough

This PR expands evidence requirements for ticket OMN-9837 to verify an enlarged set of omnibase_core contract files instead of only seven specific IDs. A command-type receipt is introduced to validate the presence of these contract YAML files through a shell-based existence check.

Changes

Cohort / File(s) Summary
Contract Evidence Requirements
contracts/OMN-9837.yaml
Evidence requirements updated to include expanded ticket ID set (adding OMN-9572 and OMN-102xx/OMN-10244 variants), with descriptions broadened from "seven" to "all migrated" omnibase_core contracts. Check logic remains a directory existence test for contract files.
DoD Receipt Validation
drift/dod_receipts/OMN-9837/dod-001/command.yaml
New command-type receipt introduced to validate presence of expanded contract set. Receipt captures shell loop execution, stdout listing all migrated contracts, execution metadata (timestamp, commit SHA, runner), and a PASS status with exit code 0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Contracts scattered, now we verify with care,
Evidence receipts floating through the air,
All migrations checked from left to right,
Command receipts shining—everything's tight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a migration receipt for OMN-9837, which aligns with both the PR description and the file changes (adding a new receipt file and updating contract verification).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9837-add-receipt

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Review rate limit: 0/5 reviews remaining, refill in 2 minutes and 50 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@contracts/OMN-9837.yaml`:
- Around line 12-13: The shell loop string `for f in OMN-9537 OMN-9572 ...; do
test -f contracts/$f.yaml; done` can return 0 even if some iterations fail;
update the loop to fail fast by making each test enforce exit on failure (e.g.
`for f in ...; do test -f contracts/$f.yaml || { echo "missing $f"; exit 1; };
done`) or enable strict mode before the loop (`set -euo pipefail`) so any
missing contract file causes a non-zero exit; apply the same change to the other
occurrence of this loop (the similar `for` command around lines 27-29).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb463821-8d43-4edf-ac93-513c69d706dd

📥 Commits

Reviewing files that changed from the base of the PR and between e19014a and 9fe7e97.

📒 Files selected for processing (2)
  • contracts/OMN-9837.yaml
  • drift/dod_receipts/OMN-9837/dod-001/command.yaml

Comment thread contracts/OMN-9837.yaml Outdated
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit c4afb4a Apr 30, 2026
24 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9837-add-receipt branch April 30, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant