Skip to content

evidence: add OCC receipts for OMN-13530/13531/13532 - #2963

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-13530-13532-occ-evidence
Jun 23, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-13530-13532-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Evidence-Source: 02fde8d
Evidence-Ticket: OMN-13530

Summary

Verification

  • uv run validate-yaml contracts/OMN-13530.yaml contracts/OMN-13531.yaml contracts/OMN-13532.yaml contracts/OMN-592.yaml
  • uv run pre-commit run --files

Summary by CodeRabbit

  • Chores
    • Introduced additional pre-merge enforcement gates to prevent routing regressions, including cases where required operation-matching fields are missing.
    • Added stronger validation coverage for skill-to-node mapping consistency and CLI delegation’s live-bus behavior, with no live runtime/deploy impact required.
    • Disabled emergency bypass for these checks to improve merge safety and reduce the chance of faulty releases.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Three new ticket contracts (OMN-13530, OMN-13531, OMN-13532) are added and one existing contract (OMN-592) is amended, each specifying enforcement rules, evidence requirements, DOD items, and emergency bypass settings. Corresponding command.yaml DOD receipt files are added under drift/dod_receipts/ for each ticket, recording PASS attestations with provenance metadata.

Changes

OCC Contracts and DOD Receipts

Layer / File(s) Summary
OMN-13530 contract and receipts
contracts/OMN-13530.yaml, drift/dod_receipts/OMN-13530/dod-deploy-no-runtime-impact/command.yaml, drift/dod_receipts/OMN-13530/dod-omnibase-core-pr-1310/command.yaml, drift/dod_receipts/OMN-13530/dod-occ-pr-self/command.yaml
Adds the enforcement contract for the handler-routing operation_match gate (static/CI/pre-commit only, no deploy required) plus three DOD receipts: deploy-no-runtime-impact attestation, omnibase-core PR-1310 head-ref verification, and OCC self-binding receipt, all PASS.
OMN-13531 contract and receipts
contracts/OMN-13531.yaml, drift/dod_receipts/OMN-13531/dod-deploy-no-runtime-impact/command.yaml, drift/dod_receipts/OMN-13531/dod-omnibase-infra-pr-2080/command.yaml, drift/dod_receipts/OMN-13531/dod-omniclaude-pr-1796/command.yaml, drift/dod_receipts/OMN-13531/dod-occ-pr-self/command.yaml
Adds the contract for skill-node catalog resolver / pr_review skill surface alignment (interface_change: public_api) plus four DOD receipts: deploy-no-runtime-impact, omnibase-infra PR-2080, omniclaude PR-1796, and OCC self-binding, all PASS.
OMN-13532 contract and receipts
contracts/OMN-13532.yaml, drift/dod_receipts/OMN-13532/dod-deploy-no-runtime-impact/command.yaml, drift/dod_receipts/OMN-13532/dod-omnibase-infra-pr-2079/command.yaml, drift/dod_receipts/OMN-13532/dod-occ-pr-self/command.yaml
Adds the contract for the onex delegate --bus kafka live-bus path with bootstrap validation (interface_change, CLI scope only) plus three DOD receipts: deploy-no-runtime-impact, omnibase-infra PR-2079 head-ref, and OCC self-binding, all PASS.
OMN-592 contract amendment and receipts
contracts/OMN-592.yaml, drift/dod_receipts/OMN-592/dod-deploy-no-runtime-impact/command.yaml, drift/dod_receipts/OMN-592/dod-occ-pr-self/command.yaml
Appends a dod-deploy-no-runtime-impact evidence entry to the existing OMN-592 contract and adds two matching receipts: deploy-no-runtime-impact attestation and OCC self-binding, both PASS, asserting no live deploy is required for the NodeReducer refactor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#2669: Adds OCC seam contracts and DOD evidence for enabling a Kafka live-bus target via CLI with bootstrap validation, directly parallel to the OMN-13532 contract added in this PR.

Poem

🐇 Hop, hop, through the contract gate I go,
Where YAML receipts line up in a row,
No live deploy, no broker to fret,
Just evidence stamps and a clean SHA set.
The DOD is sealed, the bypass denied—
This bunny's diff is certified! ✅

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main changes: adding OCC receipts for three specific tickets (OMN-13530, OMN-13531, OMN-13532), which aligns with the PR's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13530-13532-occ-evidence

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13530-13532-occ-evidence branch from 9178a13 to 4315b10 Compare June 23, 2026 14:44
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13530-13532-occ-evidence branch from 4315b10 to be1ce59 Compare June 23, 2026 14:51
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-13531/dod-occ-pr-self/command.yaml`:
- Line 10: The commit_sha field in the command.yaml file for the dod-occ-pr-self
receipt type is currently set to an actual commit hash, but it should be set to
an all-zero placeholder value to maintain the self-binding provenance pattern.
Replace the current commit SHA value with the all-zero placeholder
(0000000000000000000000000000000000000000) as this is required for self-binding
OCC receipts prior to merge commit materialization.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 983b1805-dd82-4943-bdc8-c6bd90aa43d9

📥 Commits

Reviewing files that changed from the base of the PR and between 9178a13 and be1ce59.

📒 Files selected for processing (16)
  • contracts/OMN-13530.yaml
  • contracts/OMN-13531.yaml
  • contracts/OMN-13532.yaml
  • contracts/OMN-592.yaml
  • drift/dod_receipts/OMN-13530/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13530/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-13530/dod-omnibase-core-pr-1310/command.yaml
  • drift/dod_receipts/OMN-13531/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13531/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-13531/dod-omnibase-infra-pr-2080/command.yaml
  • drift/dod_receipts/OMN-13531/dod-omniclaude-pr-1796/command.yaml
  • drift/dod_receipts/OMN-13532/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13532/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-13532/dod-omnibase-infra-pr-2079/command.yaml
  • drift/dod_receipts/OMN-592/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-592/dod-occ-pr-self/command.yaml
✅ Files skipped from review due to trivial changes (10)
  • drift/dod_receipts/OMN-13531/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13532/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13530/dod-deploy-no-runtime-impact/command.yaml
  • drift/dod_receipts/OMN-13530/dod-occ-pr-self/command.yaml
  • contracts/OMN-592.yaml
  • drift/dod_receipts/OMN-592/dod-occ-pr-self/command.yaml
  • contracts/OMN-13531.yaml
  • drift/dod_receipts/OMN-13530/dod-omnibase-core-pr-1310/command.yaml
  • drift/dod_receipts/OMN-592/dod-deploy-no-runtime-impact/command.yaml
  • contracts/OMN-13532.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • contracts/OMN-13530.yaml
  • drift/dod_receipts/OMN-13531/dod-omnibase-infra-pr-2080/command.yaml
  • drift/dod_receipts/OMN-13532/dod-omnibase-infra-pr-2079/command.yaml
  • drift/dod_receipts/OMN-13531/dod-omniclaude-pr-1796/command.yaml

contract_sha256: "sha256:4dd54c96a91b43e4c0d4b303a9f7411b4c24357f1c3f10f867f697e3aa1773ac"
status: PASS
run_timestamp: "2026-06-23T14:58:00Z"
commit_sha: "4315b105ee4f60cdab1a6611efa6cf919aff3532"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Use the self-binding placeholder SHA for dod-occ-pr-self.

For this receipt type, commit_sha should be the all-zero placeholder until merge commit materialization; storing the current head SHA here breaks the established self-binding provenance pattern.

Suggested fix
-commit_sha: "4315b105ee4f60cdab1a6611efa6cf919aff3532"
+commit_sha: "0000000000000000000000000000000000000000"

Based on learnings: self-binding OCC receipts at drift/dod_receipts/<TICKET>/dod-occ-pr-self/command.yaml intentionally use an all-zero commit_sha placeholder pre-merge.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
commit_sha: "4315b105ee4f60cdab1a6611efa6cf919aff3532"
commit_sha: "0000000000000000000000000000000000000000"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@drift/dod_receipts/OMN-13531/dod-occ-pr-self/command.yaml` at line 10, The
commit_sha field in the command.yaml file for the dod-occ-pr-self receipt type
is currently set to an actual commit hash, but it should be set to an all-zero
placeholder value to maintain the self-binding provenance pattern. Replace the
current commit SHA value with the all-zero placeholder
(0000000000000000000000000000000000000000) as this is required for self-binding
OCC receipts prior to merge commit materialization.

Source: Learnings

Merged via the queue into dev with commit 082d029 Jun 23, 2026
45 of 46 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13530-13532-occ-evidence branch June 23, 2026 15:02
jonahgabriel added a commit that referenced this pull request Sep 26, 2026
…o dev, pass 9)

Re-appends 9 net-new dod_evidence entries (occ-observation-run36121424954-1
through run36259753890-1, covering omnimarket PRs #2868, #2910, #2912, #2931,
#2953, #2955, #2956, #2963, #2965) onto dev's advanced contracts/OMN-14888.yaml
tail (1888 -> 1897 entries), plus the corresponding dod_receipts, the
occ-self-bind receipt, and occ_observations files, unchanged byte-identical
content pulled from the PR's own prior head. Same rebase-and-append pattern as
passes 1, 2 and 6 of this PR's landing history.
jonahgabriel added a commit that referenced this pull request Sep 26, 2026
…a210ab925d8d466f__v1__run36121424954-1.yaml) (#11250)

* evidence(OMN-14888): OCC observation append for PR #11250 (rebase onto dev, pass 9)

Re-appends 9 net-new dod_evidence entries (occ-observation-run36121424954-1
through run36259753890-1, covering omnimarket PRs #2868, #2910, #2912, #2931,
#2953, #2955, #2956, #2963, #2965) onto dev's advanced contracts/OMN-14888.yaml
tail (1888 -> 1897 entries), plus the corresponding dod_receipts, the
occ-self-bind receipt, and occ_observations files, unchanged byte-identical
content pulled from the PR's own prior head. Same rebase-and-append pattern as
passes 1, 2 and 6 of this PR's landing history.

* evidence(OMN-14888): re-pin self-bind whole-file contract hash for PR #11250 after rebase (pass 9)

* evidence(OMN-14888): OCC observation append drift/occ_observations/OmniNode-ai__omnimarket/pr-2913/aba970c6918500f30a9be3ef854fceef96ed65ca__v1__run36275499585-1.yaml

* evidence(OMN-14888): OCC observation self-bind occ-observation-run36275499585-1

* evidence(OMN-14888): OCC observation append drift/occ_observations/OmniNode-ai__omnimarket/pr-2961/ea06687c3b8d007f29eaf208b889b7206c6eaba7__v1__run36250919235-2.yaml

* evidence(OMN-14888): OCC observation self-bind occ-observation-run36250919235-2

* evidence(OMN-14888): OCC observation append drift/occ_observations/OmniNode-ai__omnimarket/pr-2973/ad1421665e4930932e68dee8acfe44e9939b01a3__v1__run36276164305-1.yaml

* evidence(OMN-14888): OCC observation self-bind occ-observation-run36276164305-1

* evidence(OMN-14888): OCC observation append drift/occ_observations/OmniNode-ai__omnimarket/pr-2972/706c7a0df91b3387f9637639fda214f85a6bbd24__v1__run36276137857-1.yaml

* evidence(OMN-14888): OCC observation self-bind occ-observation-run36276137857-1

---------

Co-authored-by: jonahgabriel <jonah@omninode.ai>
Co-authored-by: node-occ-observation-effect <occ-observation-effect@omninode.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant