Repository navigation
evidence(OMN-13164): OCC receipt — merge-sweep bus-target preflight fix - #2669
Conversation
Pairs with omnimarket PR for OMN-13164. Fix: _check_bus_target_configured() raises ProtocolConfigurationError immediately when KAFKA_BOOTSTRAP_SERVERS is absent, preventing the 30-second aiokafka connection-retry loop that blocked autonomous overnight sweeps. DoD evidence: - 5 unit tests in TestBusTargetPreflightGuard all green - mypy --strict clean - CLI emits typed JSON blocker packet (bus_target_not_configured)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds a new seam ticket contract ChangesOMN-13164 Contract and DOD Receipts
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
dod-001: ProtocolConfigurationError raised immediately — 5/5 guard tests pass dod-002: CLI main() emits typed JSON blocker packet — test passes dod-003: All 63 tests in test_codex_runtime_client.py pass green dod-004: mypy --strict passes (2351 source files, no new errors) dod-005: omnimarket PR #1237 cites OMN-13164 in title and body contract_sha256: sha256:ed2d3a3dcfb814217696b98b95bfec5a1a2a1234e139c80d9cd2f8bb6dafa284
Update all 5 dod receipts to bind to OCC PR #2669 (pr_number: 2669) and the current OCC HEAD commit SHA so the OCC eligibility validator recognises them as bound to this PR.
Summary
OCC evidence receipt for OMN-13164: merge-sweep bus-target preflight fix in omnimarket.
The merge-sweep skill was calling the bus with an incorrect target address when
KAFKA_BOOTSTRAP_SERVERSwas unset, causing a silent failure. This fix adds a typed error and fail-fast behavior.Evidence
dod_evidence
KAFKA_BOOTSTRAP_SERVERSunset now raises a typedConfigurationErrorimmediately rather than falling through to an unhelpful connection timeoutTest plan
Summary by CodeRabbit