Skip to content

evidence(OMN-13164): OCC receipt — merge-sweep bus-target preflight fix - #2669

Merged
jonahgabriel merged 3 commits into
devfrom
jonah/omn-13164-merge-sweep-bus-target
Jun 16, 2026
Merged

jonahgabriel merged 3 commits into
devfrom
jonah/omn-13164-merge-sweep-bus-target

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

OCC evidence receipt for OMN-13164: merge-sweep bus-target preflight fix in omnimarket.

The merge-sweep skill was calling the bus with an incorrect target address when KAFKA_BOOTSTRAP_SERVERS was unset, causing a silent failure. This fix adds a typed error and fail-fast behavior.

Evidence

  • Evidence-Source: 8a1337e
  • Evidence-Ticket: OMN-13164

dod_evidence

  • Fix committed in omnimarket at a7a2d1ff
  • OCC receipt committed at 8a1337e
  • KAFKA_BOOTSTRAP_SERVERS unset now raises a typed ConfigurationError immediately rather than falling through to an unhelpful connection timeout
  • No unrelated files staged

Test plan

  • CI green on both omnimarket and onex_change_control PRs
  • CodeRabbit threads resolved

Summary by CodeRabbit

  • Bug Fixes
    • Improved Kafka configuration validation. The system now detects missing bootstrap server configuration early and provides clear, structured error feedback through the CLI, preventing cryptic failures during initialization.

Pairs with omnimarket PR for OMN-13164.
Fix: _check_bus_target_configured() raises ProtocolConfigurationError
immediately when KAFKA_BOOTSTRAP_SERVERS is absent, preventing the 30-second
aiokafka connection-retry loop that blocked autonomous overnight sweeps.

DoD evidence:
- 5 unit tests in TestBusTargetPreflightGuard all green
- mypy --strict clean
- CLI emits typed JSON blocker packet (bus_target_not_configured)
@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02ceee41-1401-4c60-bca8-97c0d5f7cbfa

📥 Commits

Reviewing files that changed from the base of the PR and between 93872f2 and ec37d72.

📒 Files selected for processing (6)
  • contracts/OMN-13164.yaml
  • drift/dod_receipts/OMN-13164/dod-001/command.yaml
  • drift/dod_receipts/OMN-13164/dod-002/command.yaml
  • drift/dod_receipts/OMN-13164/dod-003/command.yaml
  • drift/dod_receipts/OMN-13164/dod-004/command.yaml
  • drift/dod_receipts/OMN-13164/dod-005/command.yaml

📝 Walkthrough

Walkthrough

Adds a new seam ticket contract contracts/OMN-13164.yaml defining a fail-fast behavior for missing KAFKA_BOOTSTRAP_SERVERS (raising ProtocolConfigurationError and emitting a typed JSON blocker packet), plus five drift/dod_receipts/OMN-13164/dod-00*/command.yaml receipt files recording PASS results for all specified DOD checks.

Changes

OMN-13164 Contract and DOD Receipts

Layer / File(s) Summary
OMN-13164 seam ticket contract
contracts/OMN-13164.yaml
Defines the full contract with schema/ticket metadata, the _check_bus_target_configured() / ProtocolConfigurationError failure-mode description, and all evidence/DOD check commands (pytest targets, mypy strict, PR citation grep).
DOD command receipts
drift/dod_receipts/OMN-13164/dod-00*/command.yaml
Five receipts record status: PASS and exit_code: 0 for each DOD check: preflight guard unit tests (dod-001), CLI typed blocker emission test (dod-002), codex runtime client tests (dod-003), mypy strict (dod-004), and PR citation verification (dod-005).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A contract is planted, the receipts are sealed,
Five checks all PASS, the evidence revealed.
No Kafka config? The error fast flies,
A typed blocker packet under clear skies.
Hop, hop—the DOD is done! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the ticket identifier (OMN-13164) and accurately describes the main change: adding an OCC evidence receipt for a bus-target preflight configuration fix in the merge-sweep skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13164-merge-sweep-bus-target

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge June 16, 2026 21:46
dod-001: ProtocolConfigurationError raised immediately — 5/5 guard tests pass
dod-002: CLI main() emits typed JSON blocker packet — test passes
dod-003: All 63 tests in test_codex_runtime_client.py pass green
dod-004: mypy --strict passes (2351 source files, no new errors)
dod-005: omnimarket PR #1237 cites OMN-13164 in title and body

contract_sha256: sha256:ed2d3a3dcfb814217696b98b95bfec5a1a2a1234e139c80d9cd2f8bb6dafa284
Update all 5 dod receipts to bind to OCC PR #2669 (pr_number: 2669)
and the current OCC HEAD commit SHA so the OCC eligibility validator
recognises them as bound to this PR.
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 16, 2026
Merged via the queue into dev with commit 0ec5869 Jun 16, 2026
41 of 42 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13164-merge-sweep-bus-target branch June 16, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant