Skip to content

evidence(OMN-11247): bind omnibase_infra PR #1677 test harness fix receipt - #1237

Closed
jonahgabriel wants to merge 4 commits into
mainfrom
jonah/omn-11247-infra-pr-1677-receipt
Closed

jonahgabriel wants to merge 4 commits into
mainfrom
jonah/omn-11247-infra-pr-1677-receipt

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

DoD Evidence

Evidence-Ticket: OMN-11247
Evidence-Source: OCC#1156

Verification

  • uv run validate-yaml contracts/OMN-11247.yaml → OK
  • Receipt YAML validated by pre-commit hooks

Summary by CodeRabbit

  • Chores
    • Added a new validation evidence entry and a command-based verification check to the OMN-11247 manifest, recording probe results and run metadata.
    • Updated an existing command-based receipt to target a new PR/branch context and refreshed timestamps, probe output, and commit reference so verification remains accurate.
    • No public API or exported entity changes.

Review Change Stack

…ceipt

- Add dod-omnibase-infra-pr-1677 receipt binding to commit 600f5e3b
- Add corresponding dod_evidence entry in OMN-11247 contract
@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 971631a6-1d3e-47f7-85a0-d2cff5199cfa

📥 Commits

Reviewing files that changed from the base of the PR and between 18418de and 9018bac.

📒 Files selected for processing (3)
  • contracts/OMN-11247.yaml
  • drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-11247/dod-omnibase-infra-pr-1677/command.yaml
✅ Files skipped from review due to trivial changes (1)
  • contracts/OMN-11247.yaml

📝 Walkthrough

Walkthrough

This PR adds a new dod_evidence entry dod-omnibase-infra-pr-1677 to the OMN-11247 contract and adds its command.yaml receipt; it also updates an existing receipt (dod-occ-pr/command.yaml) to reference the new PR/commit context while preserving PASS status.

Changes

Evidence Registration for OMN-11247

Layer / File(s) Summary
Evidence entry, new receipt, and updated receipt
contracts/OMN-11247.yaml, drift/dod_receipts/OMN-11247/dod-omnibase-infra-pr-1677/command.yaml, drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml
Adds dod-omnibase-infra-pr-1677 to the contract manifest with a command check and its receipt file containing probe command, run timestamp, commit SHA, runner/verifier, captured stdout, and exit code. Also updates dod-occ-pr/command.yaml to point to the new PR/branch/commit and refreshes associated metadata while keeping status: PASS and exit_code: 0.

Sequence Diagram(s)

sequenceDiagram
  participant ContractManifest
  participant NewReceipt
  participant UpdatedReceipt
  ContractManifest->>NewReceipt: declare evidence item dod-omnibase-infra-pr-1677 (command check)
  NewReceipt->>UpdatedReceipt: align PR/commit metadata (PR `#1237` / PR `#1677`, commit_sha, timestamps)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1236: Both PRs add/update OMN-11247 evidence specifically for dod-omnibase-infra-pr-1677, including the corresponding receipt and contract manifest entry.

Poem

I nibble through manifests, neat and spry,
New receipts lined up, commit SHAs high,
Commands all passed beneath moonlight,
PR #1677 shining bright—
A rabbit's hop approves tonight. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: binding a test harness fix receipt for omnibase_infra PR #1677 to the OMN-11247 contract, which aligns with the primary changes adding the evidence entry and receipt files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11247-infra-pr-1677-receipt
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch jonah/omn-11247-infra-pr-1677-receipt

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-11247.yaml`:
- Around line 74-81: Update the description field for the entry with id
"dod-omnibase-infra-pr-1677": replace the existing description value with one
that states the primary change (injecting the ServiceRegistration postgres_pool
into the runtime manifest handler) while still mentioning the test harness
regressions fix introduced by materialized-deps wiring; ensure the new
description text matches the suggested phrasing and preserves YAML
quoting/formatting for the description field.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be2350f6-c306-43e8-9371-9e363090b29d

📥 Commits

Reviewing files that changed from the base of the PR and between 27b3684 and de94236.

📒 Files selected for processing (2)
  • contracts/OMN-11247.yaml
  • drift/dod_receipts/OMN-11247/dod-omnibase-infra-pr-1677/command.yaml

Comment thread contracts/OMN-11247.yaml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml`:
- Line 10: Update the commit_sha value in command.yaml so the receipt points to
the PR head instead of an outdated commit: locate the commit_sha entry
(currently "de9423699c4f8b194422159bf618677feea1dc6a") and replace it with the
PR `#1237` head SHA "18418de8571c341d4da18bf2584d01fb5e3d8ebf" to ensure the
receipt references the correct commit.
- Around line 6-7: The check_value command uses an invalid gh CLI flag (--head)
which causes "unknown flag" errors; update the check_value string (the variable
named check_value) to call gh pr view with either the PR number (e.g., "gh pr
view 1237 --repo OmniNode-ai/onex_change_control --json
number,state,headRefName,headRefOid,url") or with the branch as a positional
argument (e.g., "gh pr view jonah/omn-11247-infra-pr-1677-receipt --repo
OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url")
so it matches the valid usage shown by probe_command and removes the --head
flag.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 303d2d5d-d551-4d39-8d24-db8f9f75ee6b

📥 Commits

Reviewing files that changed from the base of the PR and between de94236 and 18418de.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml

Comment thread drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml Outdated
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closing as superseded by merged OCC evidence PR #1236 and boundary-action cleanup PR #1238. PR #1236 carries the OMN-11247/omnibase_infra#1677 evidence through the final head, and PR #1238 fixed the validate-boundaries rerun failure; omnibase_infra#1677 is now merged.

jonahgabriel added a commit that referenced this pull request Jun 16, 2026
dod-001: ProtocolConfigurationError raised immediately — 5/5 guard tests pass
dod-002: CLI main() emits typed JSON blocker packet — test passes
dod-003: All 63 tests in test_codex_runtime_client.py pass green
dod-004: mypy --strict passes (2351 source files, no new errors)
dod-005: omnimarket PR #1237 cites OMN-13164 in title and body

contract_sha256: sha256:ed2d3a3dcfb814217696b98b95bfec5a1a2a1234e139c80d9cd2f8bb6dafa284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant