Repository navigation
evidence(OMN-11247): bind omnibase_infra PR #1677 test harness fix receipt - #1237
jonahgabriel wants to merge 4 commits into
Conversation
…ceipt - Add dod-omnibase-infra-pr-1677 receipt binding to commit 600f5e3b - Add corresponding dod_evidence entry in OMN-11247 contract
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds a new ChangesEvidence Registration for OMN-11247
Sequence Diagram(s)sequenceDiagram
participant ContractManifest
participant NewReceipt
participant UpdatedReceipt
ContractManifest->>NewReceipt: declare evidence item dod-omnibase-infra-pr-1677 (command check)
NewReceipt->>UpdatedReceipt: align PR/commit metadata (PR `#1237` / PR `#1677`, commit_sha, timestamps)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-11247.yaml`:
- Around line 74-81: Update the description field for the entry with id
"dod-omnibase-infra-pr-1677": replace the existing description value with one
that states the primary change (injecting the ServiceRegistration postgres_pool
into the runtime manifest handler) while still mentioning the test harness
regressions fix introduced by materialized-deps wiring; ensure the new
description text matches the suggested phrasing and preserves YAML
quoting/formatting for the description field.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be2350f6-c306-43e8-9371-9e363090b29d
📒 Files selected for processing (2)
contracts/OMN-11247.yamldrift/dod_receipts/OMN-11247/dod-omnibase-infra-pr-1677/command.yaml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml`:
- Line 10: Update the commit_sha value in command.yaml so the receipt points to
the PR head instead of an outdated commit: locate the commit_sha entry
(currently "de9423699c4f8b194422159bf618677feea1dc6a") and replace it with the
PR `#1237` head SHA "18418de8571c341d4da18bf2584d01fb5e3d8ebf" to ensure the
receipt references the correct commit.
- Around line 6-7: The check_value command uses an invalid gh CLI flag (--head)
which causes "unknown flag" errors; update the check_value string (the variable
named check_value) to call gh pr view with either the PR number (e.g., "gh pr
view 1237 --repo OmniNode-ai/onex_change_control --json
number,state,headRefName,headRefOid,url") or with the branch as a positional
argument (e.g., "gh pr view jonah/omn-11247-infra-pr-1677-receipt --repo
OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url")
so it matches the valid usage shown by probe_command and removes the --head
flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 303d2d5d-d551-4d39-8d24-db8f9f75ee6b
📒 Files selected for processing (1)
drift/dod_receipts/OMN-11247/dod-occ-pr/command.yaml
dod-001: ProtocolConfigurationError raised immediately — 5/5 guard tests pass dod-002: CLI main() emits typed JSON blocker packet — test passes dod-003: All 63 tests in test_codex_runtime_client.py pass green dod-004: mypy --strict passes (2351 source files, no new errors) dod-005: omnimarket PR #1237 cites OMN-13164 in title and body contract_sha256: sha256:ed2d3a3dcfb814217696b98b95bfec5a1a2a1234e139c80d9cd2f8bb6dafa284
Summary
dod-omnibase-infra-pr-1677evidence entry to the OMN-11247 contract.DoD Evidence
Evidence-Ticket: OMN-11247
Evidence-Source: OCC#1156
Verification
uv run validate-yaml contracts/OMN-11247.yaml→ OKSummary by CodeRabbit