Skip to content

contracts(OMN-11590): complete OCC evidence with all receipt fixes - #1685

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-11590-dod-evidence-v2
May 26, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-11590-dod-evidence-v2

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds dod-occ-pr evidence item to contracts/OMN-11590.yaml
  • Adds contract_sha256 to all receipts (required for receipts after 2026-04-30, OMN-10421)
  • Fixes working_dir to absolute paths required by ModelDodReceipt validator
  • Binds dod-occ-pr receipt to this OCC PR via commit_sha

Verification

All pre-commit hooks pass. Contract validates against ModelTicketContract.

Evidence-Ticket: OMN-11590

Summary by CodeRabbit

  • New Features

    • Added contract verification evidence mechanism with automated proof checks.
  • Chores

    • Updated proof-of-execution receipts with enhanced integrity metadata.
    • Updated test validation records and working paths.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d1c8e7d8-2feb-41d8-be79-95ddccf23931

📥 Commits

Reviewing files that changed from the base of the PR and between 0a835e6 and fd1bf5d.

📒 Files selected for processing (5)
  • contracts/OMN-11590.yaml
  • drift/dod_receipts/OMN-11590/dod-golden-tests/command.yaml
  • drift/dod_receipts/OMN-11590/dod-local-validation/command.yaml
  • drift/dod_receipts/OMN-11590/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-11590/dod-omniclaude-pr/command.yaml
📝 Walkthrough

Walkthrough

OMN-11590 contract adds a new definition-of-done requirement (dod-occ-pr) that uses a command-based proof to verify nested receipt evidence. The change introduces a new dod-occ-pr/command.yaml receipt and updates all existing receipt records with consistent contract SHA256 hash bindings and normalized local filesystem working directories.

Changes

OMN-11590 DOD Evidence Addition

Layer / File(s) Summary
Contract Evidence Declaration
contracts/OMN-11590.yaml
Contract declares the new dod-occ-pr evidence requirement with command checks for status: PASS and matching ticket_id.
New dod-occ-pr Command Receipt
drift/dod_receipts/OMN-11590/dod-occ-pr/command.yaml
New receipt introduces the command probe logic that validates the dod-omniclaude-pr nested receipt contains the required status and ticket identifier, capturing contract SHA256, run metadata, and expected probe output.
Receipt Hash and Path Consistency Updates
drift/dod_receipts/OMN-11590/dod-golden-tests/command.yaml, drift/dod_receipts/OMN-11590/dod-local-validation/command.yaml, drift/dod_receipts/OMN-11590/dod-omniclaude-pr/command.yaml
All receipt records updated with new contract SHA256 bindings and working_dir paths replaced from $OMNI_HOME references to hardcoded local filesystem paths. dod-omniclaude-pr additionally updates probe_command to request and include mergedAt field in stdout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1569: Both PRs add new dod-occ-pr/command.yaml command-receipt evidence with status: PASS and matching ticket/PR metadata, plus corresponding dod_evidence wiring in the OMN contract YAML.
  • OmniNode-ai/onex_change_control#1145: Both PRs modify the DOD receipt-evidence mechanism for dod-occ-pr command verifications by updating contracts/*/dod_evidence check commands and corresponding drift/dod_receipts/*/dod-occ-pr/command.yaml receipt logic.
  • OmniNode-ai/onex_change_control#1300: Both PRs update dod-*/command.yaml receipt evidence to add/hash-bind a contract_sha256 field for receipt gate command checks across multiple receipt types.

Poem

🐰 A new evidence proof hops into place,
With occ-pr checks at a quickened pace,
Contract and receipt now tightly aligned,
SHA hashes bound, paths refined—
OMN-11590's definition of done, complete and signed! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new OCC evidence entry (dod-occ-pr) and fixing receipt validation issues across multiple receipt files for contract OMN-11590.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11590-dod-evidence-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

Adds dod-occ-pr evidence item. Fixes contract_sha256, working_dir absolute
paths, and binds dod-occ-pr receipt to this OCC PR per ModelDodReceipt requirements.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11590-dod-evidence-v2 branch from 0a835e6 to fd1bf5d Compare May 26, 2026 09:50
@jonahgabriel
jonahgabriel merged commit dd0dea4 into dev May 26, 2026
32 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11590-dod-evidence-v2 branch May 26, 2026 09:54
jonahgabriel added a commit that referenced this pull request Jul 10, 2026
* evidence(OMN-14282): OCC companion for omnimarket #1685 (node_deep_dive_report_effect thin canonicalization)

Central OMN-14282 ticket contract + landing-verification and deploy-assessment
receipts consumed by omnimarket product PR #1685 via its Evidence-Source line.

* evidence(OMN-14282): add dod-occ-self receipt (self-bind via C1 commit_sha)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant