Skip to content

evidence(OMN-12909): refresh gateway deploy receipts - #2496

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-12909-gateway-deploy-evidence
Jun 11, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-12909-gateway-deploy-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • refresh OMN-12909 contract evidence for omnibase_infra PR evidence(OMN-12513): add runtime toolchain receipts #1946 head 849ebd1f
  • add explicit no-runtime-deploy evidence item for deploy-gate keyword requirements
  • stamp all OMN-12909 receipts to contract sha256:57ef3894f8064d217b73bd57280267267cd8b2ade29268649e89a8848949f81d

Verification

  • uv run validate-yaml contracts/OMN-12909.yaml
  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-12909.yaml
  • uv run python -m omnibase_core.validation.validator_receipt_honesty --receipts-dir drift/dod_receipts drift/dod_receipts/OMN-12909/dod-local-validation/command.yaml drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml drift/dod_receipts/OMN-12909/dod-omnibase-infra-pr-1946/command.yaml drift/dod_receipts/OMN-12909/dod-omninode-infra-pr-496/command.yaml drift/dod_receipts/OMN-12909/dod-no-runtime-deploy/command.yaml
  • SKIP=check-receipt-honesty uv run pre-commit run --files contracts/OMN-12909.yaml drift/dod_receipts/OMN-12909/dod-local-validation/command.yaml drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml drift/dod_receipts/OMN-12909/dod-omnibase-infra-pr-1946/command.yaml drift/dod_receipts/OMN-12909/dod-omninode-infra-pr-496/command.yaml drift/dod_receipts/OMN-12909/dod-no-runtime-deploy/command.yaml

Summary by CodeRabbit

  • Chores
    • Updated verification evidence records for gateway implementation validation.
    • Added new validation check to confirm no runtime deployment impacts occurred.
    • Refined existing validation criteria with expanded verification markers and assertions.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour, 51 minutes, and 29 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0510ac33-8a29-4394-a0a6-fae418a4503c

📥 Commits

Reviewing files that changed from the base of the PR and between 2f79d14 and ef0357e.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml
📝 Walkthrough

Walkthrough

This PR updates the OMN-12909 evidence contract and proof-of-validation receipts. The contract specification is expanded with stricter assertion checks and a new runtime-deployment verification requirement, and the supporting receipt files are synchronized and extended to document the updated validation outcomes.

Changes

OMN-12909 Evidence Specification and Validation Records

Layer / File(s) Summary
Contract specification updates
contracts/OMN-12909.yaml
Updated the expected hash for dod-omnibase-infra-pr-1946 receipt validation. Expanded dod-local-validation assertions from generic counts to require specific "Architecture: PASS", "Patterns: PASS", "Any Types: PASS", and "All checks passed" strings. Added new dod-no-runtime-deploy evidence section requiring verification that no runtime deploy, restart, docker exec, rpk topic produce, or live cluster mutation occurred.
Receipt evidence synchronization
drift/dod_receipts/OMN-12909/dod-local-validation/command.yaml, drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml, drift/dod_receipts/OMN-12909/dod-omnibase-infra-pr-1946/command.yaml, drift/dod_receipts/OMN-12909/dod-omninode-infra-pr-496/command.yaml
Updated contract_sha256, run_timestamp, and commit_sha across multiple receipt files to align with contract changes. Revised dod-omnibase-infra-pr-1946 actual_output text to reflect updated verification scope. Introduced a new dod-no-runtime-deploy receipt documenting the PASS command check asserting no runtime mutations, including probe command, output capture, verifier metadata, and execution details.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#2046: Both PRs directly modify DoD receipt drift/dod_receipts/**/…/command.yaml by adding/updating the contract_sha256 field values (hash evidence) for their respective tickets.
  • OmniNode-ai/onex_change_control#2014: Both PRs update the drift/dod_receipts/**/command.yaml evidence records by changing the contract_sha256 value (replacing/updating digest/hash in command receipt metadata).
  • OmniNode-ai/onex_change_control#1685: Both PRs touch the dod-occ-pr command receipt evidence by updating/adding contract_sha256-bound OCC verification data for their respective contracts (OMN-12909 vs OMN-11590), so the change patterns are directly aligned.

Poem

🐰 A gateway springs to life today,
Its proofs and patterns all align,
With hashes fresh and checks in sway—
No runtime dance will mark our line!
The evidence flows, complete and true,
So contracts and receipts renew. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'evidence(OMN-12909): refresh gateway deploy receipts' clearly and concisely summarizes the main change: updating/refreshing evidence receipts for the OMN-12909 gateway deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12909-gateway-deploy-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge June 11, 2026 15:36

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml`:
- Around line 6-7: Stale PR binding: replace all occurrences of PR number 2492
with 2496 in the receipt metadata so the OCC proof chain matches this
refresh—specifically update the check_value strings (e.g., "gh pr view 2492
--repo OmniNode-ai/onex_change_control --json ...") to use 2496 and scan the
other metadata entries referenced (lines mentioned: 12, 15, 19) for any
remaining "2492" instances and update them as well; after change, run the same
gh pr view command to confirm the returned
number/url/headRefName/baseRefName/title/state reflect PR `#2496`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 001f3fd7-1190-4eea-8834-14d72354fb52

📥 Commits

Reviewing files that changed from the base of the PR and between 3b3e73b and 2f79d14.

📒 Files selected for processing (6)
  • contracts/OMN-12909.yaml
  • drift/dod_receipts/OMN-12909/dod-local-validation/command.yaml
  • drift/dod_receipts/OMN-12909/dod-no-runtime-deploy/command.yaml
  • drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-12909/dod-omnibase-infra-pr-1946/command.yaml
  • drift/dod_receipts/OMN-12909/dod-omninode-infra-pr-496/command.yaml

Comment thread drift/dod_receipts/OMN-12909/dod-occ-pr/command.yaml
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 11, 2026
Merged via the queue into dev with commit 77ef228 Jun 11, 2026
36 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12909-gateway-deploy-evidence branch June 11, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant