Skip to content

evidence(OMN-13401): OCC contract + receipts for delegation 0018/0019 migration vendoring - #2870

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-13401-occ-evidence
Jun 21, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-13401-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 21, 2026 •

Copy link
Copy Markdown
Contributor

OMN-13401 — OCC evidence (delegation cost/budget migration vendoring)

Evidence-Source: OMN-13401
Evidence-Ticket: OMN-13401

Carries the central contracts/OMN-13401.yaml + PASS dod_receipts consumed by the omnibase_infra PR #2054 Receipt Gate via Evidence-Source: OCC#<this-PR>. Mirrors the 0017 OCC evidence pattern (OCC#2845 / OMN-13355) and the savings-cluster OCC evidence (OCC#2868 / OMN-13234/13235).

What OMN-13401 does

Vendors the node-owned delegation migrations 0018_delegation_cost_measurements.sql and 0019_delegation_budget_state.sql into omnibase_infra's deployed forward-migration tree under docker/migrations/forward/nodes/node_projection_delegation/ (infra origin/dev topped out at 0017). Vendored 1:1 via scripts/sync-node-migrations.sh (OMN-12559 — no hand-copy, no renumber). 0018 carries OMN-13234's typed per-tier actual-cost columns; 0019 carries OMN-13235's per-tenant ceiling budget-state table.

Receipts (all PASS; runner=claude-code, verifier=claude-code-review)

id proves
dod-infra-pr-2054-vendor 0019 CREATE TABLE IF NOT EXISTS delegation_budget_state present in vendored tree
dod-byte-match 0018/0019 sha256 byte-identical to omnimarket origin/dev source (no hand-edit)
dod-sync-check sync-node-migrations.sh --check reports "in sync" (no remaining drift)
dod-deploy 0018/0019 idempotent (ADD COLUMN / CREATE TABLE IF NOT EXISTS); no service deploy
dod-occ-pr self-binding contract presence in OCC tree

OCC Receipt Hardening Gate + validate-yaml pass locally. PR no-merge — left green for the merge sweep.

Summary by CodeRabbit

  • Chores
    • Added infrastructure deployment contract specification and verification evidence records for migration validation and deployment confirmation. Documentation includes content integrity checks, deployment guard validation, synchronization verification, and comprehensive verification receipts with execution metadata supporting infrastructure deployment tracking and operational validation processes.

… migration vendoring

Carries the central contract (contracts/OMN-13401.yaml) and PASS dod_receipts the
omnibase_infra PR #2054 Receipt Gate consumes via Evidence-Source. OMN-13401 vendors
the node-owned delegation migrations 0018_delegation_cost_measurements and
0019_delegation_budget_state into omnibase_infra's deployed forward-migration tree
(1:1 via scripts/sync-node-migrations.sh, mirroring 0017 / OMN-13355).

Receipts (all PASS, runner=claude-code, verifier=claude-code-review):
  dod-infra-pr-2054-vendor  — 0019 budget-state table create present in vendored tree
  dod-byte-match            — 0018/0019 sha256 identical to omnimarket origin/dev source
  dod-sync-check            — sync-node-migrations.sh --check reports in sync (no drift)
  dod-deploy                — 0018/0019 idempotent (ADD COLUMN / CREATE TABLE IF NOT EXISTS); no service deploy
  dod-occ-pr                — self-binding contract presence in OCC tree

Evidence-Source: OMN-13401
Evidence-Ticket: OMN-13401
@coderabbitai

coderabbitai Bot commented Jun 21, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a70a7e97-581e-4240-8c68-3a9a9457a1c7

📥 Commits

Reviewing files that changed from the base of the PR and between fc614a0 and f17e72a.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-13401/dod-occ-pr/command.yaml
📝 Walkthrough

Walkthrough

Adds a new change control contract (contracts/OMN-13401.yaml) for vendoring node delegation migrations 0018 and 0019 into the omnibase_infra forward-migration tree, along with five Drift DoD evidence receipt files under drift/dod_receipts/OMN-13401/ recording PASS outcomes for byte-match, vendor grep, sync-check, deploy-gate, and OCC PR gate verifications.

Changes

OMN-13401 Contract and DoD Evidence

Layer / File(s) Summary
Contract definition and DoD evidence declarations
contracts/OMN-13401.yaml
Defines the contract with schema version, ticket metadata, migration-vendoring summary, control flags (is_seam_ticket: false, interface_change: false), disabled emergency_bypass, and the full dod_evidence array referencing all five receipt paths.
Drift DoD receipt files
drift/dod_receipts/OMN-13401/dod-byte-match/command.yaml, drift/dod_receipts/OMN-13401/dod-infra-pr-2054-vendor/command.yaml, drift/dod_receipts/OMN-13401/dod-deploy/command.yaml, drift/dod_receipts/OMN-13401/dod-sync-check/command.yaml, drift/dod_receipts/OMN-13401/dod-occ-pr/command.yaml
Adds five command.yaml receipts recording PASS outcomes: cmp -s byte-match on 0018/0019 SQL pairs with SHA-256 captures; grep confirming CREATE TABLE IF NOT EXISTS delegation_budget_state in 0019; grep counting ADD COLUMN IF NOT EXISTS guards (expected 5) in 0018; scripts/sync-node-migrations.sh --check sync verification; and grep confirming ticket_id: "OMN-13401" in the contract file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1685: Adds/fixes a dod-occ-pr/command.yaml receipt verifying ticket_id presence in a contract file using the same grep -c pattern and contract_sha256 field used here.
  • OmniNode-ai/onex_change_control#2834: Adds a contract and Drift receipts for vendoring the 0016 migration set from the same docker/migrations/forward/nodes/node_projection_delegation/ path, using the identical sync/grep-based verification approach.

Poem

🐇 Two SQL files travel far,
Vendored safely, byte by byte.
The grep confirms each table star,
The sync script says: "All right!"
DoD receipts now fill the night—
Migration proof sealed tight. ✅

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: adding an OCC contract and receipts for evidence documentation of delegation migrations (0018/0019 vendoring), matching the PR's core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13401-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge June 21, 2026 05:54
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 21, 2026
Merged via the queue into dev with commit 0a67325 Jun 21, 2026
38 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13401-occ-evidence branch June 21, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant