Repository navigation
contracts(OMN-11932): add omnibase_core PR #1149 evidence - #1544
Merged
Merged
Conversation
|
Warning Review limit reached
Your plan currently allows 5 reviews/hour. Refill in 9 minutes and 56 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
force-pushed
the
jonah/omn-11932-occ-evidence
branch
from
May 24, 2026 19:23
9e4bab1 to
78b8638
Compare
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants) - Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb - Records 10/10 unit tests passing for the new StrEnum constants
jonahgabriel
force-pushed
the
jonah/omn-11932-occ-evidence
branch
from
May 24, 2026 19:29
78b8638 to
cd26266
Compare
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…mniNode-ai#852) * feat(OMN-10723): add ticket contract for inprocess fallback removal Contract covers omniclaude PR OmniNode-ai#1544: removes silent inprocess delegation fallback, adds no-inprocess-fallback-in-skills pre-commit gate. * fix(OMN-10723): add dod-001 receipt for inprocess fallback removal Receipt proves omniclaude PR OmniNode-ai#1544 CI all-green with inprocess fallback removed and tests updated to verify new explicit error behavior. * fix(OMN-10723): use grep check_value pattern and fix receipt verifier/hash - Change dod-001 check_value to grep the receipt file directly (avoids gh CLI external call that fails in CI without auth) - Set verifier=jonahgabriel (distinct from runner to avoid ADVISORY downgrade) - Set pr_number=852 (OCC PR) and contract_sha256 to match updated contract
This was referenced Jul 1, 2026
jonahgabriel
added a commit
that referenced
this pull request
Aug 4, 2026
…append-only) Root cause, reproduced against the exact occ-preflight CI invocation (module/args/env, core wheel built from origin/dev @5ad319b66b, which now includes core#1544/OMN-15664 AC5): omnibase_core.validation. validator_receipt_gate._honestly_superseded_dod_ids.is_disclosed_skip requires `checks == []` exactly (post-CodeRabbit hardening, commit a681b2bf on PR #1544 — `checks = item.get("checks")` with no default, so an omitted key resolves to None and `None == []` is False). The dod-omn15413-ac6-disclosed-skip-restored entry carried NO `checks` key at all, so the honesty exemption never fired and eligibility kept reporting missing_receipt on OMN-15413:dod-omn15413-ac6-no-live-migration-skip:command even after core#1544 merged to dev. The earlier local replay (wf_ea69bdbb-5e8) that reported eligible=True ran against core#1544's FIRST commit (038367b7), whose looser `checks = item.get("checks", [])` + falsy check tolerated the omitted key — a state that never shipped to dev; the CodeRabbit tightening landed in the same squashed PR. This is an evidence-shape correction on #5975's own not-yet-merged entry (append-only-safe: the entry does not exist on origin/dev, so validator_occ_append_only treats it as net-new and edits are unrestricted), not a validator weakening. onex_change_control's own contract_compliance_check._disclosed_skip_supersession_ids already defaults omitted checks to [] and was unaffected either way. Verified locally against the exact CI recipe (occ-preflight.yml): - validate_occ_merge_eligibility: eligible=True, reason=eligible (was: eligible=False, reason=missing_receipt) - validator_occ_append_only: ok=True, no violations - run_contract_compliance_check.py: 9/14 PASS, 5 WARN, 0 BLOCK - validate-yaml, pre-commit run --files contracts/OMN-15413.yaml: pass - tests/test_contract_compliance_check.py: 71 passed The retired AC6 false-PASS receipt and its tombstone supersession record are untouched. Evidence-Ticket: OMN-15413
jonahgabriel
added a commit
that referenced
this pull request
Aug 4, 2026
…est AC6 disclosure, fix AC3/AC2 pins (#5975) * evidence(OMN-15413): append-only entries restoring AC6 disclosure, AC3 unknown-stream pins, AC2 full scope Add-only supersession of three defects in contracts/OMN-15413.yaml. No landed line is edited; verified 135 additions / 0 deletions and zero per-entry hash drift against origin/dev for all 10 pre-existing entries. - dod-omn15413-ac6-disclosed-skip-restored: restores the disclosed skip that commit f6197f0 deleted inside open PR #5974, and records the substitute's three defects (always-true over merged #2557's frozen file list; fails open on gh error, demonstrated exit 0 on HTTP 404; falsely claims falsifiability via a route that cannot exist on a closed PR) plus the backdated receipt. - dod-omn15413-ac3-unknown-stream-pinned: the superseded entry pinned "unknown migration ledger shape" (a ledger TABLE-SHAPE guard) for the "unknown streams" bullet, leaving it unpinned. Pins the real unknown-STREAM literals at bootstrap.sql:165 and :202 and the manifest validator at :124. - dod-omn15413-ac2-idempotent-and-history-preserving: bullet 2 was narrowed to "deterministic and checksummed"; "idempotent" and "preserve applied history" were dropped without disclosure. Pins ON CONFLICT DO NOTHING, the already-applied short-circuit, and both twice-apply suites. Both new executable checks were run live: GREEN today, RED under control mutation, and fail CLOSED on gh error (the opposite of the AC6 substitute). Refs OMN-15413 * evidence(OMN-15413): bind supersession contract to OCC PR #5975 (self-bind stamp) Existential binding stamp only, mirroring occ-self-bind-pr-5945/5974. Adjudicates nothing about the OMN-15413 deliverable and flips no Linear status. Refs OMN-15413 * evidence(OMN-15413): net-new receipts + tombstone invalidating the always-true AC6 receipt Add-only. Three hash-bound PASS receipts from live check execution, plus a tombstone that removes the false-green AC6 receipt from resolution. The merged base receipt is left byte-for-byte intact. Receipts are provenance-coherent by construction — each contract_entry_sha256 was verified to resolve at the commit_sha its receipt names, the property the superseded receipt violates: ac3-unknown-stream-pinned 90223f5a @ 529f999 ac2-idempotent-and-history-preserving ca38880a @ 529f999 occ-self-bind-pr-5975 de5c6ed5 @ f6e46d1 Tombstone rationale (drift/.../dod-omn15413-ac6-no-live-migration-skip/ command.supersede.5975.yaml): no replacement is supplied because the honest form of this evidence is the ABSENCE of a check — bullet 6 is a universally- quantified negative over every live database. The restored disclosed skip is the contract entry dod-omn15413-ac6-disclosed-skip-restored. resolve_supersession confirms the AC6 key now resolves tombstoned=True, receipt=None; the three new keys resolve to their active base receipts. Refs OMN-15413, OMN-15664 * evidence(OMN-15413): mark the two defective entries superseded via evidence_artifact Uses the sanctioned contract-level supersession marker (evidence_artifact: supersedes_dod_evidence:<id>, contract_compliance_check.py _superseded_dod_ids) so the defective entries are preserved for audit but no longer re-executed or counted: dod-omn15413-ac6-no-live-migration-skip <- superseded by ac6-disclosed-skip-restored dod-omn15413-fail-closed-guards-on-dev <- superseded by ac3-unknown-stream-pinned This is the mechanism-level neutralization of the always-true AC6 check: it now resolves SUPERSEDED (WARN) instead of being re-executed to a false PASS. Refs OMN-15413, OMN-15664 * evidence(OMN-15413): rebind ac3 receipt after evidence_artifact changed its entry hash The supersession marker is part of the hashed per-entry payload, so adding evidence_artifact to dod-omn15413-ac3-unknown-stream-pinned moved its hash 90223f5a -> ce32d909. Receipt rebound to the new hash at commit 87fc319, where that entry exists — the provenance-coherence property the superseded AC6 receipt violates. ac2 and the self-bind hashes are unchanged, confirming per-entry hashing isolates appends. This file is net-new in this PR (absent at the merge base), not a landed receipt, so append-only is not implicated. Refs OMN-15413 * evidence(OMN-15413): r2 — coherent AC3 receipt run_timestamp, fix dangling supersede pointer Adversarial verify (15:32:31Z) FAILed this PR on three defects. Core repair untouched: AC3/AC2/self-bind check_values, statuses and entry hashes are byte-identical, and the diff against dev is still additions-only. (1) PROVENANCE — drift/dod_receipts/OMN-15413/dod-omn15413-ac3-unknown-stream-pinned/command.yaml recorded run_timestamp 2026-08-02T14:56:45Z against commit_sha 87fc319, whose committer timestamp is 2026-08-02T15:06:11Z — 566s of backdating, the same class this PR tombstones as DEFECT 4. The committed check_value was re-executed verbatim at 2026-08-02T18:04:49Z (exit 0) and run_timestamp now records that real run. PASS not re-graded, check_value unchanged, contract_entry_sha256 ce32d909f6 still resolves at 87fc319 and at head. The correction is disclosed in actual_output rather than made silently. This receipt is net-new in this PR (A, never merged), so no landed evidence is edited. (2) DANGLING POINTER — contract entry dod-omn15413-ac6-disclosed-skip-restored cited command.supersede.0001.yaml; the shipped tombstone is command.supersede.5975.yaml. Pointer corrected to the full path plus the NNNN-ordinal rationale (receipt_hashing_and_supersession.md section 4). Append-only re-proven on this tree: evaluate_append_only ok=True, zero violations; receipt diff vs origin/dev is 4x A and 0x M/D/R; all 10 pre-existing per-entry hashes recomputed with compute_contract_entry_sha256 = zero drift; zero lines matching ^-[^-]. Refs OMN-15413, OMN-15664. * evidence(OMN-15413): spell AC6 disclosed-skip checks as explicit [] (append-only) Root cause, reproduced against the exact occ-preflight CI invocation (module/args/env, core wheel built from origin/dev @5ad319b66b, which now includes core#1544/OMN-15664 AC5): omnibase_core.validation. validator_receipt_gate._honestly_superseded_dod_ids.is_disclosed_skip requires `checks == []` exactly (post-CodeRabbit hardening, commit a681b2bf on PR #1544 — `checks = item.get("checks")` with no default, so an omitted key resolves to None and `None == []` is False). The dod-omn15413-ac6-disclosed-skip-restored entry carried NO `checks` key at all, so the honesty exemption never fired and eligibility kept reporting missing_receipt on OMN-15413:dod-omn15413-ac6-no-live-migration-skip:command even after core#1544 merged to dev. The earlier local replay (wf_ea69bdbb-5e8) that reported eligible=True ran against core#1544's FIRST commit (038367b7), whose looser `checks = item.get("checks", [])` + falsy check tolerated the omitted key — a state that never shipped to dev; the CodeRabbit tightening landed in the same squashed PR. This is an evidence-shape correction on #5975's own not-yet-merged entry (append-only-safe: the entry does not exist on origin/dev, so validator_occ_append_only treats it as net-new and edits are unrestricted), not a validator weakening. onex_change_control's own contract_compliance_check._disclosed_skip_supersession_ids already defaults omitted checks to [] and was unaffected either way. Verified locally against the exact CI recipe (occ-preflight.yml): - validate_occ_merge_eligibility: eligible=True, reason=eligible (was: eligible=False, reason=missing_receipt) - validator_occ_append_only: ok=True, no violations - run_contract_compliance_check.py: 9/14 PASS, 5 WARN, 0 BLOCK - validate-yaml, pre-commit run --files contracts/OMN-15413.yaml: pass - tests/test_contract_compliance_check.py: 71 passed The retired AC6 false-PASS receipt and its tombstone supersession record are untouched. Evidence-Ticket: OMN-15413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes OMN-11932