[jonahgabriel]

Summary

• Adds contracts/OMN-10723.yaml for the omniclaude PR contracts(OMN-11932): add omnibase_core PR #1149 evidence #1544 that removes the silent inprocess delegation fallback and adds the no-inprocess-fallback-in-skills pre-commit gate.
• Contract required by verify / verify required status check on omniclaude PR contracts(OMN-11932): add omnibase_core PR #1149 evidence #1544.

Related

• omniclaude PR contracts(OMN-11932): add omnibase_core PR #1149 evidence #1544: fix(OMN-10723): remove silent inprocess fallback from delegation skill omniclaude#1544
• Ticket: OMN-10723

Summary by CodeRabbit

• Bug Fixes

  • Delegation now returns explicit errors instead of silently falling back to local in-process execution when local delegation is enforced.

• Chores

  • Added a formal contract and accompanying evidence record to document and enforce the new delegation behavior and required verification checks.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 346dd7ee-a932-4567-9926-d399d5b21b0f

📥 Commits

Reviewing files that changed from the base of the PR and between f941b0a and fa265fe.

📒 Files selected for processing (2)

• contracts/OMN-10723.yaml
• drift/dod_receipts/OMN-10723/dod-001/command.yaml

✅ Files skipped from review due to trivial changes (2)

• drift/dod_receipts/OMN-10723/dod-001/command.yaml
• contracts/OMN-10723.yaml

---

📝 Walkthrough

Walkthrough

This PR adds OMN-10723: a ticket contract YAML removing silent in-process fallback for delegation (force_local=True must error) and a DOD evidence command YAML recording the CI/PR probe outputs that verify the contract.

Changes

Contract Documentation

Layer / File(s)	Summary
Ticket Contract Definition contracts/OMN-10723.yaml	Defines OMN-10723 contract metadata, requires explicit error when force_local=True, lists required pytest evidence and a CI verification command, disables emergency_bypass, and includes DOD receipt grep assertions.
DOD Evidence Record drift/dod_receipts/OMN-10723/dod-001/command.yaml	Adds a check_type: command evidence record capturing PR probe inputs (gh pr view / gh pr checks), expected regex, exit_code, contract_sha256, pr_number, probe_stdout, and recorded actual_output strings showing PASS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped a careful, tiny hop,
A contract placed to stop the drop,
When local calls demand a ban,
Errors stand tall across the land,
CI nods, the rabbits clap—hip-hop!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: adding a ticket contract for the inprocess fallback removal (OMN-10723).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-10723-contract

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-10723.yaml`:
- Around line 24-31: Update the dod_evidence to include an additional DoD entry
(e.g., add id "dod-002") that explicitly verifies the pre-commit hook
no-inprocess-fallback-in-skills is defined and registered: add checks that (1)
the PR files or repository contain the hook implementation (search for a hooks
file name or the symbol no-inprocess-fallback-in-skills), (2) the
.pre-commit-config.yaml in the omniclaude repo lists/refs that hook, and (3) the
hook would block the fallback pattern (scope-proof by asserting the PR diff or
files include the hook definition/registration); implement these checks using gh
pr view (files or repo file content) and grep-style assertions similar to the
existing dod_evidence check for id "dod-001".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 197df76f-cd7b-4ce0-9dde-c947f12c16cb

📥 Commits

Reviewing files that changed from the base of the PR and between 50b3a05 and f941b0a.

📒 Files selected for processing (1)

• contracts/OMN-10723.yaml