Skip to content

evidence(OMN-11227): add phase budget receipts - #1149

Merged
jonahgabriel merged 4 commits into
mainfrom
jonah/omn-11227-phase-budget-occ-evidence
May 19, 2026
Merged

jonahgabriel merged 4 commits into
mainfrom
jonah/omn-11227-phase-budget-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds central OMN-11227 OCC contract and PASS receipts for omnibase_core#1109 phase budget and parallel-dispatch model evidence.

Evidence

Validation

  • PYTHONPATH=src uv run pytest tests/unit/models/overseer/test_phase_budget.py tests/unit/models/overseer/test_session_contract_unification.py tests/unit/models/overseer/test_phase_exit_condition.py tests/unit/models/overseer/test_overseer_model_imports.py -q
  • uv run validate-yaml contracts/OMN-11227.yaml
  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-11227.yaml
  • uv run python -m omnibase_core.validation.receipt_gate_cli --pr-title 'feat(OMN-11227): Add phase budget and parallel dispatch fields' --pr-body $'OMN-11227\nEvidence-Source: OCC#pending\nEvidence-Ticket: OMN-11227' --contracts-dir contracts --receipts-dir drift/dod_receipts

Summary by CodeRabbit

  • Chores
    • Added an OCC session contract and associated compliance receipts to record required verification steps.
    • Captured focused test runs and PR-check evidence showing PASS results and preserved run provenance (timestamps, commits, runner/verifier).
    • Included manual verification receipts and structured artifacts to support auditability and traceability of the change.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c5873cd-9bc7-4507-9e61-6b461f26bc04

📥 Commits

Reviewing files that changed from the base of the PR and between 227f47b and 556c63f.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml
✅ Files skipped from review due to trivial changes (1)
  • drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml

📝 Walkthrough

Walkthrough

Adds contract OMN-11227 marking an interface change to public APIs/protocols and includes five command-style DOD evidence receipts that record focused pytest runs, GitHub PR inspections, phase budget artifact queries, and product gate checks with PASS status and provenance metadata.

Changes

OMN-11227 Contract and Evidence Records

Layer / File(s) Summary
Contract metadata and evidence requirements
contracts/OMN-11227.yaml
Defines OMN-11227 as an interface change for public_api and protocols with schema/version/title, lists evidence_requirements (tests, manual, CI) including concrete probe commands, adds emergency_bypass disabled, and records dod_evidence entries that assert PASS and fixed values via grep patterns.
Evidence receipt artifacts
drift/dod_receipts/OMN-11227/dod-focused-overseer-tests/command.yaml, drift/dod_receipts/OMN-11227/dod-omnibase-core-pr-1109/command.yaml, drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml, drift/dod_receipts/OMN-11227/dod-product-gates/command.yaml, drift/dod_receipts/OMN-11227/dod-occ-pr/command.yaml
Adds five command.yaml receipts capturing executed probe commands (pytest invocations, gh pr view, PR checks/artifact queries), recorded probe_stdout, actual_output, status: PASS, exit_code: 0, run timestamps, commit_sha, pr_number/branch, and runner/verifier metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Beneath the branch the contract sits at rest,
Receipts whisper PASS, each SHA aligned and bright,
PRs and tests recorded, every check addressed,
The ledger closed, the rabbit hops into the night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding phase budget receipts for OMN-11227 evidence. It directly matches the core content of the PR (multiple receipt files and a contract for OMN-11227).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11227-phase-budget-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-11227/dod-occ-pr/command.yaml`:
- Around line 6-12: Decide whether this receipt should verify local git state or
GitHub PR metadata, then make check_value and probe_command identical: if intent
is local state, set check_value to "git status --short && git diff --name-only
--cached"; if intent is PR metadata, set probe_command to "gh pr view --repo
OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url";
update the corresponding field (check_value or probe_command) so the values
match exactly and keep the existing repo/JSON flags if you choose the PR path.

In `@drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml`:
- Around line 12-15: The probe output is missing the commits field requested by
probe_command's jq query (probe_command / --jq
'{...,commits:[.commits[].oid]}'), so update the jq expression to guarantee a
commits key even when there are no commits (e.g., use a safe/default expression
like .commits? // [] then map oids) or otherwise ensure probe_stdout includes
"commits":[] when empty, then re-run the probe to capture the corrected JSON;
reference probe_command and probe_stdout and adjust the jq clause that builds
commits to always emit a commits array.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b007980-fce4-45ee-90d6-63b1b4686501

📥 Commits

Reviewing files that changed from the base of the PR and between e252939 and 7f765c9.

📒 Files selected for processing (6)
  • contracts/OMN-11227.yaml
  • drift/dod_receipts/OMN-11227/dod-focused-overseer-tests/command.yaml
  • drift/dod_receipts/OMN-11227/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-11227/dod-omnibase-core-pr-1109/command.yaml
  • drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml
  • drift/dod_receipts/OMN-11227/dod-product-gates/command.yaml

Comment thread drift/dod_receipts/OMN-11227/dod-occ-pr/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml`:
- Line 6: The check_value and probe_command field lists are out of sync:
check_value currently requests "state" while probe_command does not, and
probe_command includes "commits" which check_value omits; update either
check_value or probe_command so they request the exact same GitHub PR JSON
fields (align check_value and probe_command to both include commits and state,
or remove state from check_value and add commits there) so probe_stdout will
contain the same fields referenced by check_value; refer to the check_value,
probe_command, and probe_stdout entries in the YAML when making the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9e49ccae-335a-4e54-b8cf-1968e574de41

📥 Commits

Reviewing files that changed from the base of the PR and between ce3f109 and 227f47b.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml

Comment thread drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml Outdated
@jonahgabriel
jonahgabriel merged commit ae992b7 into main May 19, 2026
33 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11227-phase-budget-occ-evidence branch May 19, 2026 13:26
jonahgabriel added a commit that referenced this pull request May 24, 2026
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants)
- Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb
- Records 10/10 unit tests passing for the new StrEnum constants
jonahgabriel added a commit that referenced this pull request May 24, 2026
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants)
- Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb
- Records 10/10 unit tests passing for the new StrEnum constants
jonahgabriel added a commit that referenced this pull request May 24, 2026
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants)
- Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb
- Records 10/10 unit tests passing for the new StrEnum constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant