Repository navigation
evidence(OMN-11227): add phase budget receipts - #1149
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds contract OMN-11227 marking an interface change to public APIs/protocols and includes five command-style DOD evidence receipts that record focused pytest runs, GitHub PR inspections, phase budget artifact queries, and product gate checks with PASS status and provenance metadata. ChangesOMN-11227 Contract and Evidence Records
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11227/dod-occ-pr/command.yaml`:
- Around line 6-12: Decide whether this receipt should verify local git state or
GitHub PR metadata, then make check_value and probe_command identical: if intent
is local state, set check_value to "git status --short && git diff --name-only
--cached"; if intent is PR metadata, set probe_command to "gh pr view --repo
OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url";
update the corresponding field (check_value or probe_command) so the values
match exactly and keep the existing repo/JSON flags if you choose the PR path.
In `@drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml`:
- Around line 12-15: The probe output is missing the commits field requested by
probe_command's jq query (probe_command / --jq
'{...,commits:[.commits[].oid]}'), so update the jq expression to guarantee a
commits key even when there are no commits (e.g., use a safe/default expression
like .commits? // [] then map oids) or otherwise ensure probe_stdout includes
"commits":[] when empty, then re-run the probe to capture the corrected JSON;
reference probe_command and probe_stdout and adjust the jq clause that builds
commits to always emit a commits array.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3b007980-fce4-45ee-90d6-63b1b4686501
📒 Files selected for processing (6)
contracts/OMN-11227.yamldrift/dod_receipts/OMN-11227/dod-focused-overseer-tests/command.yamldrift/dod_receipts/OMN-11227/dod-occ-pr/command.yamldrift/dod_receipts/OMN-11227/dod-omnibase-core-pr-1109/command.yamldrift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yamldrift/dod_receipts/OMN-11227/dod-product-gates/command.yaml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml`:
- Line 6: The check_value and probe_command field lists are out of sync:
check_value currently requests "state" while probe_command does not, and
probe_command includes "commits" which check_value omits; update either
check_value or probe_command so they request the exact same GitHub PR JSON
fields (align check_value and probe_command to both include commits and state,
or remove state from check_value and add commits there) so probe_stdout will
contain the same fields referenced by check_value; refer to the check_value,
probe_command, and probe_stdout entries in the YAML when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9e49ccae-335a-4e54-b8cf-1968e574de41
📒 Files selected for processing (1)
drift/dod_receipts/OMN-11227/dod-phase-budget-artifacts/command.yaml
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants) - Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb - Records 10/10 unit tests passing for the new StrEnum constants
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants) - Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb - Records 10/10 unit tests passing for the new StrEnum constants
- Adds OCC contract for OMN-11932 (typed LogicalModelKey/EndpointRef constants) - Binds omnibase_core PR #1149 at head fac7c2b9912ddf1ab1d196ef1a8980a820ce3acb - Records 10/10 unit tests passing for the new StrEnum constants
Summary
Adds central OMN-11227 OCC contract and PASS receipts for omnibase_core#1109 phase budget and parallel-dispatch model evidence.
Evidence
Validation
Summary by CodeRabbit