Repository navigation
evidence(OMN-12932): add node projection readiness receipts - #2442
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThis PR adds Definition of Done evidence contracts and verification records for two related tickets (OMN-12898 and OMN-12932). OMN-12898 receives a new dod_evidence entry with updated receipt hashes, while OMN-12932 is introduced as a new contract with comprehensive command evidence records validating projection-topic-readiness implementation, boundary constraints, mutation safety, and PR verification. ChangesOMN-12898 Evidence Extension
OMN-12932 Contract and Evidence
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Downstream product PR: OmniNode-ai/omnimarket#1149 This OCC PR is the Receipt Gate evidence source for the node-based projection readiness preflight added in omnimarket commit e969b3aad1cce39a10fd18ac3f1eb23227355e87. |
…N-20150.yaml
OMN-20150 has two product PRs autobound independently — omniclaude#2442 (landed
on dev as OCC#11949's window) and omnibase_infra#4357 (this window) — so both
windows minted contracts/OMN-20150.yaml and the add/add collided.
Resolved as the documented collision union, not a pick. The two files' header,
requirements block and all 13 criterion_hash / ac_bindings entries are
byte-identical (same ticket body, same autobind pass), so the union keeps that
block verbatim and concatenates only the per-PR halves:
evidence_requirements 2 -> 4 (ci + tests for each PR)
dod_evidence 4 -> 8 (autobind, ci, behaviour proof, self-bind
per PR; nothing edited, nothing removed)
Only `summary` is rewritten, to name both PRs instead of one.
Both #2442's items and #4357's items bind the same 13 ACs. That is two
independent proofs of one criterion set, which is what having two product PRs
on one ticket means; it is not a duplicate binding.
Gates run locally against origin/dev:
validator_occ_append_only OMN-20150, OMN-17292, OMN-13902, OMN-19384 — ok
check_contract_change_rebinds_receipts 5 touched entries, 2 tickets — ok
check_receipt_hardening changed files — ok
pre-commit (origin/dev..HEAD) 0 failed
The whole-file contract_sha256 on the eight receipts is now stale against the
union. That is out of scope by construction: the rebind gate grandfathers it
because any append by any lane invalidates it, and every per-entry
contract_entry_sha256 recomputes unchanged.
Claude-Session: https://claude.ai/code/session_01WNif1YXdzBpx5etNjVyyKa
Summary
contracts/OMN-12932.yamlfor the OMN-12898 node-based projection readiness preflight.node_projection_querywithprojection-topic-readiness.Verification
uv run validate-yaml contracts/OMN-12932.yamlgrep -q ^status: PASS$ drift/dod_receipts/OMN-12932/*/command.yamlDownstream
Summary by CodeRabbit