Skip to content

evidence(OMN-12932): add node projection readiness receipts - #2442

Merged
jonahgabriel merged 7 commits into
devfrom
jonah/omn-12932-node-projection-readiness-occ-dev
Jun 10, 2026
Merged

jonahgabriel merged 7 commits into
devfrom
jonah/omn-12932-node-projection-readiness-occ-dev

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds central OCC contract contracts/OMN-12932.yaml for the OMN-12898 node-based projection readiness preflight.
  • Adds DoD receipts for omnimarket PR evidence(OMN-11227): add phase budget receipts #1149, focused node tests, node-owned architecture boundary, no-runtime-mutation proof, and OCC self binding.
  • Keeps HTTP projection API classified as dashboard/browser edge transport; the acceptance proof path is node_projection_query with projection-topic-readiness.

Verification

  • uv run validate-yaml contracts/OMN-12932.yaml
  • grep -q ^status: PASS$ drift/dod_receipts/OMN-12932/*/command.yaml

Downstream

Summary by CodeRabbit

  • Chores
    • Added and updated verification evidence documentation for infrastructure tickets OMN-12898 and OMN-12932.
    • Evidence records confirm passing test suites and compliance checks across multiple verification points.
    • Updated contract metadata tracking to reflect current verification status.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2776d264-7ce4-4db6-a06a-6f2829272200

📥 Commits

Reviewing files that changed from the base of the PR and between 4b83d76 and a3c511b.

📒 Files selected for processing (14)
  • contracts/OMN-12898.yaml
  • contracts/OMN-12932.yaml
  • drift/dod_receipts/OMN-12898/dod-contract-topic-validator/command.yaml
  • drift/dod_receipts/OMN-12898/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-12898/dod-focused-tests/command.yaml
  • drift/dod_receipts/OMN-12898/dod-infra-pr-1929/command.yaml
  • drift/dod_receipts/OMN-12898/dod-marketplace-migration-drift-check/command.yaml
  • drift/dod_receipts/OMN-12898/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-12898/dod-omnimarket-pr-1149/command.yaml
  • drift/dod_receipts/OMN-12932/dod-focused-node-tests/command.yaml
  • drift/dod_receipts/OMN-12932/dod-no-runtime-mutation/command.yaml
  • drift/dod_receipts/OMN-12932/dod-node-owned-boundary/command.yaml
  • drift/dod_receipts/OMN-12932/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-12932/dod-omnimarket-pr-1149/command.yaml

📝 Walkthrough

Walkthrough

This PR adds Definition of Done evidence contracts and verification records for two related tickets (OMN-12898 and OMN-12932). OMN-12898 receives a new dod_evidence entry with updated receipt hashes, while OMN-12932 is introduced as a new contract with comprehensive command evidence records validating projection-topic-readiness implementation, boundary constraints, mutation safety, and PR verification.

Changes

OMN-12898 Evidence Extension

Layer / File(s) Summary
Contract evidence entry for PR verification
contracts/OMN-12898.yaml
New dod_evidence entry (dod-omnimarket-pr-1149) is added to document verification of omnimarket PR #1149 with passing command checks.
Evidence records and hash updates
drift/dod_receipts/OMN-12898/dod-omnimarket-pr-1149/command.yaml, drift/dod_receipts/OMN-12898/dod-*/command.yaml
New command evidence record added for dod-omnimarket-pr-1149 capturing pytest and ruff test execution results. Contract SHA256 hashes are updated across six existing evidence records (dod-contract-topic-validator, dod-deploy-assessment, dod-focused-tests, dod-infra-pr-1929, dod-marketplace-migration-drift-check, dod-occ-pr-self) to reflect current contract state.

OMN-12932 Contract and Evidence

Layer / File(s) Summary
Contract metadata and evidence structure
contracts/OMN-12932.yaml
New contract file defines OMN-12932 with schema version, metadata (title, summary), interface touches (public_api, protocols, topics), seam/interface flags, and disabled emergency bypass. Enumerates five dod_evidence entries with grep-based validation checks for expected PASS status in drift receipt paths.
Test coverage and PR verification evidence
drift/dod_receipts/OMN-12932/dod-focused-node-tests/command.yaml, drift/dod_receipts/OMN-12932/dod-omnimarket-pr-1149/command.yaml
Command evidence records document execution of focused golden-chain projection query tests and omnimarket PR #1149 verification, both concluding with status: PASS and captured pytest/ruff validation results.
Boundary and mutation validation evidence
drift/dod_receipts/OMN-12932/dod-node-owned-boundary/command.yaml, drift/dod_receipts/OMN-12932/dod-no-runtime-mutation/command.yaml
Command evidence records capture shell grep assertions that projection-topic-readiness shape is present, HTTP projection API calls are absent, has_table checks include the correct shape, and no runtime mutations occur during execution.
PR self-verification evidence
drift/dod_receipts/OMN-12932/dod-occ-pr-self/command.yaml
Command evidence record documents verification of GitHub PR #2442 (this PR) with GitHub CLI metadata retrieval and state validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#2046: Updates Drift DoD receipt command.yaml evidence with contract_sha256 field updates for OMN-12570, same pattern as main PR's evidence hash refreshes.
  • OmniNode-ai/onex_change_control#2014: Modifies drift/dod_receipts/**/command.yaml by updating contract_sha256 field from incorrect values to concrete digests, directly parallel to this PR's hash updates.
  • OmniNode-ai/onex_change_control#1300: Updates and introduces contract_sha256 field in DoD receipt evidence for OMN-11424, same evidence schema pattern as this PR.

Poem

🐰 A rabbit hops through evidence trails,
Documenting boundaries and projection tales,
With focused tests and greps precise,
OMN-12932 looks awfully nice,
DoD contracts spell out the truth—projection-ready in just one proof! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding node projection readiness receipts for ticket OMN-12932, which aligns with the primary objective of introducing DoD receipts and an OCC contract for the node-based projection readiness implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12932-node-projection-readiness-occ-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Downstream product PR: OmniNode-ai/omnimarket#1149

This OCC PR is the Receipt Gate evidence source for the node-based projection readiness preflight added in omnimarket commit e969b3aad1cce39a10fd18ac3f1eb23227355e87.

@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 10, 2026
Merged via the queue into dev with commit 7d08a85 Jun 10, 2026
36 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12932-node-projection-readiness-occ-dev branch June 10, 2026 20:09
jake-b-omni added a commit that referenced this pull request Sep 30, 2026
…N-20150.yaml

OMN-20150 has two product PRs autobound independently — omniclaude#2442 (landed
on dev as OCC#11949's window) and omnibase_infra#4357 (this window) — so both
windows minted contracts/OMN-20150.yaml and the add/add collided.

Resolved as the documented collision union, not a pick. The two files' header,
requirements block and all 13 criterion_hash / ac_bindings entries are
byte-identical (same ticket body, same autobind pass), so the union keeps that
block verbatim and concatenates only the per-PR halves:

  evidence_requirements  2 -> 4  (ci + tests for each PR)
  dod_evidence           4 -> 8  (autobind, ci, behaviour proof, self-bind
                                  per PR; nothing edited, nothing removed)

Only `summary` is rewritten, to name both PRs instead of one.

Both #2442's items and #4357's items bind the same 13 ACs. That is two
independent proofs of one criterion set, which is what having two product PRs
on one ticket means; it is not a duplicate binding.

Gates run locally against origin/dev:
  validator_occ_append_only          OMN-20150, OMN-17292, OMN-13902, OMN-19384 — ok
  check_contract_change_rebinds_receipts  5 touched entries, 2 tickets — ok
  check_receipt_hardening            changed files — ok
  pre-commit (origin/dev..HEAD)      0 failed

The whole-file contract_sha256 on the eight receipts is now stale against the
union. That is out of scope by construction: the rebind gate grandfathers it
because any append by any lane invalidates it, and every per-entry
contract_entry_sha256 recomputes unchanged.

Claude-Session: https://claude.ai/code/session_01WNif1YXdzBpx5etNjVyyKa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant