Repository navigation
docs(OMN-10530): add rollback checkpoint release evidence - #693
Conversation
📝 WalkthroughWalkthroughAdds a non-seam contract ChangesRollback Checkpoint Release Contract & Evidence
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
contracts/OMN-10530.yaml (1)
34-35: ⚡ Quick winTighten provenance binding for
dod-core-version-smoke.Line 34–35 verifies PASS + version text, but not the source PR. Adding a
pr_number: 1030assertion (likedod-core-build) reduces evidence mix-up risk when multiple PRs target the same version string.Proposed change
- check_value: "grep -q 'status: PASS' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml - && grep -q 'omnibase-core 0.40.1' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml" + check_value: "grep -q 'status: PASS' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml + && grep -q 'omnibase-core 0.40.1' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml + && grep -q 'pr_number: 1030' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml"Also mirror this same
check_valueupdate in:
drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml(Line 6–7).Based on learnings: For cross-repo DoD receipts, provenance should identify the external PR scope being attested.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@contracts/OMN-10530.yaml` around lines 34 - 35, The check_value for the dod-core-version-smoke receipt currently only asserts PASS and the version string; tighten provenance by adding a pr_number assertion (pr_number: 1030) into the check_value so it verifies PASS, the exact version text and pr_number: 1030; make the same update to the check_value entry inside the dod-core-version-smoke command.yaml to keep both the contract and its generated receipt aligned.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@contracts/OMN-10530.yaml`:
- Around line 34-35: The check_value for the dod-core-version-smoke receipt
currently only asserts PASS and the version string; tighten provenance by adding
a pr_number assertion (pr_number: 1030) into the check_value so it verifies
PASS, the exact version text and pr_number: 1030; make the same update to the
check_value entry inside the dod-core-version-smoke command.yaml to keep both
the contract and its generated receipt aligned.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5537bc14-d97f-48f6-a37f-bc8c95beda7b
📒 Files selected for processing (5)
contracts/OMN-10530.yamldrift/dod_receipts/OMN-10530/dod-core-build/command.yamldrift/dod_receipts/OMN-10530/dod-core-diff-check/command.yamldrift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yamldrift/dod_receipts/OMN-10530/dod-occ-evidence-validate/command.yaml
✅ Files skipped from review due to trivial changes (2)
- drift/dod_receipts/OMN-10530/dod-core-diff-check/command.yaml
- drift/dod_receipts/OMN-10530/dod-core-build/command.yaml
…pt schema Receipts previously used a custom flat schema with fields like evidence_id, description, repo, command, output, recorded_at which fail ModelDodReceipt Pydantic validation (15 errors per receipt). Rewrites all 6 receipts to use the canonical schema with schema_version, evidence_item_id, check_type, check_value, run_timestamp, runner, verifier, probe_command, probe_stdout. Updates commit_sha from stale 723e68ce to live omnimarket #693 head eed1dc53 (verified live via gh pr view) and propagates to contract grep patterns. Adds dod-occ-pr-1113 self-binding receipts for both tickets so receipt-gate pr_ticket_mismatch resolves.
… 2 (#1113) * feat(OMN-10872,OMN-10873): add OCC contracts and dod receipts for DI Wave 2 Contracts for HandlerNavigationHistoryReducer protocol injection seam (OMN-10872) and NodeOverseerBenchmarker harness injection seam (OMN-10873). Both are seam tickets with unit-test and PR-merge evidence. omnimarket PR: OmniNode-ai/omnimarket#693 * fix(OMN-10872,OMN-10873): add dod-deploy receipts, pin commit SHA in all receipts * fix(OMN-10872,OMN-10873): fix receipts — accurate PR state, add commit_sha, add repo fields * fix(OMN-10872,OMN-10873): rewrite receipts to canonical ModelDodReceipt schema Receipts previously used a custom flat schema with fields like evidence_id, description, repo, command, output, recorded_at which fail ModelDodReceipt Pydantic validation (15 errors per receipt). Rewrites all 6 receipts to use the canonical schema with schema_version, evidence_item_id, check_type, check_value, run_timestamp, runner, verifier, probe_command, probe_stdout. Updates commit_sha from stale 723e68ce to live omnimarket #693 head eed1dc53 (verified live via gh pr view) and propagates to contract grep patterns. Adds dod-occ-pr-1113 self-binding receipts for both tickets so receipt-gate pr_ticket_mismatch resolves. * chore: retrigger CI with updated PR body (Evidence-Ticket lines) * chore: reset stale CodeRabbit Thread Check rollup * fix(OMN-10872): clarify cross-repo provenance in dod-unit-tests-pass receipt CodeRabbit flagged that actual_output claimed tests ran in omnimarket but working_dir pointed to onex_change_control. Added pr_repo field and clarified that OCC is the canonical evidence registry while execution happened in the omnimarket worktree. * fix(OMN-10872): restore schema-compliant receipt fields Previous fix added pr_repo (rejected by ModelDodReceipt as extra field) and made working_dir a free-text string (schema requires absolute path). Restore schema compliance: working_dir back to absolute omnimarket worktree path, cross-repo provenance documented in actual_output instead.
Summary
Verification
Summary by CodeRabbit