Skip to content

docs(OMN-10530): add rollback checkpoint release evidence - #693

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10530-release-checkpoint-evidence
May 4, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10530-release-checkpoint-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add OCC contract for the rollback checkpoint PyPI patch release chain
  • add PASS receipts for the omnibase-core 0.40.1 version bump verification

Verification

  • uv run validate-yaml contracts/OMN-10530.yaml
  • uv run python -m omnibase_core.validation.receipt_gate_cli --pr-body '' --pr-title 'docs(OMN-10530): add rollback checkpoint release evidence' --contracts-dir contracts --receipts-dir drift/dod_receipts --current-repo onex_change_control --current-pr-number 0
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Added release verification records for a patch rollback checkpoint: local build artifact confirmation, package version smoke check, whitespace/diff validation, and a receipt-gate validation run that passed all required checks.

@coderabbitai

coderabbitai Bot commented May 3, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Adds a non-seam contract contracts/OMN-10530.yaml and four DoD receipt records under drift/dod_receipts/OMN-10530/ capturing PASS evidence for build, version smoke, git-diff whitespace check, and local receipt-gate validation for omnibase-core v0.40.1.

Changes

Rollback Checkpoint Release Contract & Evidence

Layer / File(s) Summary
Contract Definition
contracts/OMN-10530.yaml
New non-seam ticket contract (OMN-10530) with no interface changes, evidence requirements (gh pr checks, uv build), emergency_bypass: enabled: false, and DoD entries for build, version smoke, diff check, and receipt validation.
Build Evidence
drift/dod_receipts/OMN-10530/dod-core-build/command.yaml
Recorded uv build probe result: status: PASS, exit_code: 0, pr_number: 1030, and probe_stdout showing sdist/wheel artifacts for omnibase_core-0.40.1.
Version Smoke Evidence
drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml
Recorded Python probe asserting package/version (importlib.metadata.version('omnibase-core') and omnibase_core.__version__) equals 0.40.1, with status: PASS, exit_code: 0, and probe_stdout: version-smoke: omnibase-core 0.40.1.
Diff Check Evidence
drift/dod_receipts/OMN-10530/dod-core-diff-check/command.yaml
Recorded git diff --check probe with status: PASS, exit_code: 0, and captured stdout/actual_output indicating no whitespace errors.
Receipt-Gate Validation
drift/dod_receipts/OMN-10530/dod-occ-evidence-validate/command.yaml
Recorded contract/receipt validation using uv run validate-yaml contracts/OMN-10530.yaml and omnibase_core.validation.receipt_gate_cli with --current-pr-number 693; status: PASS, exit_code: 0, and ::notice::RECEIPT GATE PASSED: 4 check(s) across 1 ticket(s) all have PASS receipts. in probe_stdout.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I scoped the rollback, light and quick,
built the wheel and ran the trick.
Versions checked and diffs all clear,
receipts agreed — the path is near. 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs(OMN-10530): add rollback checkpoint release evidence' directly and clearly summarizes the main change—adding release evidence documentation and verification receipts for ticket OMN-10530.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10530-release-checkpoint-evidence

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 3, 2026 23:43

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
contracts/OMN-10530.yaml (1)

34-35: ⚡ Quick win

Tighten provenance binding for dod-core-version-smoke.

Line 34–35 verifies PASS + version text, but not the source PR. Adding a pr_number: 1030 assertion (like dod-core-build) reduces evidence mix-up risk when multiple PRs target the same version string.

Proposed change
-        check_value: "grep -q 'status: PASS' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml
-          && grep -q 'omnibase-core 0.40.1' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml"
+        check_value: "grep -q 'status: PASS' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml
+          && grep -q 'omnibase-core 0.40.1' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml
+          && grep -q 'pr_number: 1030' drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml"

Also mirror this same check_value update in:
drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml (Line 6–7).

Based on learnings: For cross-repo DoD receipts, provenance should identify the external PR scope being attested.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@contracts/OMN-10530.yaml` around lines 34 - 35, The check_value for the
dod-core-version-smoke receipt currently only asserts PASS and the version
string; tighten provenance by adding a pr_number assertion (pr_number: 1030)
into the check_value so it verifies PASS, the exact version text and pr_number:
1030; make the same update to the check_value entry inside the
dod-core-version-smoke command.yaml to keep both the contract and its generated
receipt aligned.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@contracts/OMN-10530.yaml`:
- Around line 34-35: The check_value for the dod-core-version-smoke receipt
currently only asserts PASS and the version string; tighten provenance by adding
a pr_number assertion (pr_number: 1030) into the check_value so it verifies
PASS, the exact version text and pr_number: 1030; make the same update to the
check_value entry inside the dod-core-version-smoke command.yaml to keep both
the contract and its generated receipt aligned.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5537bc14-d97f-48f6-a37f-bc8c95beda7b

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc3f9c and 42001e1.

📒 Files selected for processing (5)
  • contracts/OMN-10530.yaml
  • drift/dod_receipts/OMN-10530/dod-core-build/command.yaml
  • drift/dod_receipts/OMN-10530/dod-core-diff-check/command.yaml
  • drift/dod_receipts/OMN-10530/dod-core-version-smoke/command.yaml
  • drift/dod_receipts/OMN-10530/dod-occ-evidence-validate/command.yaml
✅ Files skipped from review due to trivial changes (2)
  • drift/dod_receipts/OMN-10530/dod-core-diff-check/command.yaml
  • drift/dod_receipts/OMN-10530/dod-core-build/command.yaml

@jonahgabriel
jonahgabriel added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit f4094a2 May 4, 2026
30 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10530-release-checkpoint-evidence branch May 4, 2026 00:43
jonahgabriel added a commit that referenced this pull request May 18, 2026
…pt schema

Receipts previously used a custom flat schema with fields like evidence_id,
description, repo, command, output, recorded_at which fail ModelDodReceipt
Pydantic validation (15 errors per receipt). Rewrites all 6 receipts to use
the canonical schema with schema_version, evidence_item_id, check_type,
check_value, run_timestamp, runner, verifier, probe_command, probe_stdout.

Updates commit_sha from stale 723e68ce to live omnimarket #693 head
eed1dc53 (verified live via gh pr view) and propagates to contract grep
patterns.

Adds dod-occ-pr-1113 self-binding receipts for both tickets so
receipt-gate pr_ticket_mismatch resolves.
jonahgabriel added a commit that referenced this pull request May 18, 2026
… 2 (#1113)

* feat(OMN-10872,OMN-10873): add OCC contracts and dod receipts for DI Wave 2

Contracts for HandlerNavigationHistoryReducer protocol injection seam
(OMN-10872) and NodeOverseerBenchmarker harness injection seam (OMN-10873).
Both are seam tickets with unit-test and PR-merge evidence.
omnimarket PR: OmniNode-ai/omnimarket#693

* fix(OMN-10872,OMN-10873): add dod-deploy receipts, pin commit SHA in all receipts

* fix(OMN-10872,OMN-10873): fix receipts — accurate PR state, add commit_sha, add repo fields

* fix(OMN-10872,OMN-10873): rewrite receipts to canonical ModelDodReceipt schema

Receipts previously used a custom flat schema with fields like evidence_id,
description, repo, command, output, recorded_at which fail ModelDodReceipt
Pydantic validation (15 errors per receipt). Rewrites all 6 receipts to use
the canonical schema with schema_version, evidence_item_id, check_type,
check_value, run_timestamp, runner, verifier, probe_command, probe_stdout.

Updates commit_sha from stale 723e68ce to live omnimarket #693 head
eed1dc53 (verified live via gh pr view) and propagates to contract grep
patterns.

Adds dod-occ-pr-1113 self-binding receipts for both tickets so
receipt-gate pr_ticket_mismatch resolves.

* chore: retrigger CI with updated PR body (Evidence-Ticket lines)

* chore: reset stale CodeRabbit Thread Check rollup

* fix(OMN-10872): clarify cross-repo provenance in dod-unit-tests-pass receipt

CodeRabbit flagged that actual_output claimed tests ran in omnimarket but
working_dir pointed to onex_change_control. Added pr_repo field and
clarified that OCC is the canonical evidence registry while execution
happened in the omnimarket worktree.

* fix(OMN-10872): restore schema-compliant receipt fields

Previous fix added pr_repo (rejected by ModelDodReceipt as extra field) and
made working_dir a free-text string (schema requires absolute path). Restore
schema compliance: working_dir back to absolute omnimarket worktree path,
cross-repo provenance documented in actual_output instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant