Skip to content

OMN-3903: add infisical_folders check (#12) to system_health_check.sh - #694

Merged
jonahgabriel merged 1 commit into
mainfrom
jonahgabriel/omn-3903-system_health_checksh-infisical-folder-completeness-check
Mar 8, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonahgabriel/omn-3903-system_health_checksh-infisical-folder-completeness-check

Conversation

@jonahgabriel

Copy link
Copy Markdown
Collaborator

Summary

Adds check_infisical_folders() as check #12 to system_health_check.sh. Verifies /shared/<transport>/ folders exist in Infisical for baseline transport types after seeding (OMN-3898 dependency — already merged).

What changed

  • scripts/system_health_check.sh: new check_infisical_folders() function + call in run section + header comment updated

Behavior

Condition Status
INFISICAL_ADDR not set SKIP — secrets profile not active, silently skipped
Infisical not reachable YELLOW — advisory, not a hard failure
Auth vars missing YELLOW — advisory
db folder missing (Infisical running) RED — core infra failure
Advisory folders missing (kafka/http/filesystem/graph/mcp) YELLOW — advisory
All 6 baseline folders present GREEN

Implementation notes

  • Auth: POST /api/v1/auth/universal-auth/login with INFISICAL_CLIENT_ID/SECRET
  • Query: GET /api/v1/folders?workspaceId=...&environment=prod&path=/shared/
  • No jq dependency — uses grep + sed for JSON parsing
  • 5-second timeouts on all API calls (matches existing check timeouts)
  • Folder names sourced from EnumInfraTransportType.value slugs

Testing

# When INFISICAL_ADDR not set (default):
$ bash scripts/system_health_check.sh --verbose
  [SKIP]   infisical_folders      INFISICAL_ADDR not set (secrets profile not active)

# With Infisical running and seeded: GREEN (all 6 folders present)
# With db folder missing: RED
# With only advisory folders missing: YELLOW

Depends on

Fixes: OMN-3903

Adds check_infisical_folders() as check #12. Verifies /shared/<transport>/
folders exist in Infisical after seeding. Only runs when INFISICAL_ADDR is
set and Infisical is reachable; gracefully skips otherwise.

- RED when db folder missing (core infrastructure)
- YELLOW when Infisical not running, auth vars missing, or advisory
  folders (kafka, http, filesystem, graph, mcp) absent
- GREEN when all 6 baseline folders present
- SKIP when INFISICAL_ADDR is unset (secrets profile not active)

Uses curl + grep/sed only (no jq dependency). Auth via universal-auth login
with INFISICAL_CLIENT_ID/SECRET. 5-second timeouts on all API calls.
@jonahgabriel
jonahgabriel enabled auto-merge March 8, 2026 19:38
@coderabbitai

coderabbitai Bot commented Mar 8, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 92958aba-9096-4d6c-9a75-0eeab81ded01

📥 Commits

Reviewing files that changed from the base of the PR and between 140296b and 68e138a.

📒 Files selected for processing (1)
  • scripts/system_health_check.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jonahgabriel/omn-3903-system_health_checksh-infisical-folder-completeness-check

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel added this pull request to the merge queue Mar 8, 2026
Merged via the queue into main with commit d9508a2 Mar 8, 2026
26 checks passed
@jonahgabriel
jonahgabriel deleted the jonahgabriel/omn-3903-system_health_checksh-infisical-folder-completeness-check branch March 8, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant