Repository navigation
OMN-3898: re-seed Infisical and verify transport folders - #689
Merged
Conversation
… folders Re-seed run after OMN-3893 prefetch contract scan decoupling. Confirms 24 keys created across /shared/db, /shared/http, /shared/filesystem, /shared/mcp, /shared/graph, and /shared/env. Documents prerequisite folder creation for prod/staging environments and provision-infisical.py idempotency gap.
jonahgabriel
deleted the
jonahgabriel/omn-3898-re-seed-infisical-and-verify-transport-folders
branch
March 8, 2026 19:04
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 8, 2026
…#683) * OMN-3893: decouple prefetch contract scan from handler contract paths The prefetch code previously used self._contract_paths (handler contracts at /app/contracts) as the scan source, which found no transport_type entries and skipped Infisical entirely. Now prefetch always derives the scan path from the omnibase_infra package root via import, with an ONEX_NODE_CONTRACTS_DIR env var escape hatch for custom deployments. Also adds _config_prefetch_status attribute with 5-state vocabulary (pending/skipped/ok/degraded_no_requirements/degraded_error) to enable future health endpoint exposure. * OMN-3898: document Infisical seed verification and verified transport folders (#689) Re-seed run after OMN-3893 prefetch contract scan decoupling. Confirms 24 keys created across /shared/db, /shared/http, /shared/filesystem, /shared/mcp, /shared/graph, and /shared/env. Documents prerequisite folder creation for prod/staging environments and provision-infisical.py idempotency gap. * fix(OMN-3893): address CodeRabbit MAJOR review findings - Check requirements.errors after extract_from_paths(); set degraded_error (not degraded_no_requirements) when extraction errors are present, propagating extraction_had_errors into the final status - Add ModelInfraErrorContext.with_correlation() to prefetch except block so degraded_error state is traceable via correlation_id in the warning - Update test mocks to set requirements.errors = () so degraded_no_requirements and ok paths are not polluted by truthy MagicMock attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operational verification step after OMN-3893 (PR #683) decoupled prefetch contract scanning.
seed-infisical.pyagainst the OMN-3893 branch — 24 keys created, 0 errorsprodenvironmentprod/stagingenvironments had no folder structure (provision-infisical.py short-circuits when credentials already set); created folders via APIprovision-infisical.pyfor follow-upContract Discovery (OMN-3893 validation)
Verified Folder Structure (prod)
/shared/db,/shared/http,/shared/filesystem,/shared/graph,/shared/mcp,/shared/env,/shared/kafka,/shared/consul,/shared/vault,/shared/qdrant,/shared/authDefinition of Done
/shared/db/folder exists with 7 keys/shared/kafka/folder exists (empty — no Kafka contracts in current scope)/shared/http/folder exists with 3 keys/shared/filesystem/folder exists with 1 keyNotes
jonah/omn-3893-decouple-prefetch-contract-scan(PR OMN-3893: decouple prefetch contract scan from handler contract paths #683); merge after OMN-3893 landsvalidate-string-versionshook referencesv0.24.0tag not yet released — pre-existing issue in main branch, not introduced here