feat: Infrastructure Domain Models with Service Integration Architecture by jonahgabriel · Pull Request #12 · OmniNode-ai/omnibase_infra

jonahgabriel · 2025-09-18T14:37:28Z

Infrastructure Domain Models Implementation

This PR implements the infrastructure domain models with comprehensive service integration architecture following ONEX standards.

Files Changed: 61 infrastructure models

Service Integration Architecture

Consul Service Discovery (11 models):

Service registration and health monitoring
KV store operations and status tracking
Node health assessment and service listings

Kafka Message Broker (12 models):

Producer/consumer configuration with security
Message payload and delivery handling
SASL, SSL, and security configurations

PostgreSQL Database (24 models):

Connection pooling and health monitoring
Query execution with performance metrics
Database schema and error handling

Distributed Tracing (4 models):

Event envelope and span data
Parent context and trace configuration

Key Improvements

Zero Any types - All models use specific types
Service-specific models - Organized by infrastructure service
Security configurations - Comprehensive security model coverage
Performance metrics - Built-in observability patterns
Protocol compliance - Ready for protocol-based health architecture

Migration Status

This PR is part of the domain-based migration strategy:

Archive separation (PR Archive legacy codebase for clean migration #10) - merged
Core domain models (PR Core Domain Models: Protocol-Based Health Architecture #11) - created
Infrastructure domain models (this PR)
Integration domain models (next)
Enums & shared models (next)
Tests & configuration (final)

Ready for review and merge to continue clean domain-based migration.

Implement infrastructure domain models for service integration and operational management: ### 🔧 Infrastructure Service Models (56 files) #### **Consul Service Discovery Models** - Service registration, health check, and discovery models - Key-value store request/response models with strong typing - Service info, status tracking, and health monitoring - URL configuration and service list management models #### **Kafka Message Broker Models** - Producer/consumer configuration with security support - Message and payload models with envelope patterns - Topic configuration and override management - Producer pool statistics and entry tracking - SASL and SSL security configuration models - Health response models for broker monitoring #### **PostgreSQL Database Models** - Connection configuration and pool management models - Query request/response with typed parameters and results - Database health monitoring and performance metrics - Schema information and connection statistics - Error handling models with context preservation - Query data models with row and value structures - Connection pool health and database health models #### **Distributed Tracing Models** - Event envelope models for distributed system tracing - Span data, attributes, and context models - Parent context tracking for distributed operations - Trace configuration and request/response models - OpenTelemetry-compatible tracing infrastructure ### ✅ **ONEX Infrastructure Compliance** - **Service Integration Focus**: Models designed for external service adapters - **Strong Typing**: UUID fields, typed enums, specific field types throughout - **One Model Per File**: Clean separation following ONEX standards - **Security-First**: Comprehensive security configuration models - **Health Monitoring**: Built-in health check capabilities for all services - **Performance Tracking**: Metrics and monitoring models integrated ### 🔗 **Service Integration Architecture** - **Consul Integration**: Complete service discovery and configuration models - **Kafka Integration**: Full message broker interaction support - **PostgreSQL Integration**: Comprehensive database operation models - **Tracing Integration**: End-to-end distributed tracing capabilities ### 📊 **Operational Features** - **Connection Pooling**: Models supporting efficient connection management - **Health Monitoring**: Service-specific health check and metrics models - **Security Configuration**: SSL, SASL, and authentication models - **Performance Metrics**: Query metrics, connection stats, producer pool tracking - **Error Handling**: Comprehensive error models with context preservation This infrastructure domain provides the foundation for external service integration in the ONEX infrastructure system, with models supporting Consul, Kafka, PostgreSQL, and distributed tracing operations.

github-actions · 2025-09-18T14:42:15Z

🔍 Code Review for PR #12: Infrastructure Domain Models

Executive Summary

This PR adds 61 new infrastructure domain model files with exceptional adherence to ONEX patterns. The implementation shows perfect compliance with zero-tolerance policies (no Any types) and strong typing requirements.

✅ Strengths

ONEX Compliance - EXCELLENT

✅ ZERO Any types found - Complete adherence to ONEX zero-tolerance policy
✅ All Pydantic models with proper BaseModel inheritance
✅ CamelCase classes, snake_case files, one model per file
✅ All omnibase_core imports - No legacy omnibase. imports
✅ Protocol-based duck typing in ModelPostgresQueryParameter

Code Quality

Comprehensive field validation with constraints (ge=0, le=100, max_length)
Excellent documentation with clear docstrings
Thoughtful design with calculated metrics and health monitoring

⚠️ Issues to Address

1. CRITICAL: Directory Structure Duplication

Duplicate model directories exist that violate DRY principles:

/models/kafka/ AND /models/infrastructure/kafka/
/models/postgres/ AND /models/infrastructure/postgres/
/models/tracing/ AND /models/infrastructure/tracing/

Action: Consolidate to single shared models directory per service.

2. Type Safety: Generic `object` Return Type

In model_postgres_query_parameter.py:

def get_value(self) -> object | None:  # Too generic

Action: Use specific union type: str | int | float | bool | None

3. Missing init.py Exports

Many __init__.py files lack proper exports.
Action: Add exports following the pattern in /models/kafka/__init__.py

🧪 Test Coverage Recommendations

Add model validation tests for all new models
Test protocol-based duck typing in ModelPostgresQueryParameter
Test calculated metrics in ModelKafkaProducerPoolStats
Test edge cases for field constraints

🔒 Security Assessment

Strengths:

No hardcoded credentials
Proper field validation prevents injection
Size constraints prevent resource exhaustion

Recommendation: Add max_items constraints to all list fields

📊 Overall Rating

Category	Rating	Notes
ONEX Compliance	⭐⭐⭐⭐⭐	Perfect - Zero Any types, proper imports
Code Quality	⭐⭐⭐⭐☆	Excellent with minor issues
Documentation	⭐⭐⭐⭐⭐	Comprehensive docstrings
Type Safety	⭐⭐⭐⭐☆	Strong, but `object` return needs fixing
Architecture	⭐⭐⭐☆☆	Good, but directory duplication issue

🎯 Required Before Merge

Resolve directory duplication - Consolidate duplicate model directories
Fix object return type - Use specific union types
Add missing __init__.py exports - Enable clean imports

🏆 Commendations

This PR demonstrates exceptional adherence to ONEX infrastructure patterns with perfect zero-tolerance compliance and excellent protocol-based design. The implementation quality is very high and shows deep understanding of ONEX principles.

With the structural issues resolved, this will be an excellent addition to the infrastructure domain models. Great work on maintaining strong typing throughout! 🚀

Adds check_infisical_folders() as check #12. Verifies /shared/<transport>/ folders exist in Infisical after seeding. Only runs when INFISICAL_ADDR is set and Infisical is reachable; gracefully skips otherwise. - RED when db folder missing (core infrastructure) - YELLOW when Infisical not running, auth vars missing, or advisory folders (kafka, http, filesystem, graph, mcp) absent - GREEN when all 6 baseline folders present - SKIP when INFISICAL_ADDR is unset (secrets profile not active) Uses curl + grep/sed only (no jq dependency). Auth via universal-auth login with INFISICAL_CLIENT_ID/SECRET. 5-second timeouts on all API calls.

…#694) Adds check_infisical_folders() as check #12. Verifies /shared/<transport>/ folders exist in Infisical after seeding. Only runs when INFISICAL_ADDR is set and Infisical is reachable; gracefully skips otherwise. - RED when db folder missing (core infrastructure) - YELLOW when Infisical not running, auth vars missing, or advisory folders (kafka, http, filesystem, graph, mcp) absent - GREEN when all 6 baseline folders present - SKIP when INFISICAL_ADDR is unset (secrets profile not active) Uses curl + grep/sed only (no jq dependency). Auth via universal-auth login with INFISICAL_CLIENT_ID/SECRET. 5-second timeouts on all API calls.

jonahgabriel mentioned this pull request Sep 18, 2025

feat: Integration Domain Models for External Service Connectivity #13

Closed

This was referenced Sep 18, 2025

feat: Enums and Shared Infrastructure Components #14

Closed

feat: Comprehensive Tests, Configuration, and Development Infrastructure #15

Closed

jonahgabriel closed this Nov 5, 2025

jonahgabriel deleted the feature/infrastructure-models-migration branch November 5, 2025 20:03

This was referenced Dec 25, 2025

feat(dlq): configure DLQ for permanently failing intents [OMN-949] #90

Merged

feat(orchestrator): implement registration orchestrator node [C1] #79

Merged

test(e2e): implement 2-way registration E2E integration tests [OMN-892] #101

Merged

jonahgabriel mentioned this pull request Mar 8, 2026

OMN-3903: add infisical_folders check (#12) to system_health_check.sh #694

Merged

Navigation Menu

Repository navigation

feat: Infrastructure Domain Models with Service Integration Architecture - #12

feat: Infrastructure Domain Models with Service Integration Architecture#12
jonahgabriel wants to merge 1 commit into
mainfrom
feature/infrastructure-models-migration

jonahgabriel commented Sep 18, 2025

Uh oh!

github-actions Bot commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonahgabriel commented Sep 18, 2025

Infrastructure Domain Models Implementation

Files Changed: 61 infrastructure models

Service Integration Architecture

Key Improvements

Migration Status

Uh oh!

github-actions Bot commented Sep 18, 2025

🔍 Code Review for PR #12: Infrastructure Domain Models

Executive Summary

✅ Strengths

ONEX Compliance - EXCELLENT

Code Quality

⚠️ Issues to Address

1. CRITICAL: Directory Structure Duplication

2. Type Safety: Generic object Return Type

3. Missing init.py Exports

🧪 Test Coverage Recommendations

🔒 Security Assessment

📊 Overall Rating

🎯 Required Before Merge

🏆 Commendations

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

2. Type Safety: Generic `object` Return Type