feat: Integration Domain Models for External Service Connectivity

[jonahgabriel]

Integration Domain Models Implementation

This PR implements the integration domain models providing standardized interfaces for external service connectivity following ONEX architecture.

Files Changed: 11 integration models

Integration Services Architecture

Notification Systems (5 models):

• Generic notification handling with retry policies
• Authentication models for secure integrations
• Result tracking and attempt logging
• Exponential backoff retry mechanisms

Slack Integration (4 models):

• Rich message formatting with attachments
• Webhook configuration and payload handling
• Field-based message structure
• Priority-based notification routing

Webhook Systems (1 model):

• Generic webhook payload handling
• Flexible external service integration

Key Features

• 11 integration models for external service connectivity
• Notification retry policies with exponential backoff
• Slack webhook configuration and message formatting
• Generic webhook payload handling
• Authentication models for secure integrations
• Comprehensive error handling and result tracking

Model Organization

Integration models organized by service type:

• notification/ - Generic notification system (5 models)
• slack/ - Slack messaging integration (4 models)
• webhook/ - Generic webhook handling (1 model)

ONEX Compliance

• Zero Any types throughout all models
• One model per file architecture
• Strong typing with Pydantic validation
• CamelCase model naming with snake_case files
• Protocol-ready for dependency injection

Migration Status

This PR is part of the domain-based migration strategy:

• Archive separation (PR Archive legacy codebase for clean migration #10) - merged
• Core domain models (PR Core Domain Models: Protocol-Based Health Architecture #11) - created
• Infrastructure domain models (PR feat: Infrastructure Domain Models with Service Integration Architecture #12) - created
• Integration domain models (this PR)
• Enums & shared models (next)
• Tests & configuration (final)

Ready for review and merge to continue clean domain-based migration.

[github-actions]

PR Review: Integration Domain Models for External Service Connectivity

🎯 Overview

This PR adds integration domain models for external service connectivity. While demonstrating excellent code quality and ONEX compliance in many areas, there are critical blocking issues that must be resolved before merge.

🚨 Critical Blocking Issues

1. Import Path Failures (WILL CAUSE RUNTIME ERRORS)

The new integration models have incorrect import paths:

Current (BROKEN):

from omnibase_infra.models.notification.model_notification_auth import ModelNotificationAuth
from omnibase_infra.models.webhook.model_webhook_payload import ModelWebhookPayloadUnion

Required Fix:

from omnibase_infra.models.integration.notification.model_notification_auth import ModelNotificationAuth
from omnibase_infra.models.integration.webhook.model_webhook_payload import ModelWebhookPayloadUnion

2. Missing Enum Dependencies

Referenced enums that may not exist:

• EnumAuthType
• EnumNotificationMethod
• EnumBackoffStrategy

3. Duplicate Model Structure

Creates duplicates of existing models in:

• src/omnibase_infra/models/notification/
• src/omnibase_infra/models/slack/
• src/omnibase_infra/models/webhook/

✅ Excellent ONEX Compliance

Strong Points:

• Zero Any types - Complete strong typing throughout ✅
• Proper model structure - CamelCase classes, snake_case files ✅
• Security awareness - Uses SecretStr for credentials ✅
• Comprehensive validation - Field validators and constraints ✅
• Immutable models - frozen=True configuration ✅

⚠️ Security & Architecture Concerns

Security:

• SSRF Risk: url field accepts arbitrary URLs without validation
• Header Security: Warns about sensitive headers but still allows them

Architecture:

• Models exist without contract definitions
• No clear integration with ONEX 4-node pattern (EFFECT/COMPUTE/REDUCER/ORCHESTRATOR)
• Missing dependency injection setup examples

📋 Required Actions Before Merge

Immediate (BLOCKING):

1. Fix all import paths in integration models
2. Verify/create missing enums in omnibase_core
3. Remove duplicate models from old locations
4. Update all existing imports throughout codebase

Recommended:

1. Add SSRF prevention to URL validation
2. Create unit tests for new models
3. Document node integration patterns
4. Provide migration examples

🎯 Final Verdict

❌ DO NOT MERGE - Critical import issues will cause runtime failures

Rating: 7/10

• Excellent code quality and ONEX compliance
• Critical integration issues block deployment
• Fix imports and dependencies, then this will be ready

Next Steps:

1. Fix import paths (30 min)
2. Resolve enum dependencies (1 hr)
3. Complete migration by removing old models (2 hr)
4. Update tests and documentation (1 hr)

Great work on the model design! Once these integration issues are resolved, this will be a solid addition to the infrastructure.