Add Gloas protobuf definitions with spec tests#15601
Merged
terencechain merged 8 commits intodevelopfrom Nov 5, 2025
Merged
Conversation
terencechain
force-pushed
the
add-gloas-protobufs
branch
2 times, most recently
from
023e79d to
82d2cd8
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
3 times, most recently
from
ec109f8 to
8d3d54b
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
10 times, most recently
from
c407a71 to
07fd5f9
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
07fd5f9 to
5219d5d
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
6 times, most recently
from
4821bb4 to
d0d04a7
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
2 times, most recently
from
7ad2960 to
ffa57b7
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
2ff4793 to
fa4cd03
Compare
potuz
previously approved these changes
Nov 3, 2025
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
fa4cd03 to
4b9ee49
Compare
prestonvanloon
requested changes
Nov 3, 2025
| "@com_github_golang_protobuf//proto:go_default_library", | ||
| "@com_github_pkg_errors//:go_default_library", | ||
| "@com_github_offchainlabs_go_bitfield//:go_default_library", | ||
| "@com_github_prysmaticlabs_go_bitfield//:go_default_library", # keep |
Member
There was a problem hiding this comment.
Suggested change
| "@com_github_prysmaticlabs_go_bitfield//:go_default_library", # keep |
Isn't this problematic to have two bitfield libraries?
Comment on lines
354
to
355
| "@com_github_offchainlabs_go_bitfield//:go_default_library", | ||
| "@com_github_prysmaticlabs_go_bitfield//:go_default_library", |
Member
There was a problem hiding this comment.
Suggested change
| "@com_github_offchainlabs_go_bitfield//:go_default_library", | |
| "@com_github_prysmaticlabs_go_bitfield//:go_default_library", | |
| "@com_github_offchainlabs_go_bitfield//:go_default_library", |
Same here, seems problematic to have two bitfield deps?
| "kzg_commitments_inclusion_proof_depth.size": "4", | ||
| "proposer_lookahead_size": "64", # (MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCH | ||
| "ptc.size": "64", # Gloas: Payload Timeliness Committee aggregation bits (PTC_SIZE = 512) | ||
| "ptc.type": "github.com/prysmaticlabs/go-bitfield.Bitvector512", |
Member
There was a problem hiding this comment.
Why is this one prysmaticlabs/go-bitfield, but the minimal one is offchainlabs/go-bitfield?
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
4b9ee49 to
0b6e1e2
Compare
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
19cd9f7 to
d7b2838
Compare
terencechain
force-pushed
the
add-gloas-protobufs
branch
from
d7b2838 to
3edad83
Compare
prestonvanloon
approved these changes
Nov 5, 2025
nalepae
pushed a commit
that referenced
this pull request
Nov 5, 2025
* Add Gloas protobuf definitions with spec tests * Potuz's feedback * Update comment * Update final commits for fastssz and go-bitfield * Sync with develop offchain labs go bitfield changes * Update deps.bzl Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> * Update deps.bzl Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> * Gazelle fix build --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
Muzry
pushed a commit
to Muzry/prysm
that referenced
this pull request
Nov 14, 2025
* Add Gloas protobuf definitions with spec tests * Potuz's feedback * Update comment * Update final commits for fastssz and go-bitfield * Sync with develop offchain labs go bitfield changes * Update deps.bzl Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> * Update deps.bzl Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> * Gazelle fix build --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces gloas protobuf support and also depends on recent changes in fastssz and go-bitfield, which reviewers should be aware of: