Refactor more beacon core types to beacon_core_types.proto#15695
Refactor more beacon core types to beacon_core_types.proto#15695terencechain merged 1 commit intodevelopfrom
beacon_core_types.proto#15695Conversation
terencechain
force-pushed
the
refactor-block-proto-1
branch
from
898f318 to
2c718f6
Compare
| ethereum.engine.v1.ExecutionRequests execution_requests = 13; | ||
| } | ||
|
|
||
| message AttesterSlashingElectra { |
There was a problem hiding this comment.
should this be going into core? if we go this way wouldn't it make more sense to have it in its own electra proto?
There was a problem hiding this comment.
Yeah, since gloas.proto's beacon block will use AttesterSlashingElectra, it needs to live in a common place. From the slack discussion, there was some hesitation about moving existing objects already tied to the fork structure. The concern was that this would end up doing more than what’s required just to set up gloas.proto. For now, the goal is to keep the lift minimal rather than making the broader changes...
| repeated bool is_aggregator = 3; | ||
| } | ||
|
|
||
| // An Ethereum validator. |
There was a problem hiding this comment.
Note to the reviewer, the file name is a bit confusing. It’s called validator.proto, but it’s not for the validator core type. It’s intended for use by the validator client RPC end point, so I think it’s fine to move this
james-prysm
left a comment
james-prysm
left a comment
There was a problem hiding this comment.
LGTM, there is a todo to clean up these fork specific types down the road. approving to unblock gloas
2 participants
This PR moves the following beacon chain core type to its respective proto file to set up
gloas.protoin #15601SyncAggregateAttesterSlashingElectraIndexedAttestationElectraForkSyncCommitteeHistoricalSummaryValidator