Add Gloas beacon state package by terencechain · Pull Request #15611 · OffchainLabs/prysm

terencechain · 2025-08-20T21:34:20Z

This PR adds minimal support for the Gloas beacon state package. It ensures that the custom hash tree root function passes the SSZ vector spec test. Getters and setters are not included in this PR and will be added in follow-up PRs as needed. This implementation covers initialization and ensures the package can be used in future tests

Note to the reviewer: please double check InitializeFromProtoUnsafeGloas which i have pending payments and withdrawals as shared reference. It's not clear to me if they should be shared or not, please correct me if i am wrong here:

	b.sharedFieldReferences[types.BuilderPendingPayments] = stateutil.NewRef(1)    // New in Gloas.
	b.sharedFieldReferences[types.BuilderPendingWithdrawals] = stateutil.NewRef(1) // New in Gloas.

rkapka · 2025-11-14T16:09:29Z

+			BuilderPendingWithdrawals:     b.builderPendingWithdrawals,
+			LatestBlockHash:               b.latestBlockHash,
+			LatestWithdrawalsRoot:         b.latestWithdrawalsRoot,
+			LatestExecutionPayloadBid:     b.executionPayloadbid,


Maybe change executionPayloadBid to latestExecutionPayloadBid to unify naming in both types?

rkapka · 2025-11-14T16:32:54Z

+
+	payments := make([]*ethpb.BuilderPendingPayment, len(b.builderPendingPayments))
+	for i, payment := range b.builderPendingPayments {
+		if payment != nil {


You already have a nil check inside Copy() so this check is technically not needed

rkapka · 2025-11-14T16:33:12Z

+
+	withdrawals := make([]*ethpb.BuilderPendingWithdrawal, len(b.builderPendingWithdrawals))
+	for i, withdrawal := range b.builderPendingWithdrawals {
+		if withdrawal != nil {


same here, no need to check

rkapka · 2025-11-14T16:35:24Z

@@ -0,0 +1,78 @@
+package state_native


Having all Gloas logic in a gloas.go file is new, so far we have been splitting everything by functionality. For example latestWithdrawalsRootVal would go to getters_withdrawal.go.

I like it better in the new fork specific file.

potuz · 2025-11-17T16:30:53Z

 	case LatestExecutionPayloadHeaderDeneb:
 		return "latestExecutionPayloadHeaderDeneb"
+	case ExecutionPayloadBid:
+		return "executionPayloadBid"


This is a little confusing in that the other fields are called by their names, should this be "latestExecutionPayloadBid"?

potuz · 2025-11-17T16:33:20Z


+	// Gloas fields
+	latestExecutionPayloadBid    *ethpb.ExecutionPayloadBid
+	executionPayloadAvailability []byte


JustificationBits is a bitvector, why is executionPayloadAvailability of type []byte?

potuz · 2025-11-17T16:34:54Z

 	PendingConsolidations               []*ethpb.PendingConsolidation           `json:"pending_consolidations" yaml:"pending_consolidations"`
 	ProposerLookahead                   []primitives.ValidatorIndex             `json:"proposer_look_ahead" yaml:"proposer_look_ahead"`
+	LatestExecutionPayloadBid           *ethpb.ExecutionPayloadBid              `json:"latest_execution_payload_bid" yaml:"latest_execution_payload_bid"`
+	ExecutionPayloadAvailability        []byte                                  `json:"execution_payload_availability" yaml:"execution_payload_availability"`


Same here, justification bits is a Bitvector above.

potuz · 2025-11-17T16:36:15Z

+			BuilderPendingWithdrawals:     b.builderPendingWithdrawals,
+			LatestBlockHash:               b.latestBlockHash,
+			LatestWithdrawalsRoot:         b.latestWithdrawalsRoot,
+			LatestExecutionPayloadBid:     b.latestExecutionPayloadBid,


should this be ordered as in the state?

potuz · 2025-11-17T16:36:41Z

+			BuilderPendingWithdrawals:     b.builderPendingWithdrawalsVal(),
+			LatestBlockHash:               b.latestBlockHashVal(),
+			LatestWithdrawalsRoot:         b.latestWithdrawalsRootVal(),
+			LatestExecutionPayloadBid:     b.latestExecutionPayloadBid.Copy(),


Should this be ordered as in the state?

potuz · 2025-11-17T16:42:09Z

+
+		fieldRoots[types.BuilderPendingWithdrawals.RealPosition()] = bpwRoot[:]
+
+		lbhRoot := bytesutil.ToBytes32(state.latestBlockHash)


Do we really need these copies? if there's any doubt I would rather keep these copies indeed.

potuz · 2025-11-17T16:44:51Z

+		types.PendingPartialWithdrawals,
+		types.PendingConsolidations,
+		types.ProposerLookahead,
+		types.ExecutionPayloadBid,


Should this be ordered as in the state?, also perhaps it's better to add a list with the fields that are strictly added in deneb and use them both in the deneb field declaration and here.

potuz · 2025-11-17T16:47:29Z

 	denebSharedFieldRefCount     = 7
 	electraSharedFieldRefCount   = 10
 	fuluSharedFieldRefCount      = 11
+	gloasSharedFieldRefCount     = 12


Probably add a comment with what is the field added here?

potuz · 2025-11-17T16:48:47Z

+	b.sharedFieldReferences[types.Slashings] = stateutil.NewRef(1)
+	b.sharedFieldReferences[types.PreviousEpochParticipationBits] = stateutil.NewRef(1)
+	b.sharedFieldReferences[types.CurrentEpochParticipationBits] = stateutil.NewRef(1)
+	b.sharedFieldReferences[types.ExecutionPayloadBid] = stateutil.NewRef(1) // New in Gloas.


Why is this shared? In fact why is the execution payload header even shared in previous states? cc @rkapka

I'm pretty sure this was just copied/pasted from previous code, but this seems wrong to me.

potuz · 2025-11-17T17:01:58Z

+)
+
+// ExecutionPayloadAvailabilityRoot computes the merkle root of an execution payload availability bitvector.
+func ExecutionPayloadAvailabilityRoot(bitvector []byte) ([32]byte, error) {


Note to myself, this function needs to be optimized, copying here all the bytes and chunking doesn't make sense. For smaller bitfields it does make sense, but this will have 256 chunks

potuz · 2025-11-17T23:25:05Z

+	}
+
+	capellaFields = append(
+		append([]types.FieldIndex{}, altairFields...),


This is a really weird pattern.

potuz · 2025-11-17T23:26:52Z

 	electraSharedFieldRefCount   = 10
 	fuluSharedFieldRefCount      = 11
-	gloasSharedFieldRefCount     = 12
+	gloasSharedFieldRefCount     = 12 // Adds LatestExecutionPayloadBid to the shared-ref set.


If you remove the payload bid then this comment needs to change?

Sorry, i meant to say Adds pending builder withdrawals to the shared-ref set, not LatestExecutionPayloadBid

potuz · 2025-11-17T23:31:56Z

+	denebFields = slices.Concat(
+		altairFields,
+		append([]types.FieldIndex{types.LatestExecutionPayloadHeaderDeneb}, withdrawalAndHistoricalSummaryFields...),


concat takes several inputs, this can be written as

denebFields = slices.Concat( altairFields, []types.FieldIndex{types.LatestExecutionPayloadHeaderDeneb}, withdrawalAndHistoricalSummaryFields, )

potuz · 2025-11-17T23:35:47Z

 	electraSharedFieldRefCount   = 10
 	fuluSharedFieldRefCount      = 11
-	gloasSharedFieldRefCount     = 12 // Adds LatestExecutionPayloadBid to the shared-ref set.
+	gloasSharedFieldRefCount     = 12 // Adds pending builder withdrawals to the shared-ref set.


gloasSharedFieldRefCount = 12 // Adds pending builder withdrawals to the shared-ref set and LatestExecutionPayloadHeader is removed

potuz · 2025-11-17T23:37:45Z

+
+	capellaFields = slices.Concat(
+		altairFields,
+		append([]types.FieldIndex{types.LatestExecutionPayloadHeaderCapella}, withdrawalAndHistoricalSummaryFields...),


Same here, the second append is not needed.

terencechain added the gloas label Aug 20, 2025

terencechain force-pushed the add-gloas-state branch 3 times, most recently from 4864197 to 442588a Compare August 26, 2025 02:11

terencechain force-pushed the add-gloas-state branch 3 times, most recently from a02c7b6 to 0d06b2f Compare August 31, 2025 03:16

terencechain force-pushed the add-gloas-state branch 5 times, most recently from 77937de to 1089cb3 Compare September 24, 2025 21:13

terencechain changed the base branch from develop to add-gloas-protobufs September 24, 2025 21:13

terencechain force-pushed the add-gloas-state branch 5 times, most recently from 197d571 to 89fef62 Compare September 24, 2025 22:31

terencechain marked this pull request as ready for review September 24, 2025 22:31

terencechain assigned potuz Sep 24, 2025

terencechain force-pushed the add-gloas-state branch 3 times, most recently from dbb6439 to 31e7558 Compare September 25, 2025 15:00

terencechain force-pushed the add-gloas-protobufs branch from 4821bb4 to d0d04a7 Compare September 25, 2025 23:11

terencechain requested a review from prestonvanloon as a code owner September 25, 2025 23:11

terencechain force-pushed the add-gloas-protobufs branch 2 times, most recently from 7ad2960 to ffa57b7 Compare October 9, 2025 20:46

terencechain force-pushed the add-gloas-state branch from 31e7558 to 4a30dde Compare October 9, 2025 20:47

terencechain force-pushed the add-gloas-protobufs branch from ffa57b7 to 611e9b9 Compare October 23, 2025 02:27

terencechain force-pushed the add-gloas-protobufs branch from c5130b9 to 2ff4793 Compare November 3, 2025 17:26

terencechain force-pushed the add-gloas-state branch from 20513d4 to c7f23a4 Compare November 14, 2025 15:57

Remove shared field for pending payment

e7713f3

rkapka reviewed Nov 14, 2025

View reviewed changes

terencechain force-pushed the add-gloas-state branch 2 times, most recently from c6279ec to 839c895 Compare November 14, 2025 23:19

Radek's feedback

d221794

terencechain force-pushed the add-gloas-state branch from 839c895 to d221794 Compare November 14, 2025 23:32

rkapka previously approved these changes Nov 15, 2025

View reviewed changes

potuz reviewed Nov 17, 2025

View reviewed changes

Potuz feedback

e4757ee

terencechain dismissed rkapka’s stale review via e4757ee November 17, 2025 18:34

use slice concat

37f0b43

potuz reviewed Nov 17, 2025

View reviewed changes

Fix comment

f84f3e8

potuz reviewed Nov 17, 2025

View reviewed changes

terencechain added 3 commits November 17, 2025 15:39

Fix concat

963db2f

Fix comment

a179b7f

Fix correct index

839cab7

potuz approved these changes Nov 18, 2025

View reviewed changes

terencechain added this pull request to the merge queue Nov 18, 2025

Merged via the queue into develop with commit bc0868e Nov 18, 2025
17 checks passed

terencechain deleted the add-gloas-state branch November 18, 2025 15:37

satushh mentioned this pull request Jan 5, 2026

Gloas (EIP-7732) Implementation Tracker #16213

Closed

james-prysm added this to Gloas Feb 11, 2026

github-project-automation Bot moved this to Done in Gloas Feb 11, 2026

terencechain assigned terencechain and unassigned potuz Feb 12, 2026


		fieldRoots[types.BuilderPendingWithdrawals.RealPosition()] = bpwRoot[:]

		lbhRoot := bytesutil.ToBytes32(state.latestBlockHash)

Conversation

terencechain commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terencechain Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

terencechain commented Aug 20, 2025 •

edited

Loading

terencechain Nov 17, 2025 •

edited

Loading