Skip to content

Test: add deneb spec test version beta.0#12610

Merged
terencechain merged 4 commits intodeneb-integrationfrom
beta.0-spectests
Jul 25, 2023
Merged

Test: add deneb spec test version beta.0#12610
terencechain merged 4 commits intodeneb-integrationfrom
beta.0-spectests

Conversation

@terencechain
Copy link
Collaborator

@terencechain terencechain commented Jul 10, 2023 •
edited
Loading

prereq, we need to merge these first:
#12577
#12565

@terencechain terencechain requested a review from a team as a code owner July 10, 2023 22:34
@terencechain terencechain requested review from james-prysm, potuz and rkapka and removed request for a team July 10, 2023 22:34
@prestonvanloon
Copy link
Member

prestonvanloon commented Jul 12, 2023

I think this needs to be rebased? Diff seems really large

@kasey kasey force-pushed the deneb-integration branch from 2829315 to 20b0fdd Compare July 20, 2023 18:23
@kasey kasey requested a review from prestonvanloon as a code owner July 20, 2023 18:23
@terencechain terencechain force-pushed the beta.0-spectests branch 3 times, most recently from d2bfc67 to fcef885 Compare July 22, 2023 13:09
@terencechain terencechain changed the title Test: spec test beta.0 Test: add deneb spec test version beta.0 Jul 23, 2023
potuz
potuz reviewed Jul 24, 2023
View reviewed changes
testing/spectest/mainnet/deneb/fork_helper/BUILD.bazel Outdated
size = "small",
srcs = ["upgrade_to_deneb_test.go"],
srcs = [
"upgrade_to_capella_test.go",
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

testing/spectest/mainnet/deneb/fork_helper/upgrade_to_capella_test.go Outdated
"github.com/prysmaticlabs/prysm/v4/testing/spectest/shared/deneb/fork"
)

func TestMainnet_Deneb_UpgradeToCapella(t *testing.T) {
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the test and the file?

testing/spectest/minimal/deneb/fork/BUILD.bazel Outdated
size = "small",
srcs = ["upgrade_to_deneb_test.go"],
srcs = [
"upgrade_to_capella_test.go",
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: remove this file?

testing/spectest/minimal/deneb/fork/BUILD.bazel Outdated
srcs = ["upgrade_to_deneb_test.go"],
srcs = [
"upgrade_to_capella_test.go",
"upgrade_to_deneb_test.go",
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not included

testing/spectest/minimal/deneb/fork/upgrade_to_capella_test.go Outdated
@@ -0,0 +1,11 @@
package fork
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file

testing/spectest/shared/deneb/fork/BUILD.bazel Outdated
srcs = ["upgrade_to_deneb.go"],
srcs = [
"transition.go",
"upgrade_to_capella.go",
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

testing/spectest/shared/deneb/fork/upgrade_to_capella.go Outdated
@@ -0,0 +1,63 @@
package fork
Copy link
Contributor

@potuz potuz Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file

@terencechain
Copy link
Collaborator Author

terencechain commented Jul 24, 2023

@potuz thanks for the feedback, I fixed them in 6f32e9b
one thing noting pointed out by you is we are missing the genesis folder, I will go ahead and create an issue to track that

james-prysm
james-prysm reviewed Jul 25, 2023
View reviewed changes
testing/spectest/shared/deneb/ssz_static/ssz_static.go Outdated
case "AggregateAndProof":
obj = &ethpb.AggregateAttestationAndProof{}
case "BeaconBlock":
t.Skip("Skipping BeaconBlock test")
Copy link
Contributor

@james-prysm james-prysm Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we supposed to be skipping these tests? or is it taken cared of in a later pr

Copy link
Collaborator Author

@terencechain terencechain Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 9f2d537

james-prysm
james-prysm reviewed Jul 25, 2023
View reviewed changes
testing/spectest/shared/deneb/operations/withdrawals.go Outdated
if err != nil {
return nil, err
}
p, err := consensusblocks.WrappedExecutionPayloadCapella(&enginev1.ExecutionPayloadCapella{Withdrawals: withdrawals}, 0)
Copy link
Contributor

@james-prysm james-prysm Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait shouldn't this type be deneb?

Copy link
Collaborator Author

@terencechain terencechain Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 9f2d537

@terencechain terencechain self-assigned this Jul 25, 2023
@terencechain terencechain merged commit 4a8e92b into deneb-integration Jul 25, 2023
@terencechain terencechain deleted the beta.0-spectests branch July 25, 2023 23:32
james-prysm pushed a commit that referenced this pull request Aug 4, 2023
@terencechain @james-prysm
Test: add deneb spec test version beta.0 (#12610)
2f47195
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
Test: add deneb spec test version beta.0 (#12610)
7dada4e
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
3d981ec
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
9fe2c46
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
4a29614
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
174becd
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
02b073b
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
00cea82
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
56b394c
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
915d816
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Test: add deneb spec test version beta.0 (#12610)
20aecca
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
4e62366
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
a07c238
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
37fbd5f
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
84331fc
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
da4bdd7
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
6749bd4
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
3a2ebf3
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
40bfe16
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
9d0daf5
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
ffe1f03
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
cbfc1c9
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
7e7387b
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
Test: add deneb spec test version beta.0 (#12610)
6402301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potuz potuz potuz left review comments

@james-prysm james-prysm james-prysm approved these changes

@rkapka rkapka Awaiting requested review from rkapka rkapka was automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@terencechain terencechain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terencechain @prestonvanloon @potuz @james-prysm