Deneb: Implement EIP-7044#12577
Merged
terencechain merged 1 commit intodeneb-integrationfrom Jul 22, 2023
Merged
Conversation
prestonvanloon
requested review from
james-prysm,
kasey,
rauljordan and
terencechain
and removed request for
a team
terencechain
force-pushed
the
deneb-integration
branch
from
aaeda1b to
dd3e166
Compare
prestonvanloon
force-pushed
the
deneb-eip-7044
branch
from
bc961e8 to
4039ff2
Compare
terencechain
approved these changes
Jul 10, 2023
prestonvanloon
force-pushed
the
deneb-eip-7044
branch
from
796a97e to
2d1f3fb
Compare
terencechain
approved these changes
Jul 13, 2023
Collaborator
terencechain
left a comment
terencechain
left a comment
There was a problem hiding this comment.
One optional feedback
| fork := st.Fork() | ||
| // EIP-7044: Beginning in Deneb, fix the fork version to Capella for signed exits. | ||
| // This allows for signed validator exits to be valid forever. | ||
| if st.Version() >= version.Deneb && domain == params.BeaconConfig().DomainVoluntaryExit { |
Collaborator
There was a problem hiding this comment.
It looks like the cheaper check is domain == params.BeaconConfig().DomainVoluntaryExit, so it might be worth it to check that first. Very micro-optimization though
Closed
terencechain
force-pushed
the
deneb-eip-7044
branch
from
2d1f3fb to
98ad992
Compare
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
pushed a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
added a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
EIP-7044 essentially freezes the signature domain to the Capella fork data in Deneb. This PR updates the signing domain computation and verification in deneb to fulfill the requirements of the EIP.
Which issues(s) does this PR fix?
Other notes for review
This PR is rather small and could possibly be a good candidate for the develop branch. It does not require any Deneb specific structs (except beacon state) and shouldn't effect the critical path as the new logic only runs on a state version of Deneb or greater.Nevermind, it depends on deneb beacon state for tests.