Skip to content

feat: EIP7045 increase max att inclusion slot#12565

Merged
terencechain merged 11 commits intodeneb-integrationfrom
eip7045
Jul 22, 2023
Merged

feat: EIP7045 increase max att inclusion slot#12565
terencechain merged 11 commits intodeneb-integrationfrom
eip7045

Conversation

@terencechain
Copy link
Collaborator

@terencechain terencechain commented Jun 26, 2023

This PR implements EIP7045

@terencechain terencechain self-assigned this Jun 26, 2023
@terencechain terencechain marked this pull request as ready for review June 26, 2023 20:47
@terencechain terencechain requested a review from a team as a code owner June 26, 2023 20:47
@terencechain terencechain requested review from james-prysm, nisdas and prestonvanloon and removed request for a team June 26, 2023 20:47
@terencechain terencechain force-pushed the eip7045 branch 3 times, most recently from 96aa6fb to 9261773 Compare June 28, 2023 15:20
prestonvanloon
prestonvanloon reviewed Jun 29, 2023
View reviewed changes
@terencechain terencechain force-pushed the eip7045 branch 2 times, most recently from 67e7c3b to 97c3eda Compare July 13, 2023 07:23
potuz
potuz reviewed Jul 13, 2023
View reviewed changes
beacon-chain/core/altair/attestation.go Outdated
participatedFlags[targetFlagIndex] = true
}
} else {
if matchedSrcTgt && delay <= slotsPerEpoch {
Copy link
Contributor

@potuz potuz Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this change? before Deneb no attestation should pass validation without having delay <= slotsPerEpoch.

Copy link
Collaborator Author

@terencechain terencechain Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit torn. I see arguments for both.
1.) If the input attestations were validated, it's not-needed. The code is much cleaner
2.) If the input attestations were not validated then we need the filter here

@terencechain terencechain mentioned this pull request Jul 14, 2023
Merged
@terencechain terencechain force-pushed the eip7045 branch 2 times, most recently from 9feb377 to 7dccbb7 Compare July 20, 2023 07:57
@kasey kasey force-pushed the deneb-integration branch from 2829315 to 20b0fdd Compare July 20, 2023 18:23
@terencechain terencechain merged commit 9834720 into deneb-integration Jul 22, 2023
@terencechain terencechain deleted the eip7045 branch July 22, 2023 07:37
james-prysm pushed a commit that referenced this pull request Aug 4, 2023
@terencechain @james-prysm
feat: EIP7045 increase max att inclusion slot (#12565)
89ef31e
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
feat: EIP7045 increase max att inclusion slot (#12565)
c4e452f
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
957d88f
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
a2b3fb8
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
53570b3
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
6748d58
@terencechain terencechain mentioned this pull request Aug 23, 2023
Closed
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
68d3a9f
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
3bdf120
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
f53ac53
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
17ad771
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
feat: EIP7045 increase max att inclusion slot (#12565)
db48c5c
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
072263a
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
8b10b91
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
873616d
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
14fd3b9
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
0cc18b6
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
5246455
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
04b97e8
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
e2dcb46
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
34b2ab4
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
c2d6582
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
ba9e480
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
f6dfad4
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
feat: EIP7045 increase max att inclusion slot (#12565)
2bc91d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

@potuz potuz potuz approved these changes

@nisdas nisdas Awaiting requested review from nisdas nisdas was automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm was automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terencechain @prestonvanloon @potuz