Deneb integration: Beacon API getStateV2#12416
Merged
rkapka merged 6 commits intodeneb-integrationfrom May 18, 2023
Merged
Conversation
rkapka
requested review from
kasey,
potuz and
terencechain
and removed request for
a team
james-prysm
reviewed
May 17, 2023
| repeated uint64 inactivity_scores = 9001 [(ethereum.eth.ext.ssz_max) = "1099511627776"]; | ||
| SyncCommittee current_sync_committee = 9002; // [New in Altair] | ||
| SyncCommittee next_sync_committee = 9003; // [New in Altair] | ||
| // Bellatrix fields [10001-11000] |
Contributor
There was a problem hiding this comment.
I just noticed this number... isn't this for deneb? this says bellatrix fields shouldn't this be deneb fields?
Contributor
Author
There was a problem hiding this comment.
I would say this is fine. Execution payload was introduced in Bellatrix and we only "update" the type of the field.
james-prysm
reviewed
May 17, 2023
| RandaoMixes: filledByteSlice2D(uint64(params.BeaconConfig().EpochsPerHistoricalVector), 32), | ||
| Validators: make([]*ethpb.Validator, 0), | ||
| CurrentJustifiedCheckpoint: ðpb.Checkpoint{Root: make([]byte, fieldparams.RootLength)}, | ||
| Eth1Data: ðpb.Eth1Data{ |
Contributor
There was a problem hiding this comment.
do we have util functions for these? like just creating an empty object? seems like it's used all over the place
james-prysm
approved these changes
May 17, 2023
Contributor
james-prysm
left a comment
james-prysm
left a comment
There was a problem hiding this comment.
added small comment on test which is probably optional
terencechain
force-pushed
the
deneb-integration
branch
from
5421f7b to
62c6fc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Update of https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Debug/getStateV2 to support Deneb