Add deneb block to consensus types by terencechain · Pull Request #12368 · OffchainLabs/prysm

terencechain · 2023-05-06T22:41:14Z

Add deneb block to consensus types

executionPayloadHeaderDeneb implementation
executionPayloadDeneb implementation
New execution getter ExcessDataGas across all executionPayloadXYZ implementations
Helper to convert PayloadToHeaderDeneb
Block factory to support Deneb
Block getters to support Deneb
Block proto to support Deneb
Cloners for Deneb blocks

rkapka · 2023-05-08T16:34:42Z

consensus-types/blocks/execution.go

 }

-// PbCapella --
+func (e executionPayloadCapella) ExcessDataGas() ([]byte, error) {


Missing doc

rkapka · 2023-05-08T16:34:52Z

consensus-types/blocks/execution.go

 }

-// PbCapella --
+func (e executionPayloadHeaderCapella) ExcessDataGas() ([]byte, error) {


Missing doc

rkapka · 2023-05-08T16:55:50Z

consensus-types/blocks/execution.go

 	return true, nil
 }
+
+// executionPayloadHeaderDeneb is a convenience wrapper around a blinded beacon block body's execution header data structure


Suggested change

// executionPayloadHeaderDeneb is a convenience wrapper around a blinded beacon block body's execution header data structure

// executionPayloadHeaderDeneb is a convenience wrapper around a blinded beacon block body's execution header data structure.

rkapka · 2023-05-08T17:01:33Z

consensus-types/blocks/factory.go

+	case *eth.GenericSignedBeaconBlock_Deneb:
+		return initSignedBlockFromProtoDeneb(b.Deneb.Block)
+	case *eth.SignedBeaconBlockDeneb:
+		return initSignedBlockFromProtoDeneb(b)
+	case *eth.SignedBlindedBeaconBlockDeneb:
+		return initBlindedSignedBlockFromProtoDeneb(b)


Missing GenericSignedBeaconBlock_BlindedDeneb

If everything works correctly without this, it makes me wonder if we even need GenericXXX cases here. But that it a question for another time, here I would blindly add it.

rkapka · 2023-05-08T17:02:28Z

consensus-types/blocks/factory.go

+	case *eth.GenericBeaconBlock_Deneb:
+		return initBlockFromProtoDeneb(b.Deneb.Block)
+	case *eth.BeaconBlockDeneb:
+		return initBlockFromProtoDeneb(b)
+	case *eth.BlindedBeaconBlockDeneb:
+		return initBlindedBlockFromProtoDeneb(b)


Missing GenericBeaconBlock_BlindedDeneb

rkapka · 2023-05-08T17:14:50Z

consensus-types/blocks/proto_test.go

+		VoluntaryExits:         f.voluntaryExits,
+		SyncAggregate:          f.syncAggregate,
+		ExecutionPayloadHeader: f.execPayloadHeaderDeneb,
+		BlsToExecutionChanges:  f.blsToExecutionChanges,


Same comment as for bodyPbDeneb()

rkapka · 2023-05-08T17:15:13Z

consensus-types/blocks/proto_test.go

+		voluntaryExits:        f.voluntaryExits,
+		syncAggregate:         f.syncAggregate,
+		executionPayload:      p,
+		blsToExecutionChanges: f.blsToExecutionChanges,


Same comment as for bodyPbDeneb()

rkapka · 2023-05-08T17:15:16Z

consensus-types/blocks/proto_test.go

+		voluntaryExits:         f.voluntaryExits,
+		syncAggregate:          f.syncAggregate,
+		executionPayloadHeader: ph,
+		blsToExecutionChanges:  f.blsToExecutionChanges,


Same comment as for bodyPbDeneb()

rkapka · 2023-05-08T17:15:57Z

consensus-types/blocks/setters.go

+func (b *SignedBeaconBlock) SetBlobKzgCommitments(c [][]byte) error {
+	switch b.version {
+	case version.Phase0, version.Altair, version.Bellatrix, version.Capella:
+		return consensus_types.ErrNotSupported("BlobKzgCommitments", b.version)


Suggested change

return consensus_types.ErrNotSupported("BlobKzgCommitments", b.version)

return consensus_types.ErrNotSupported("SetBlobKzgCommitments", b.version)

rkapka · 2023-05-08T17:16:54Z

consensus-types/interfaces/beacon_block.go

 	Header() (*ethpb.SignedBeaconBlockHeader, error)
 }

+type ReadOnlySignedBeaconBlockSlice []ReadOnlySignedBeaconBlock


I think this is unused

terencechain added the Ready For Review label May 6, 2023

terencechain self-assigned this May 6, 2023

terencechain requested a review from a team as a code owner May 6, 2023 22:41

terencechain requested review from james-prysm, potuz and saolyn and removed request for a team May 6, 2023 22:41

terencechain force-pushed the deneb-consensus-changes branch from 762ad2b to 07f9093 Compare May 6, 2023 22:55

rkapka requested changes May 8, 2023

View reviewed changes

terencechain force-pushed the deneb-integration branch from 729fa25 to 6a957c1 Compare May 8, 2023 20:18

terencechain requested a review from prestonvanloon as a code owner May 8, 2023 20:18

terencechain added 2 commits May 8, 2023 13:28

Add deneb block to consensus types

03b54f4

Radek's feedback

cd2a5c2

terencechain force-pushed the deneb-consensus-changes branch from 3fe5ab4 to cd2a5c2 Compare May 8, 2023 20:30

rkapka approved these changes May 8, 2023

View reviewed changes

terencechain merged commit 8f05f11 into deneb-integration May 8, 2023

terencechain deleted the deneb-consensus-changes branch May 8, 2023 23:47

terencechain added the Deneb label May 9, 2023

terencechain added a commit that referenced this pull request May 11, 2023

Add deneb block to consensus types (#12368)

6053d9e

terencechain added a commit that referenced this pull request May 11, 2023

Add deneb block to consensus types (#12368)

57aa834

terencechain added a commit that referenced this pull request May 16, 2023

Add deneb block to consensus types (#12368)

e5e62c0

terencechain added a commit that referenced this pull request May 17, 2023

Add deneb block to consensus types (#12368)

58fa20a

terencechain added a commit that referenced this pull request May 18, 2023

Add deneb block to consensus types (#12368)

077ac81

kasey pushed a commit that referenced this pull request May 19, 2023

Add deneb block to consensus types (#12368)

9342abb

kasey pushed a commit that referenced this pull request May 22, 2023

Add deneb block to consensus types (#12368)

e9e75d8

terencechain added a commit that referenced this pull request May 23, 2023

Add deneb block to consensus types (#12368)

f5ca94c

james-prysm added a commit that referenced this pull request May 23, 2023

Add deneb block to consensus types (#12368)

5dc062a

terencechain added a commit that referenced this pull request May 23, 2023

Add deneb block to consensus types (#12368)

88a44ca

terencechain added a commit that referenced this pull request May 26, 2023

Add deneb block to consensus types (#12368)

fc20491

terencechain added a commit that referenced this pull request May 31, 2023

Add deneb block to consensus types (#12368)

299c45a

terencechain added a commit that referenced this pull request Jun 27, 2023

Add deneb block to consensus types (#12368)

be100b9

terencechain added a commit that referenced this pull request Jun 27, 2023

Add deneb block to consensus types (#12368)

50d2607

james-prysm pushed a commit that referenced this pull request Jun 27, 2023

Add deneb block to consensus types (#12368)

13a1738

terencechain added a commit that referenced this pull request Jul 7, 2023

Add deneb block to consensus types (#12368)

5ef0f72

terencechain added a commit that referenced this pull request Jul 9, 2023

Add deneb block to consensus types (#12368)

fc2f995

terencechain added a commit that referenced this pull request Jul 10, 2023

Add deneb block to consensus types (#12368)

641536c

terencechain added a commit that referenced this pull request Jul 10, 2023

Add deneb block to consensus types (#12368)

12691fb

terencechain added a commit that referenced this pull request Jul 13, 2023

Add deneb block to consensus types (#12368)

756b44f

terencechain added a commit that referenced this pull request Jul 13, 2023

Add deneb block to consensus types (#12368)

d29c89d

terencechain added a commit that referenced this pull request Jul 20, 2023

Add deneb block to consensus types (#12368)

98e35cd

terencechain added a commit that referenced this pull request Jul 20, 2023

Add deneb block to consensus types (#12368)

d7c77bc

kasey pushed a commit that referenced this pull request Jul 20, 2023

Add deneb block to consensus types (#12368)

431fa34

terencechain added a commit that referenced this pull request Jul 21, 2023

Add deneb block to consensus types (#12368)

60960c8

terencechain added a commit that referenced this pull request Jul 21, 2023

Add deneb block to consensus types (#12368)

143ab91

james-prysm pushed a commit that referenced this pull request Aug 4, 2023

Add deneb block to consensus types (#12368)

2518fc8

terencechain added a commit that referenced this pull request Aug 16, 2023

Add deneb block to consensus types (#12368)

f2d7c14

kasey pushed a commit that referenced this pull request Aug 21, 2023

Add deneb block to consensus types (#12368)

2db5bf0

kasey pushed a commit that referenced this pull request Aug 22, 2023

Add deneb block to consensus types (#12368)

8faeb47

kasey pushed a commit that referenced this pull request Aug 22, 2023

Add deneb block to consensus types (#12368)

e7bbcc7

kasey pushed a commit that referenced this pull request Aug 22, 2023

Add deneb block to consensus types (#12368)

c90dd45

kasey pushed a commit that referenced this pull request Aug 23, 2023

Add deneb block to consensus types (#12368)

6d5b556

kasey pushed a commit that referenced this pull request Aug 23, 2023

Add deneb block to consensus types (#12368)

151bd10

kasey pushed a commit that referenced this pull request Aug 23, 2023

Add deneb block to consensus types (#12368)

f7b81ed

kasey added a commit that referenced this pull request Aug 24, 2023

fixup! Add deneb block to consensus types (#12368)

7dfa0c5

kasey pushed a commit that referenced this pull request Aug 24, 2023

Add deneb block to consensus types (#12368)

ecaaee9

prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023

Add deneb block to consensus types (#12368)

96324d9

prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023

Add deneb block to consensus types (#12368)

6be8202

james-prysm pushed a commit that referenced this pull request Aug 25, 2023

Add deneb block to consensus types (#12368)

f576bcf

prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023

Add deneb block to consensus types (#12368)

8118220

prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023

Add deneb block to consensus types (#12368)

8e91df9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deneb block to consensus types#12368

Add deneb block to consensus types#12368
terencechain merged 2 commits intodeneb-integrationfrom
deneb-consensus-changes

terencechain commented May 6, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

rkapka May 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// executionPayloadHeaderDeneb is a convenience wrapper around a blinded beacon block body's execution header data structure
	// executionPayloadHeaderDeneb is a convenience wrapper around a blinded beacon block body's execution header data structure.

	return consensus_types.ErrNotSupported("BlobKzgCommitments", b.version)
	return consensus_types.ErrNotSupported("SetBlobKzgCommitments", b.version)

Conversation

terencechain commented May 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants