Merged
Conversation
terencechain
requested review from
james-prysm,
nisdas and
rkapka
and removed request for
a team
james-prysm
reviewed
May 9, 2023
Contributor
There was a problem hiding this comment.
the error here should be StateDeneb I think
rkapka
reviewed
May 9, 2023
Contributor
There was a problem hiding this comment.
Suggested change
| // ProtobufBeaconStateDeneb transforms an input into beacon state Capella in the form of protobuf. | |
| // ProtobufBeaconStateDeneb transforms an input into beacon state Deneb in the form of protobuf. |
Comment on lines
275
to
290
| // Next withdrawal index root. | ||
| nextWithdrawalIndexRoot := make([]byte, 32) | ||
| binary.LittleEndian.PutUint64(nextWithdrawalIndexRoot, state.nextWithdrawalIndex) | ||
| fieldRoots[types.NextWithdrawalIndex.RealPosition()] = nextWithdrawalIndexRoot | ||
|
|
||
| // Next partial withdrawal validator index root. | ||
| nextWithdrawalValidatorIndexRoot := make([]byte, 32) | ||
| binary.LittleEndian.PutUint64(nextWithdrawalValidatorIndexRoot, uint64(state.nextWithdrawalValidatorIndex)) | ||
| fieldRoots[types.NextWithdrawalValidatorIndex.RealPosition()] = nextWithdrawalValidatorIndexRoot | ||
|
|
||
| // Historical summary root. | ||
| historicalSummaryRoot, err := stateutil.HistoricalSummariesRoot(state.historicalSummaries) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "could not compute historical summary merkleization") | ||
| } | ||
| fieldRoots[types.HistoricalSummaries.RealPosition()] = historicalSummaryRoot[:] |
Contributor
There was a problem hiding this comment.
Suggested change
| assert.Equal(t, true, ok, "inner state is a not a beacon state bellatrix proto") | |
| assert.Equal(t, true, ok, "inner state is a not a beacon state deneb proto") |
Comment on lines
98
to
99
james-prysm
approved these changes
May 9, 2023
james-prysm
approved these changes
May 9, 2023
terencechain
added a commit
that referenced
this pull request
May 11, 2023
terencechain
added a commit
that referenced
this pull request
May 11, 2023
terencechain
added a commit
that referenced
this pull request
May 16, 2023
terencechain
added a commit
that referenced
this pull request
May 17, 2023
terencechain
added a commit
that referenced
this pull request
May 18, 2023
kasey
pushed a commit
that referenced
this pull request
May 19, 2023
kasey
pushed a commit
that referenced
this pull request
May 22, 2023
terencechain
added a commit
that referenced
this pull request
May 23, 2023
terencechain
added a commit
that referenced
this pull request
May 26, 2023
terencechain
added a commit
that referenced
this pull request
May 31, 2023
terencechain
added a commit
that referenced
this pull request
Jun 7, 2023
terencechain
added a commit
that referenced
this pull request
Jun 12, 2023
terencechain
added a commit
that referenced
this pull request
Jun 12, 2023
terencechain
added a commit
that referenced
this pull request
Jun 16, 2023
terencechain
added a commit
that referenced
this pull request
Jun 27, 2023
terencechain
added a commit
that referenced
this pull request
Jul 7, 2023
terencechain
added a commit
that referenced
this pull request
Jul 9, 2023
terencechain
added a commit
that referenced
this pull request
Jul 10, 2023
kasey
pushed a commit
that referenced
this pull request
Jul 20, 2023
james-prysm
pushed a commit
that referenced
this pull request
Aug 4, 2023
terencechain
added a commit
that referenced
this pull request
Aug 16, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 21, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 22, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 23, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
kasey
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 24, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 30, 2023
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deneb beacon state native type. It also uses native type hash tree root for spec test