Conversation
* chore: move dependencies into dev dependencies * refactor: move dotenv into dev dependency * Add tsnode to dev dependency * lint * rename network id * fix: breaking change on network config
gzeoneth
changed the title
yahgwai
left a comment
yahgwai
left a comment
There was a problem hiding this comment.
We need to PR this against c-nitro-stable. We could merge it into c-nitro-next and then cherry-pick it over to c-nitro-stable
| "typechain": "7.0.0", | ||
| "@arbitrum/nitro-contracts": "1.0.0-beta.5", | ||
| "arb-bridge-peripherals": "1.0.10", | ||
| "@arbitrum/nitro-contracts": "https://gitpkg.now.sh/OffchainLabs/nitro/contracts?expose-outbox-isspent", |
There was a problem hiding this comment.
We should release a version of the nitro contracts and include that here
| // not redeemed, has it now expired | ||
| if (await this.isExpired()) { | ||
| try { | ||
| if (await this.isExpired()) { |
There was a problem hiding this comment.
I think we should make isExpired atomic with getSuccessfulRedeem so that we always have consistent results for getSuccessfulRedeem.
We could adjust isExpired so that it has a try/catch internally, and rename it to retryableExists.
Then adjust getSuccessfulRedeem so that we call retryableExists somewhere at the start of it. If retryableExists is true then we can just return null straight away - since it hasnt been redeemed or expired. If retryableExists is false then we either successfully redeemed or we expired. We then look for a successful redeem, if we find it we return the tx receipt, if we dont we return some value that indicates an expiration.
Then we won't check isExpired/retryableExists in receiptToStatus, instead we just pass in the receipt, or the value that indicates expiration.
| const addressAlias = new Address(fromAddress) | ||
|
|
||
| const from = addressAlias.applyAlias() |
There was a problem hiding this comment.
sure we don't need to apply an alias here anymore?
If the user is supplying the from address as their L1 address it still needs to be aliased.
The difference is that now the alias is applied int he L1 inbox instead of by arb-os.
We should clarify what's expected in the fromAddress field. If its the value from the Inbox delivered event, it doesn't need aliasing. If its the plain user address, it needs alaising
There was a problem hiding this comment.
ah, calculateSubmitRetryableId is public static
I think we should just add some comment regarding the input expected.
|
closed in favor of #100 |
…unning-support Add local node support for tutorials
3 participants
OffchainLabs/nitro#623 Outbox replay state management
OffchainLabs/nitro#692 Refactor accumulator flow
OffchainLabs/nitro#697 Move address aliasing from L2 to L1
OffchainLabs/nitro#720 Expose isSpent in Outbox
Also fix a race condition in
L1ToL2Message.receiptsToStatus