fix: hotfixes for nitro support#100
Merged
fredlacs merged 20 commits intoc-nitro-stablefrom Jun 28, 2022
Merged
Conversation
Closed
gzeoneth
requested changes
Jun 27, 2022
gzeoneth
reviewed
Jun 27, 2022
src/lib/message/L1ToL2Message.ts
Outdated
| const creationReceipt = await this.getRetryableCreationReceipt() | ||
| // if retryable was created but no longer exists then we know that it was either | ||
| // redeemed or expired | ||
| const redeemWasSuccessfulOrExpired = creationReceipt && !await this.retryableExists() |
Member
There was a problem hiding this comment.
Suggested change
| const redeemWasSuccessfulOrExpired = creationReceipt && !await this.retryableExists() | |
| const redeemWasSuccessfulOrExpired = creationReceipt && !await this.retryableExists() | |
| if(!redeemWasSuccessfulOrExpired){ | |
| // either created but not redeemed yet -> not expired | |
| // or not created -> not expired(?) | |
| return { redeemReceipt: null, expired: false } | |
| } |
Member
|
cherry-pick 65e2825 then I think this should be done |
Co-authored-by: gzeon <95478735+gzeoneth@users.noreply.github.com>
gzeoneth
approved these changes
Jun 28, 2022
fredlacs
commented
Jun 28, 2022
umershaikh123
pushed a commit
to umershaikh123/arbitrum-sdk
that referenced
this pull request
May 20, 2024
update logo all over the tutorials repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked commits from #98
Changed the base of that PR which made stuff messy
Should still address #98 (comment)