Skip to content

feat: expose isSpent in Outbox#720

Merged
PlasmaPower merged 2 commits intomasterfrom
expose-outbox-isspent
Jun 24, 2022
Merged

feat: expose isSpent in Outbox#720
PlasmaPower merged 2 commits intomasterfrom
expose-outbox-isspent

Conversation

@gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Jun 24, 2022

Since #623 there are no easy way to see if a certain outbox entry is spent, this PR expose a helper function isSpent to solve that.

PlasmaPower
PlasmaPower previously approved these changes Jun 24, 2022
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #720 (f0aeeb9) into master (78d22bf) will decrease coverage by 3.94%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   52.08%   48.13%   -3.95%     
==========================================
  Files         224      212      -12     
  Lines       26693    22584    -4109     
  Branches      494      494              
==========================================
- Hits        13902    10870    -3032     
+ Misses      11338    10285    -1053     
+ Partials     1453     1429      -24     

@gzeoneth gzeoneth marked this pull request as ready for review June 24, 2022 16:05
@gzeoneth gzeoneth requested a review from PlasmaPower June 24, 2022 16:06
@gzeoneth gzeoneth enabled auto-merge June 24, 2022 16:07
@gzeoneth gzeoneth disabled auto-merge June 24, 2022 16:09
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit bf120d9 into master Jun 24, 2022
@PlasmaPower PlasmaPower deleted the expose-outbox-isspent branch June 24, 2022 16:32
@gzeoneth gzeoneth restored the expose-outbox-isspent branch June 25, 2022 12:11
@hkalodner hkalodner deleted the expose-outbox-isspent branch July 12, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants