Skip to content

changed recent issues, recent releases to 2 column layout#1090

Merged
arkid15r merged 4 commits intoOWASP:mainfrom
nipunh:feature/improve-project-details-page
Mar 13, 2025
Merged

changed recent issues, recent releases to 2 column layout#1090
arkid15r merged 4 commits intoOWASP:mainfrom
nipunh:feature/improve-project-details-page

Conversation

@nipunh
Copy link
Contributor

@nipunh nipunh commented Mar 13, 2025

Resolves #1089

Changed project details page recent issues / recent releases to a 2 column layout

Screenshot 2025-03-12 at 11 03 00 PM

@nipunh nipunh requested review from arkid15r and kasya as code owners March 13, 2025 03:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2025

Summary by CodeRabbit

  • New Features
    • Improved the details page layout with a grid display for a more organized viewing of recent issues and releases.
    • Upgraded the comments section to dynamically adjust text based on the number of comments, ensuring accurate singular/plural wording.

Walkthrough

The pull request modifies the DetailsCard component by enhancing its layout structure. A fragment wrapping the "Recent Issues" and "Recent Releases" components is replaced with a <div> element that incorporates grid styling. Additionally, the comments count display in the "Recent Issues" section is updated to use the pluralize utility function, allowing for dynamic text rendering based on the number of comments.

Changes

File Change Summary
frontend/src/components/CardDetailsPage.tsx Added import for pluralize utility. Replaced fragment (<>...</>) with a <div> using classes grid-cols-2 gap-4 lg:grid for layout adjustments. Updated comments count display to use pluralize for dynamic text.

Suggested reviewers

  • kasya

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 400ed06 and 9e4af7b.

📒 Files selected for processing (1)
  • frontend/src/components/CardDetailsPage.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/components/CardDetailsPage.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/components/CardDetailsPage.tsx (1)

91-120: Grid Layout Container Configuration

The replacement of the fragment with a <div> that uses grid-cols-2 gap-4 lg:grid meets the PR objective by arranging the "Recent Issues" and "Recent Releases" in two columns on large screens. Please verify that the intended responsive behavior is achieved:

  • On large screens, the lg:grid class enables grid display with two columns as expected.
  • On smaller screens, the absence of the grid class means the layout will default to a block display (i.e., single column).

If the design should always use a grid layout regardless of screen size, consider modifying the container’s classes to something like grid grid-cols-2 gap-4 rather than limiting grid display to large screens.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27b6a and cf668a0.

📒 Files selected for processing (1)
  • frontend/src/components/CardDetailsPage.tsx (2 hunks)

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Could you also take care of 1 comments cases in issues by wrapping it into pluralize?

Screenshot 2025-03-12 at 8 16 23 PM

@nipunh
Copy link
Contributor Author

nipunh commented Mar 13, 2025

Looks good. Could you also take care of 1 comments cases in issues by wrapping it into pluralize?

Screenshot 2025-03-12 at 8 16 23 PM

Pushed this change

@nipunh nipunh requested a review from arkid15r March 13, 2025 03:54
@arkid15r arkid15r enabled auto-merge March 13, 2025 04:25
@sonarqubecloud
Copy link

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Mar 13, 2025
Merged via the queue into OWASP:main with commit 722981e Mar 13, 2025
18 checks passed
This was referenced Mar 22, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 21, 2025
4 tasks
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
* changed recent issues, recent releases to 2 column layout

* used pluralize for comments

* Update code

---------

Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve project details page recent issues / recent releases layout

2 participants