Skip to content

Fix: mentorship programs page responsive on smaller screens#3674

Merged
kasya merged 5 commits intoOWASP:mainfrom
mrkeshav-05:fix/issue-3599
Feb 3, 2026
Merged

Fix: mentorship programs page responsive on smaller screens#3674
kasya merged 5 commits intoOWASP:mainfrom
mrkeshav-05:fix/issue-3599

Conversation

@mrkeshav-05
Copy link
Contributor

Proposed change

This PR makes the public link of program responsive on smaller screens.

Resolves: #3599


image

Checklist

  • Required: I followed the contributing workflow
  • Required: I verified that my code works as intended and resolves the issue as described
  • Required: I ran make check-test locally: all warnings addressed, tests passed
  • I used AI for code, documentation, tests, or communication related to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

Summary by CodeRabbit

  • Style
    • Refined milestone card spacing and alignment for improved visual consistency across different screen sizes.
    • Improved text truncation behavior in milestone details to prevent content overflow.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The PR refactors spacing in CardDetailsPage.tsx from margin-based to flex/gap-based utilities, explicitly adds grid-cols-1 for single-column layout on smaller screens, and adds min-w-0 to the repository link container to improve truncation behavior.

Changes

Cohort / File(s) Summary
Recent Milestones Layout & Spacing
frontend/src/components/CardDetailsPage.tsx
Added explicit grid-cols-1 to Recent Milestones container; converted margin-based gaps (mr-4) to gap-2 utility across milestone item headers; added min-w-0 to repository link container for proper flex shrinking and truncation behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • arkid15r
  • kasya
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title references 'mentorship programs page' and responsiveness on smaller screens, directly matching the main changes to CardDetailsPage component's responsive layout.
Description check ✅ Passed Description mentions making the mentorship programs page responsive on smaller screens and references issue #3599, which aligns with the code changes to the Recent Milestones section layout.
Linked Issues check ✅ Passed Code changes directly address #3599 requirements: grid layout adjusted for small screens (grid-cols-1), spacing refactored with gap utilities, and flex container constraints improved (min-w-0) to ensure proper truncation on mobile.
Out of Scope Changes check ✅ Passed All changes are focused on CardDetailsPage responsive layout improvements specific to the Recent Milestones section, directly addressing the linked issue without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mrkeshav-05 mrkeshav-05 changed the title Mentorship Programs page is not responsive on smaller screens Fix: mentorship programs page responsive on smaller screens Jan 29, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2026

Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkeshav-05 thanks for this update! 👍🏼

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.70%. Comparing base (ffeb5ee) to head (8c4b9ca).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3674   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         462      462           
  Lines       14277    14277           
  Branches     1902     1902           
=======================================
  Hits        12521    12521           
  Misses       1344     1344           
  Partials      412      412           
Flag Coverage Δ
backend 87.45% <ø> (ø)
frontend 88.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
frontend/src/components/CardDetailsPage.tsx 87.59% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffeb5ee...8c4b9ca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kasya kasya added this pull request to the merge queue Feb 3, 2026
Merged via the queue into OWASP:main with commit d3c09fb Feb 3, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mentorship Programs page is not responsive on smaller screens

2 participants