Skip to content

changed recent issues, recent releases to 2 column layout #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 4 commits into from
Mar 13, 2025
Merged

changed recent issues, recent releases to 2 column layout #1090

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bba988a
changed recent issues, recent releases to 2 column layout
nipunh Mar 13, 2025
cf668a0
Merge branch 'main' into feature/improve-project-details-page
nipunh Mar 13, 2025
400ed06
used pluralize for comments
nipunh Mar 13, 2025
9e4af7b
Update code
arkid15r Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions frontend/src/components/CardDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import { DetailsCardProps } from 'types/card'
import { capitalize } from 'utils/capitalize'
import { formatDate } from 'utils/dateFormatter'
import { pluralize } from 'utils/pluralize'
import { getSocialIcon } from 'utils/urlIconMappings'
import ChapterMap from 'components/ChapterMap'
import InfoBlock from 'components/InfoBlock'
Expand Down Expand Up @@ -88,7 +89,7 @@ const DetailsCard = ({
)}
<TopContributors contributors={topContributors} maxInitialDisplay={6} />
{(type === 'project' || type === 'repository') && (
<>
<div className="grid-cols-2 gap-4 lg:grid">
<ItemCardList
title="Recent Issues"
data={recentIssues}
Expand All @@ -99,7 +100,9 @@ const DetailsCard = ({
{item?.commentsCount ? (
<>
<FontAwesomeIcon icon={faFileCode} className="ml-4 mr-2 h-4 w-4" />
<span>{item.commentsCount} comments</span>
<span>
{item.commentsCount} {pluralize(item.commentsCount, 'comment')}
</span>
</>
) : null}
</div>
Expand All @@ -117,7 +120,7 @@ const DetailsCard = ({
</div>
)}
/>
</>
</div>
)}
{type === 'project' && repositories.length > 0 && (
<SecondaryCard title="Repositories" className="mt-6">
Expand Down